Re: pcidevs update for AMD Sensor Fusion Hub

2022-05-05 Thread Jonathan Gray
On Thu, May 05, 2022 at 12:34:33PM +0200, Frederic Cambus wrote: > On Thu, May 05, 2022 at 08:04:16PM +1000, Jonathan Gray wrote: > > On Thu, May 05, 2022 at 11:26:23AM +0200, Frederic Cambus wrote: > > > Hi tech@, > > > > > > Here is a diff to add ID for t

Re: pcidevs update for AMD Sensor Fusion Hub

2022-05-05 Thread Jonathan Gray
On Thu, May 05, 2022 at 11:26:23AM +0200, Frederic Cambus wrote: > Hi tech@, > > Here is a diff to add ID for the AMD Sensor Fusion Hub found on my > Ryzen-based ZBOX CA621. Full dmesg below. > > Comments? OK? Can the string instead be "17h/1xh SFH"? > > Index: sys/dev/pci/pcidevs >

Re: Potential NULL dereference id_entry

2022-04-30 Thread Jonathan Gray
On Sat, Apr 30, 2022 at 07:54:12PM -0600, Ted Bullock wrote: > in radeondrm_attach_kms:508 could potentially fail and result in a NULL > dereference at line 510. Check this with KASSERT(). This can not happen. drm_pciprobe() uses drm_find_description() if it returned NULL the driver would not

Re: xenodm and login_fbtab

2022-04-20 Thread Jonathan Gray
On Wed, Apr 20, 2022 at 05:17:58PM -0500, joshua stein wrote: > xenodm supports login_fbtab(3) to chown devices but it currently > doesn't do anything because /etc/fbtab does not list /dev/ttyC4. It > uses the GiveConsole and TakeConsole scripts in /etc/X11/xenodm/ to > do this manually, but

Re: amd64: do CPU identification before TSC sync test

2022-03-28 Thread Jonathan Gray
On Mon, Mar 28, 2022 at 10:52:09PM -0500, Scott Cheloha wrote: > I want to use the IA32_TSC_ADJUST MSR where available when testing TSC > synchronization. We note if it's available during CPU identification. > > Can we do CPU identification earlier in cpu_hatch() and > cpu_start_secondary(),

Re: riscv64: simplify

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 07:51:25PM +, Miod Vallat wrote: > The riscv64 was likely copied from an architecture > providing optimized byte-swapping code (I'd bet arm64), but doesn't have > any such optimization, and copies the MI code. > > Acknowledge this by dropping the __HAVE_MD_SWAP define

Re: riscv64: faster setregs()

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 08:00:56PM +, Miod Vallat wrote: > The current state of the kernel starts userland processes with register > a0 pointing to the stack, with a comment mentioning this is copied from > FreeBSD. > > But while FreeBSD userland startup code (lib/csu) depends on this, >

Re: riscv64: minor tweaks to sig_machdep.c

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 08:24:05PM +, Miod Vallat wrote: > Two simple changes here: > - dumpframe() is not used by anything. I opted to remove it, but it > could be wrapped in #if 0 or #ifdef DEBUG if people want to keep it > around. > - the /* NOTREACHED */ comment in sendsig() is

Re: riscv64: fix kernel longjmp

2022-03-21 Thread Jonathan Gray
On Mon, Mar 21, 2022 at 08:03:40PM +, Miod Vallat wrote: > Unlike userland, the OpenBSD kernel longjmp() function does not take a > return value for setjmp as second argument, but is guaranteed to return > nonzero. > > The following diff makes sure the code matches this expectation. > >

Re: sdmmc: simplify devlist2h

2022-03-17 Thread Jonathan Gray
On Thu, Mar 17, 2022 at 08:03:20AM +, Miod Vallat wrote: > sys/dev/sdmmc/devlist2h.awk was based upon sys/dev/pcmcia/devlist2h.awk. > The latter contains code to define optional CIS tuple overrides, which > are not used in sdmmc - there is only one override and it is applied in >

Re: bwfm@sdmmc: use symbolic constants for matching

2022-03-17 Thread Jonathan Gray
On Thu, Mar 17, 2022 at 08:05:38AM +, Miod Vallat wrote: > The following diff declares the various devices bwfm@sdmmc checks for, > and introduces no functional change. > > Index: if_bwfm_sdio.c > === > RCS file:

Re: add -k / --keep for gzip(1)

2022-03-03 Thread Jonathan Gray
On Thu, Mar 03, 2022 at 01:13:16PM +0100, Solene Rapenne wrote: > The following diff adds support for -k flag to keep the input file for > gzip / compress when compressing, and the input file (the compressed > one) for gunzip / uncompress what case is not covered by -c > file ? > > This will

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Jonathan Gray
On Mon, Feb 14, 2022 at 12:05:44AM -0700, Ted Bullock wrote: > > On 2022-02-13 11:02 p.m., Jonathan Gray wrote: > > On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: > > > On 2022-02-12 6:46 p.m., Jonathan Gray wrote: > > > > I will review f

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: > On 2022-02-12 6:46 p.m., Jonathan Gray wrote: > > I will review further when you drop the function. > > Alright try this again, I have committed some parts of this, with one commit per specific issue. pa_memex NU

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size =

Re: Import seq(1) from FreeBSD

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 12:07:31PM -0800, Greg Steuck wrote: > Ingo Schwarze writes: > > > Hi Todd, > > > > in view of your arguments and sthen@'s OK, i'm also OK with this > > going in. I think a bit of code cleanup and copy editing in the > > manual page may be useful afterwards, but that can

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Mon, Feb 14, 2022 at 01:31:57AM +1100, Jonathan Gray wrote: > On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > > OF_getproplen() will return -1 if "reset-gpios" is not found which &g

Re: mvpcie(4): fix panic if "reset-gpios" is not available

2022-02-13 Thread Jonathan Gray
On Sun, Feb 13, 2022 at 03:17:27PM +0100, Theo Buehler wrote: > On Sun, Feb 13, 2022 at 02:30:21PM +0100, Tobias Heider wrote: > > OF_getproplen() will return -1 if "reset-gpios" is not found which > > currently causes a panic: > > > > panic: malloc: allocation too large, type = 2, size =

Re: Multiple issues with radeondrm startup code

2022-02-12 Thread Jonathan Gray
On Sat, Feb 12, 2022 at 02:42:16PM -0700, Ted Bullock wrote: > On 2022-02-11 7:16 p.m., Jonathan Gray wrote: > > I'm not so keen on another function and putting bar information into > > local arrays seems odd. > > Are there technical reasons for not wanting a function?

Re: Multiple issues with radeondrm startup code

2022-02-11 Thread Jonathan Gray
On Fri, Feb 11, 2022 at 06:42:11PM -0700, Ted Bullock wrote: > Hey, > > I've found some problems with the radeondrm initialization > codepath (radeon_kms.c). Before I start, I should mention that I am > working on some diffs to remove a bunch of the sparc64 MD ifdef's as > well. In

Re: Adding POSIX c99 compiler wrapper script

2022-02-11 Thread Jonathan Gray
On Fri, Feb 11, 2022 at 04:13:22PM -0600, Joe Nelson wrote: > > I noticed that OpenBSD lacks the POSIX "c99" compiler wrapper. > https://pubs.opengroup.org/onlinepubs/9699919799/utilities/c99.html "[CD] C-Language Development Utilities  The functionality described is optional." I don't see the

Re: explicit_bzero vs ASAN on linux

2022-02-09 Thread Jonathan Gray
On Wed, Feb 09, 2022 at 09:09:35AM +0100, Theo Buehler wrote: > In libressl-portable we run the explicit_bzero tests as part of the > builds. If we enable ASAN on linux, this test segfaults in > __interceptor_memmem() in the two test_with{,out}_bzero() functions, > presumably because the

Re: Use km_alloc(9) in drm

2022-02-06 Thread Jonathan Gray
On Sat, Feb 05, 2022 at 02:26:48PM +0100, Mark Kettenis wrote: > > Date: Sat, 5 Feb 2022 22:34:10 +1100 > > From: Jonathan Gray > > > > On Sat, Feb 05, 2022 at 11:44:03AM +0100, Mark Kettenis wrote: > > > We want to get rid of the uvm_km_valloc() inter

drop please from manual pages

2022-02-05 Thread Jonathan Gray
drop please from manual pages excluding third party parts of tree suggested by multiple documentation style guides diff --git lib/libc/stdlib/atexit.3 lib/libc/stdlib/atexit.3 index a95a45b92e4..891641489e3 100644 --- lib/libc/stdlib/atexit.3 +++ lib/libc/stdlib/atexit.3 @@ -68,7 +68,7 @@ that

Re: Use km_alloc(9) in drm

2022-02-05 Thread Jonathan Gray
On Sat, Feb 05, 2022 at 11:44:03AM +0100, Mark Kettenis wrote: > We want to get rid of the uvm_km_valloc() interfaces in favour of > km_alloc(). This changes the calls in drm(4) over. The kv_physwait > struct is made static to prevent collission with a symbol in > vm_machdep.c on some

Re: Fix a bug in sfcc_cache_wbinv_range()

2022-01-15 Thread Jonathan Gray
On Sat, Jan 15, 2022 at 12:21:59PM +, Visa Hankala wrote: > If the ending address in sfcc_cache_wbinv_range(), pa + len, is not > cache-line-aligned, the function spins because len wraps around. > The following patch fixes this. > > There still is a subtle detail. If len is zero but pa is

fix some spelling mistakes in sys/*fs

2022-01-10 Thread Jonathan Gray
diff --git sys/isofs/cd9660/cd9660_lookup.c sys/isofs/cd9660/cd9660_lookup.c index 3b56a930349..19f2773600e 100644 --- sys/isofs/cd9660/cd9660_lookup.c +++ sys/isofs/cd9660/cd9660_lookup.c @@ -133,7 +133,7 @@ cd9660_lookup(void *v) lockparent = flags & LOCKPARENT; /* -

Re: fix some spelling mistakes in sys/dev

2022-01-08 Thread Jonathan Gray
On Sat, Jan 08, 2022 at 09:59:10AM +, Jason McIntyre wrote: > On Sat, Jan 08, 2022 at 02:38:05PM +1100, Jonathan Gray wrote: > > dwc2, drm and microcode purposefully excluded > > > > morning. > > no need for breakfast after reading this one! > > the spellin

remove unused make defines

2022-01-03 Thread Jonathan Gray
DEFMAXLOCAL unused since 2007 'kill local/jobs distinction. Correctly this time...' https://github.com/openbsd/src/commit/f01cd4cc8e1908cec38b82298fe3fc96c7421321 RANLIBMAG unused since 2012 'more changes, discussed and tested by various people'

Re: remove references to prism54.org

2022-01-03 Thread Jonathan Gray
On Mon, Jan 03, 2022 at 11:37:41AM +0100, Stefan Sperling wrote: > On Mon, Jan 03, 2022 at 12:20:37PM +1100, Jonathan Gray wrote: > > the prism54.org domain is long abandoned > > don't give any traffic to whoever registered it afterwards > > > > ok stsp@ >

fix aac(4) build

2022-01-03 Thread Jonathan Gray
or perhaps we just remove aac entirely? /sys/dev/ic/aac.c:1282:6: error: variable 'error' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (sc->total_fibs == 0) ^~~ Index: aac.c

remove references to prism54.org

2022-01-02 Thread Jonathan Gray
the prism54.org domain is long abandoned don't give any traffic to whoever registered it afterwards Index: share/man/man4/upgt.4 === RCS file: /cvs/src/share/man/man4/upgt.4,v retrieving revision 1.29 diff -u -p -r1.29 upgt.4 ---

fix some spelling mistakes in sys/net*

2022-01-02 Thread Jonathan Gray
diff --git sys/net/fq_codel.c sys/net/fq_codel.c index e5d103cdf57..e614f4c56a7 100644 --- sys/net/fq_codel.c +++ sys/net/fq_codel.c @@ -188,7 +188,7 @@ static const int64_t codel_target = 500; /* Grace period after last drop, 16 100ms intervals */ static const int64_t codel_grace =

Re: syzkaller vnd ioctl unlock

2021-12-22 Thread Jonathan Gray
On Wed, Dec 22, 2021 at 11:56:38PM +0100, Alexander Bluhm wrote: > Hi, > > syzkaller found a missing unlock in vnd ioctl error path. > > https://syzkaller.appspot.com/bug?id=b35a411a91f835fffb793df63aa8bcd7be99ad87 > > ok? ok jsg@ > > bluhm > > Index: dev/vnd.c >

Re: dev/videomode/vesagtf.c: -Werror,-Wunused-but-set-variable fix

2021-12-19 Thread Jonathan Gray
On Sun, Dec 19, 2021 at 08:56:41PM +0900, SASANO Takayoshi wrote: > Hi, > > recently, using -Werror,-Wunused-but-set-variable option makes compile error. > at least vesagtf.c needs fix but some (many?) other codes need do so. clang kernels are built with -Wno-unused-but-set-variable try running

Re: syzkaller nd6_dad_duplicated

2021-12-12 Thread Jonathan Gray
On Sun, Dec 12, 2021 at 11:57:54PM +0100, Alexander Bluhm wrote: > Hi, > > Syskaller has found a NULL deref in nd6_dad_duplicated(). > > https://syzkaller.appspot.com/bug?id=f2ee1cc75911fa580176b09e7c1ab9d867590994 > > The code in nd6_dad_ns_input() looks fishy. It checks dp in two > of three

Re: Handle multi-port CP2108 devices in uslcom(4)

2021-12-12 Thread Jonathan Gray
On Sun, Dec 12, 2021 at 03:18:21PM +, Visa Hankala wrote: > Silicon Labs CP2108 USB device can implement up to four COM ports. Each > port appears as a separate USB virtual COM interface under the device. > > Currently, uslcom(4) always uses the device's first interface, which is > wrong when

Re: uvn_reference(): correct printf() argument order

2021-12-06 Thread Jonathan Gray
On Mon, Dec 06, 2021 at 08:46:57PM -0600, Scott Cheloha wrote: > The arguments to printf() here are backwards. > > ok? ok jsg@ > > Index: uvm_vnode.c > === > RCS file: /cvs/src/sys/uvm/uvm_vnode.c,v > retrieving revision 1.119 >

Re: em(4) vlan tagging support for 82576

2021-12-06 Thread Jonathan Gray
On Mon, Dec 06, 2021 at 10:07:47AM +, Stuart Henderson wrote: > On 2021/12/05 19:22, Yury Shefer wrote: > > Hi all, > > > > I have quad-port Intel ET2 NIC based on 82576[1] controller. The manual > > says that hardware VLAN tagging should be supported but ifconfig output > > shows VLAN_MTU

Re: Xserver 21.1 mode selection fixes

2021-12-05 Thread Jonathan Gray
On Sun, Dec 05, 2021 at 10:28:53PM +0100, Matthieu Herrb wrote: > Hi, > > steven@ reported that, using xf68-video-nv X server 21.1 is dumping > core on startup. > > The following patch fixes it. While here I also fixed another bug on > drivers that don't intialize a private structure. > > If

Re: Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Jonathan Gray
On Fri, Nov 26, 2021 at 05:41:20PM +0100, Jan Stary wrote: > > > Stop building the kernel with -Wno-uninitialized on clang archs. > > > This hides real problems like the recently fixed uninitialised memory > > > use in pf and igc. > > > > > > [-Wsometimes-uninitialized]

Re: [External] : Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-26 Thread Jonathan Gray
On Fri, Nov 26, 2021 at 12:04:21PM +0100, Alexandr Nedvedicky wrote: > Hello, > > On Fri, Nov 26, 2021 at 04:32:59PM +1100, Jonathan Gray wrote: > > Stop building the kernel with -Wno-uninitialized on clang archs. > > This hides real problems like the recently fixed uniniti

Stop building the kernel with -Wno-uninitialized on clang archs

2021-11-25 Thread Jonathan Gray
Stop building the kernel with -Wno-uninitialized on clang archs. This hides real problems like the recently fixed uninitialised memory use in pf and igc. After visa's recent commit the remaining warnings are [-Wsometimes-uninitialized] /sys/arch/arm/arm/cpu.c:352:6: warning: variable 'ci' is

Re: ifconfig: zap dead code

2021-11-03 Thread Jonathan Gray
On Tue, Nov 02, 2021 at 11:47:33PM +, Klemens Nanni wrote: > No idea what it was supposed to do back then; cvs blame points at > > revision 1.19 > date: 1998/09/03 06:24:18; author: jason; state: Exp; lines: +502 > -38; > o OpenBSD gets if_media support (from NetBSD) >

Re: Stop mentioning ld(1) warning messages in mktemp.3 and tmpnam.3

2021-10-24 Thread Jonathan Gray
On Sun, Oct 24, 2021 at 02:27:55PM +0200, Frederic Cambus wrote: > Hi tech@, > > This diff removes mentions of ld warning messages for mktemp(3), > tmpnam(3), and tempnam(3). > > LLD doesn't emit warnings when encountering .gnu.warning.* sections, so > those warnings are not emitted anymore for

Re: use NULL instead of 0 for pointers in sys/net

2021-10-23 Thread Jonathan Gray
t; > Thanks > -- > Sebastien Marie > > > > On Sun, Oct 24, 2021 at 12:14:22PM +1100, Jonathan Gray wrote: > > diff --git sys/net/bpf.c sys/net/bpf.c > > index 87a9d726423..87418c3dc17 100644 > > --- sys/net/bpf.c > > +++ sys/net/bpf.c > &

libc ansi

2021-10-23 Thread Jonathan Gray
Index: db/btree/bt_close.c === RCS file: /cvs/src/lib/libc/db/btree/bt_close.c,v retrieving revision 1.10 diff -u -p -r1.10 bt_close.c --- db/btree/bt_close.c 16 Jan 2015 16:48:51 - 1.10 +++ db/btree/bt_close.c 24 Oct 2021

use NULL instead of 0 for pointers in sys/{crypto,nfs,scsi,uvm}

2021-10-23 Thread Jonathan Gray
excluding sys/crypto/xform_ipcomp.c:76:23 as zlib has Z_NULL as 0 diff --git sys/crypto/cryptosoft.c sys/crypto/cryptosoft.c index dcb815aaa17..be1f3f1ec5c 100644 --- sys/crypto/cryptosoft.c +++ sys/crypto/cryptosoft.c @@ -424,7 +424,7 @@ swcr_authcompute(struct cryptop *crp, struct cryptodesc

use NULL instead of 0 for pointers in sys/ddb

2021-10-23 Thread Jonathan Gray
diff --git sys/ddb/db_break.c sys/ddb/db_break.c index dfe2f3af912..85354e32987 100644 --- sys/ddb/db_break.c +++ sys/ddb/db_break.c @@ -46,8 +46,8 @@ #defineNBREAKPOINTS100 struct db_breakpoint db_break_table[NBREAKPOINTS]; db_breakpoint_tdb_next_free_breakpoint =

use NULL instead of 0 for pointers in sys/netinet*

2021-10-23 Thread Jonathan Gray
diff --git sys/netinet/in_pcb.c sys/netinet/in_pcb.c index cd60f66b50a..d3b6e4a1015 100644 --- sys/netinet/in_pcb.c +++ sys/netinet/in_pcb.c @@ -756,7 +756,7 @@ in_rtchange(struct inpcb *inp, int errno) { if (inp->inp_route.ro_rt) { rtfree(inp->inp_route.ro_rt); -

use NULL instead of 0 for pointers in sys/net

2021-10-23 Thread Jonathan Gray
diff --git sys/net/bpf.c sys/net/bpf.c index 87a9d726423..87418c3dc17 100644 --- sys/net/bpf.c +++ sys/net/bpf.c @@ -1019,7 +1019,7 @@ bpf_setf(struct bpf_d *d, struct bpf_program *fp, int wf) KERNEL_ASSERT_LOCKED(); - if (fp->bf_insns == 0) { + if (fp->bf_insns == NULL) {

Re: pcidevs: intel gemini lake mei

2021-10-21 Thread Jonathan Gray
On Thu, Oct 21, 2021 at 11:17:56PM +0200, Felix Kronlage-Dammers wrote: > hi, > > found this mei pci device id in a gemini lake based shuttle pc. thanks, committed

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Jonathan Gray
On Tue, Oct 19, 2021 at 07:37:36AM -0600, Todd C. Miller wrote: > On Tue, 19 Oct 2021 18:08:04 +1100, Jonathan Gray wrote: > > > There are many others along those lines in the kernel, for example > > sparse complains about these in vfs_subr.c > > > > /sys/kern/vfs

Re: patch: nullify v_data with NULL (and not with 0)

2021-10-19 Thread Jonathan Gray
On Tue, Oct 19, 2021 at 08:32:57AM +0200, Sebastien Marie wrote: > Hi, > > Simple online diff for properly nullify v_data (which is `void *`) > with NULL instead of 0. > > Comments or OK ? > -- > Sebastien Marie > There are many others along those lines in the kernel, for example sparse

Re: [diff] usr.sbin/smtpd add missing includes

2021-10-17 Thread Jonathan Gray
On Sun, Oct 17, 2021 at 04:23:50PM +0200, Philipp wrote: > Hello > > I'm currently working on getting OpenSMTPD-portable build. During this > I found some missing includes. It would help if you could describe the platform you are building on and show the compile errors. > > diff --git

Re: missing newlines in est.c printfs

2021-08-12 Thread Jonathan Gray
On Thu, Aug 12, 2021 at 07:47:36AM +0200, Theo Buehler wrote: > On Thu, Aug 12, 2021 at 03:01:37PM +1000, Jonathan Gray wrote: > > On Thu, Aug 12, 2021 at 06:44:51AM +0200, Theo Buehler wrote: > > > There doesn't seem to be a good reason for omitting the newlines here. > >

Re: missing newlines in est.c printfs

2021-08-11 Thread Jonathan Gray
On Thu, Aug 12, 2021 at 06:44:51AM +0200, Theo Buehler wrote: > There doesn't seem to be a good reason for omitting the newlines here. > If those are ever hit, it will look odd. Am I missing something? See the i386 p3_get_bus_clock() which is where this came from. i386 prints the msr value and a

remove efibind.h cruft

2021-07-26 Thread Jonathan Gray
Follow what was done with riscv64 and replace efibind.h with just the defines we need. Tested on armv7 arm64 and amd64 (bootx64). Index: sys/stand/efi/include/amd64/efibind.h === RCS file:

Re: iwm(4): enable on riscv64

2021-07-25 Thread Jonathan Gray
On Fri, Jul 23, 2021 at 04:36:57PM -0400, Ashton Fagg wrote: > The following diffs adds iwm(4) to the riscv64 kernel config. > > I tested this with the following device: > > iwm0 at pci5 dev 0 function 0 "Intel Dual Band Wireless-AC 9260" rev 0x29, > intx > > icarus$ ifconfig iwm0 > iwm0:

Re: ix(4)/riscv64: Make ix(4) work when MSI-X interrupts aren't available

2021-07-24 Thread Jonathan Gray
On Thu, Jul 22, 2021 at 09:04:29PM -0400, Ashton Fagg wrote: > Jonathan Matthew writes: > > > Yes, on second look that makes sense. Here's a better diff with that > > change, and that also doesn't break arches without __HAVE_PCI_MSIX. > > ok? > > Jonathan/Mark, > > Thank you for your help

Re: sleep.3: miscellaneous cleanup and rewrites

2021-07-24 Thread Jonathan Gray
On Sat, Jul 24, 2021 at 10:39:49PM -0500, Scott Cheloha wrote: > Okay, the nanosleep.2 changes are committed, let's do sleep.3 next. > > Here's a changelist by section. I have some questions in there at end > of sections where I'm unsure about something. > > NAME > > - This is clunky. Tighten

update xf86-video-amdgpu to latest git

2021-07-08 Thread Jonathan Gray
The latest xf86-video-amdgpu release was in 2019. xf86-video-amdgpu-19.1.0..origin/master minus commits we already have cb27a5b Handle NULL fb_ptr in pixmap_get_fb e2cd67a Bail from amdgpu_pixmap_get_handle with ShadowFB edcbe5f Fix link failure with gcc 10 With a X_PRIVSEP path added to

Re: arm9 support?

2021-06-30 Thread Jonathan Gray
On Tue, Jun 29, 2021 at 10:38:33PM -0700, pion wrote: > I’m interested in porting OpenBSD to the Nuvoton NUC980, which uses an > ARM926EJ-S core. I discovered that arm9 support was removed in 2016 and found > the relevant patches in tech@. It seems that the rationale was that arm8/9 > platforms

Re: Adjust url of SD Association in comment in sdhc.c

2021-06-13 Thread Jonathan Gray
On Sun, Jun 13, 2021 at 05:41:32AM +0200, Felix Kronlage-Dammers wrote: > hi, > > the legit URL of the SD Associations is www.sdcard.org, not > www.sdcard.com. > > felix > thanks, committed > > > Index: sys/dev/sdmmc/sdhc.c >

Re: pcidevs + azalia: patch for new intel audio

2021-06-11 Thread Jonathan Gray
On Fri, Jun 11, 2021 at 10:03:07AM -0400, Ashton Fagg wrote: > Friendly ping. > > Ashton Fagg writes: > > > My new Intel Z590-based machine seems to have some different kind of > > Intel audio device onboard. > > > > I couldn't find very much online about it (all the usual pci id > > databases

Re: limit MSR_INT_PEN_MSG use to < family 16h

2021-06-10 Thread Jonathan Gray
On Wed, Jun 09, 2021 at 10:35:48PM -0700, Mike Larkin wrote: > On Thu, Jun 10, 2021 at 03:19:43PM +1000, Jonathan Gray wrote: > > Ilya Voronin sent a diff to misc to limit MSR_INT_PEN_MSG use to > > < AMD family 17h prompted by a problem with an AWS t3a instance. > >

limit MSR_INT_PEN_MSG use to < family 16h

2021-06-09 Thread Jonathan Gray
Ilya Voronin sent a diff to misc to limit MSR_INT_PEN_MSG use to < AMD family 17h prompted by a problem with an AWS t3a instance. https://marc.info/?l=openbsd-misc=162120066715633=2 Digging some more the 16h bkdgs have it as RAZ/non-functional as well. Bits are documented in 15h. BKDG for AMD

Re: mkuboot.8: Add missing arm64 architecture

2021-05-31 Thread Jonathan Gray
On Tue, Jun 01, 2021 at 01:43:32AM +0200, Leon Fischer wrote: > The mkuboot(8) man page was not updated after this commit: > > RCS file: /cvs/src/usr.sbin/mkuboot/mkuboot.c,v > > revision 1.7 > date: 2016/12/20 11:27:11; author: jsg; state: Exp; lines: +3 -1; >

Re: Fix and includes on powerpc*

2021-05-29 Thread Jonathan Gray
On Sun, May 30, 2021 at 05:03:47AM +, Visa Hankala wrote: > powerpc and powerpc64's include too late > and accidentally rely on other code to pull in the header. If the mutex > header is removed from the , the build fails: > > In file included from src/sys/dev/rnd.c:84: > In file included

Re: Add missing includes

2021-05-29 Thread Jonathan Gray
On Sun, May 30, 2021 at 05:01:05AM +, Visa Hankala wrote: > The kernel has places where mutexes are used but is not > included directly. Some of them get exposed when #include > is removed from soft interrupt headers. The following diff fixes them. > > OK? ok jsg@ > > Index:

Re: [PATCH] [src] sys/dev/usb/usbdevs - add "SHARKOON Technologies GmbH" vendor ID

2021-05-24 Thread Jonathan Gray
On Mon, May 24, 2021 at 03:52:44PM +0100, Raf Czlonka wrote: > Hello, > > Pretty self-explanatory - add "SHARKOON Technologies GmbH" vendor ID. 0x1ea7 / 7847 is 'SEMITEK INTERNATIONAL (HK) HOLDING LTD.' in https://usb.org/sites/default/files/vendor_ids033021.pdf > > Regards, > > Raf > >

Re: [Patch] Add support for Realtek RTL8111FP-CG Ethernet Controller

2021-05-06 Thread Jonathan Gray
On Thu, May 06, 2021 at 12:38:17PM -0400, Stephen Taylor wrote: > This is my first post to the mailing list and my first time customizing > the kernel. I apologize in advance for mistakes I make. > > I have a Lenovo ThinkCenter M75n Nano IoT computer. It uses the Realtek > RTL8111FP-CG Ethernet

Re: enable dt(4)

2021-04-26 Thread Jonathan Gray
On Mon, Apr 26, 2021 at 03:01:58PM +0200, Alexander Bluhm wrote: > On Mon, Apr 26, 2021 at 12:35:11PM +0200, Patrick Wildt wrote: > > I can't vouch that it builds for all architectures... Did anyone do > > that? Number 1 rule: don't break Theo's build. > > Compiled, booted, set kern.allowdt=1,

Re: [Patch] Fix mangled sentence in 69.html (apmd control socket)

2021-04-19 Thread Jonathan Gray
On Sun, Apr 18, 2021 at 09:09:24PM +1000, Ross L Richardson wrote: > Simplest fix below. > > Ross > thanks, committed this with a few more changes Index: 69.html === RCS file: /cvs/www/69.html,v retrieving revision 1.58 diff

Re: [Patch] "usb" ==> "USB" for consistency

2021-04-19 Thread Jonathan Gray
On Sun, Apr 18, 2021 at 09:21:45PM +1000, Ross L Richardson wrote: > Probably! > > Ross > > thanks, committed > > Index: 69.html > === > RCS file: /cvs/www/69.html,v > retrieving revision 1.52 > diff -u -p -r1.52 69.html >

Re: [Patch] Typo ("it's" should be "its") in 69.html

2021-04-19 Thread Jonathan Gray
On Mon, Apr 19, 2021 at 02:30:13PM +1000, Ross L Richardson wrote: > Just an incorrect possessive form... > > Ross > thanks, committed > > Index: 69.html > === > RCS file: /cvs/www/69.html,v > retrieving revision 1.53 > diff -u

Re: [Patch] Relocate a vmctl entry in 69.html

2021-04-19 Thread Jonathan Gray
On Mon, Apr 19, 2021 at 03:08:13PM +1000, Ross L Richardson wrote: > It probably belongs with the other vmctl entry rather than under > userland networking changes... > > Ross > thanks, committed > > Index: 69.html > === > RCS

Re: add missing PCI ID for Intel NVMe

2021-03-13 Thread Jonathan Gray
t; On Fri, Mar 12, 2021 at 10:00:54PM +1100, Jonathan Gray wrote: > > On Fri, Mar 12, 2021 at 11:30:04AM +0100, Jan Klemkow wrote: > > So it is a 'SSD DC P4510' > > > > A driver downloaded from Intel has > > ... > > PCI\VEN_8086_0A54.DeviceDes

Re: add missing PCI ID for Intel NVMe

2021-03-12 Thread Jonathan Gray
On Fri, Mar 12, 2021 at 11:30:04AM +0100, Jan Klemkow wrote: > Hi, > > This diff add a missing PCI ID of an Intel NVMe disk. The disk works > after my last fix [1]. > > OK? > > bye, > Jan > > [1]: https://marc.info/?l=openbsd-tech=161418460303831 So it is a 'SSD DC P4510' A driver

Re: Sky Lake-E PCI ids.

2021-02-26 Thread Jonathan Gray
On Fri, Feb 26, 2021 at 11:12:17AM +0100, Karel Gardas wrote: > On 2/26/21 7:24 AM, Jonathan Gray wrote: > > As the ids are used on more than just Skylake-E here is another diff. > > Though I think these ids are shared with Core X Skylake. So perhaps > > giving up on a mar

Mesa leak in intel iris driver

2021-02-26 Thread Jonathan Gray
Bring in a change which was backported to Mesa 20.1 but not 20.0. This is for inteldrm with >= gen8/broadwell hardware. /var/log/Xorg.0.log with 'DRI driver: iris' and 'xdriinfo' will show 'Screen 0: iris' if you are using the iris driver. commit 17991448a2eb0930b106068bffc366946a05556e Author:

Re: Sky Lake-E PCI ids.

2021-02-25 Thread Jonathan Gray
On Fri, Feb 26, 2021 at 05:24:59PM +1100, Jonathan Gray wrote: > On Thu, Feb 25, 2021 at 02:55:22PM +0100, Karel Gardas wrote: > > > > > The marketing name is 'Xeon Processor Scalable Family' > > > Intel Xeon Bronze 3XXX processor > > > Intel Xeon Gold 6XXF

Re: Sky Lake-E PCI ids.

2021-02-25 Thread Jonathan Gray
On Thu, Feb 25, 2021 at 02:55:22PM +0100, Karel Gardas wrote: > > > The marketing name is 'Xeon Processor Scalable Family' > > Intel Xeon Bronze 3XXX processor > > Intel Xeon Gold 6XXF processor > > Intel Xeon Platinum 6XXF processor > > Intel Xeon Platinum 8XXF processor > > Intel Xeon Silver

Re: Sky Lake-E PCI ids.

2021-02-25 Thread Jonathan Gray
On Thu, Feb 25, 2021 at 11:29:09AM +0100, Karel Gardas wrote: > On 2/25/21 10:34 AM, Jonathan Gray wrote: > > On Wed, Feb 24, 2021 at 05:01:50PM +0100, Karel Gardas wrote: > > > Hello, > > > > > > attach patch adds some SkyLake-E related PCI ids. Tested on

Re: Sky Lake-E PCI ids.

2021-02-25 Thread Jonathan Gray
On Wed, Feb 24, 2021 at 05:01:50PM +0100, Karel Gardas wrote: > > Hello, > > attach patch adds some SkyLake-E related PCI ids. Tested on Kontron/Fujitsu > D3598-B with Intel Xeon W-2123. > > Thanks for review, comment(s) and/or commit. > > Karel > I can only find a handful of Ubox/PCU

Re: occasional SSIGSEGV on C++ exception handling

2021-02-22 Thread Jonathan Gray
On Tue, Feb 23, 2021 at 08:10:54AM +0100, Otto Moerbeek wrote: > On Mon, Feb 22, 2021 at 08:58:07PM -, Miod Vallat wrote: > > > > > > No problem, real-life often takes precedence. > > > > No way! operator(7) would need an update! > > > > What do we do when we see a bug? We fix it! What if

Re: use /dev/dri/ in xenocara

2021-02-18 Thread Jonathan Gray
On Thu, Feb 18, 2021 at 11:34:19AM +, Stuart Henderson wrote: > On 2021/02/18 22:24, Jonathan Gray wrote: > > On Thu, Feb 18, 2021 at 12:01:28PM +0100, Mark Kettenis wrote: > > > > Date: Thu, 18 Feb 2021 21:18:51 +1100 > > > > From: Jonathan Gray > >

Re: use /dev/dri/ in xenocara

2021-02-18 Thread Jonathan Gray
On Thu, Feb 18, 2021 at 12:29:29PM +0100, Mark Kettenis wrote: > > Date: Thu, 18 Feb 2021 22:24:10 +1100 > > From: Jonathan Gray > > > > On Thu, Feb 18, 2021 at 12:01:28PM +0100, Mark Kettenis wrote: > > > > Date: Thu, 18 Feb 2021 21:18:51 +1100 > &g

Re: use /dev/dri/ in xenocara

2021-02-18 Thread Jonathan Gray
On Thu, Feb 18, 2021 at 12:01:28PM +0100, Mark Kettenis wrote: > > Date: Thu, 18 Feb 2021 21:18:51 +1100 > > From: Jonathan Gray > > I suspect that there are some ports that need to get their unveils > updated if we do this. firefox ports were updated. Not aware of a

use /dev/dri/ in xenocara

2021-02-18 Thread Jonathan Gray
Index: lib/libdrm/xf86drm.h === RCS file: /cvs/xenocara/lib/libdrm/xf86drm.h,v retrieving revision 1.21 diff -u -p -r1.21 xf86drm.h --- lib/libdrm/xf86drm.h11 Feb 2021 10:27:08 - 1.21 +++ lib/libdrm/xf86drm.h

Re: add simplepmbus(4)

2021-02-17 Thread Jonathan Gray
On Wed, Feb 17, 2021 at 11:49:27AM +0100, Mark Kettenis wrote: > > Date: Wed, 17 Feb 2021 20:59:06 +1100 > > From: Jonathan Gray > > > > On Wed, Feb 17, 2021 at 10:33:18AM +0100, Patrick Wildt wrote: > > > Am Wed, Feb 17, 2021 at 11:56:16AM +1100 schrieb Jo

Re: add simplepmbus(4)

2021-02-17 Thread Jonathan Gray
On Wed, Feb 17, 2021 at 10:33:18AM +0100, Patrick Wildt wrote: > Am Wed, Feb 17, 2021 at 11:56:16AM +1100 schrieb Jonathan Gray: > > Add a driver for "simple-pm-bus" a way to enable a clock and/or > > power domain for a group of devices. > > > > https://www.ke

add simplepmbus(4)

2021-02-16 Thread Jonathan Gray
us.c Tue Feb 16 17:24:55 2021 @@ -0,0 +1,62 @@ +/* $OpenBSD$ */ +/* + * Copyright (c) 2021 Jonathan Gray + * + * Permission to use, copy, modify, and distribute this software for any + * purpose with or without fee is hereby granted, provided that the above + * copyri

Re: some Ryzen, AMD 500 Chipset, Navi 10 and Kingson pcidev

2021-02-15 Thread Jonathan Gray
On Mon, Feb 08, 2021 at 10:48:26AM +0100, Sven Wolf wrote: > Hi, > > thanks for your fast response. > I've chosen "AMD 17_3X_IOMMU" instead of "Starship/Matisse" because in my > point of view, also the other Ryzen Zen 2 pci devices were named 17_3x (e.g. > PCI_PRODUCT_AMD_17_3X_RC 0x1480 /*

Re: some Ryzen, AMD 500 Chipset, Navi 10 and Kingson pcidev

2021-02-07 Thread Jonathan Gray
On Sun, Feb 07, 2021 at 07:58:52PM +0100, Sven Wolf wrote: > Hi, > > I've added some Ryzen 3xxx, AMD 500 Chipset, Navi 10 and Kingston ids to > pcidev. I've taken the description from the Linux PCI device ids > https://pci-ids.ucw.cz/v2.2/pci.ids > > ok? Can you show a dmesg? Many of these

Re: execve -1 errno 12 Cannot allocate memory

2021-01-29 Thread Jonathan Gray
On Fri, Jan 29, 2021 at 09:48:42AM -0500, Philippe Meunier wrote: > Philippe Meunier wrote: > >Is there some kind of limitation on the size of an ELF executable that can > >be executed on i386? I mean, in addition to the limits in /etc/login.conf? > > When using readelf(1) on the chrome

Re: df(1): formatting adjustments and -T support

2021-01-23 Thread Jonathan Gray
On Fri, Jan 22, 2021 at 11:11:27PM -0600, Katherine Rohl wrote: > I noticed that large disk volumes cause problems with the formatting of > numerical columns in df(1), particularly when using -i. Here's a patch > that pads out their width a bit and raises the maximum width of > numerical columns

Re: drm(4) memory allocation diff

2021-01-01 Thread Jonathan Gray
On Thu, Dec 31, 2020 at 10:09:36PM +0100, Mark Kettenis wrote: > The diff below changes the emulated Linux memory allocation functions > a bit such that they only use malloc(9) for allocations smaller than a > page. This reduces pressure on the "interrupt safe" map and hopefully > will avoid the

Re: Poison file names

2020-12-13 Thread Jonathan Gray
On Sun, Dec 13, 2020 at 08:02:53PM -0500, Daniel Dickman wrote: > On Sun, Dec 13, 2020 at 7:51 PM Jonathan Gray wrote: > > > > On Sun, Dec 13, 2020 at 03:44:54PM -0500, Daniel Dickman wrote: > > > > > > > > > On Sat, 12 Dec 2020, Jonathan Gray wr

Re: Poison file names

2020-12-13 Thread Jonathan Gray
On Sun, Dec 13, 2020 at 03:44:54PM -0500, Daniel Dickman wrote: > > > On Sat, 12 Dec 2020, Jonathan Gray wrote: > > > games/battlestar/com1.c > > games/battlestar/com2.c > > games/battlestar/com3.c > > games/battlestar/com4.c > > games/battlestar/co

  1   2   3   4   5   6   7   8   >