Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-29 Thread Schreilechner, Dominik
> > I think the changes in ip_insertoptions() can be dropped completely, > > because the if-statement uses ip-ip_hl, which might not be initialized. > > yes, you are right, I think we should rather go for this tweak: > >

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-29 Thread Schreilechner, Dominik
Hi, > yes, you are right. below is updated diff I would like to commit. > > > > Appart from that, adding a special task seems the way to go. > > I think so too. Alternative way would be to pass send flags via m_pkthdr > in mbuf, however there is no space. We would have to add a new

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-26 Thread Schreilechner, Dominik
> -Original Message- > From: Alexandr Nedvedicky > Sent: Donnerstag, 25. März 2021 17:36 > To: Schreilechner, Dominik (RC-AT DI FA DH-GRAZ ICO) > > Cc: tech@openbsd.org > Subject: Re: [External] : [ICMP] IP options lead to malformed reply > > Hello, > >

Re: [External] : [ICMP] IP options lead to malformed reply

2021-03-25 Thread Schreilechner, Dominik
> -Original Message- > From: Alexandr Nedvedicky > Sent: Mittwoch, 24. März 2021 23:09 > To: Schreilechner, Dominik (RC-AT DI FA DH-GRAZ ICO) > > Cc: tech@openbsd.org > Subject: Re: [External] : [ICMP] IP options lead to malformed reply > > Hello, > > &g

[ICMP] IP options lead to malformed reply

2021-03-24 Thread Schreilechner, Dominik
Hi, When sending an ICMP request with IP options to an OpenBSD Box, the ICMP payload of the reply is malformed. In the reply the length field of the IP header is 20, even though the reply contains the IP options. Meaning, in this packet the IP options are part of ICMP and not IP. This was tested

dhclient requested ip address in decline message

2020-07-30 Thread Schreilechner, Dominik
Hi, If the dhclient receives an OFFER or ACK, that does not contain all required parameters, a DECLINE is send. This DECLINE has the 'Requested IP Address' (DHO_DHCP_REQUESTET_ADDRESS) set to 0 instead of using the client IP address (yiaddr) from the packet. As far as I see it, the 'Requested

Re: VFS vgone(l) manpage vs. code

2020-07-30 Thread Schreilechner, Dominik
> From: Jason McIntyre, Mittwoch, 29. Juli 2020 14:23 > > On Wed, Jul 29, 2020 at 11:37:03AM +, Schreilechner, Dominik wrote: > > Hi, > > > > I noticed, that the description of vgone/vgonel in the manpage does not > > match the \ > > code. The manpage

VFS vgone(l) manpage vs. code

2020-07-29 Thread Schreilechner, Dominik
Hi, I noticed, that the description of vgone/vgonel in the manpage does not match the code. The manpage (https://man.openbsd.org/vgone) states: The difference between vgone() and vgonel() is that vgone() locks the vnode interlock and then calls vgonel() while vgonel() expects the interlock to