Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Sebastian Benoit
still ok Florian Obser(flor...@openbsd.org) on 2020.10.20 21:36:06 +0200: > On Tue, Oct 20, 2020 at 01:11:09PM -0600, Theo de Raadt wrote: > > I believe most of the new local variables you added in main, > > can instead be added in the flush loop you wrote, even if you > > have to instantiate

Re: ping(8) put hop_limit warning in verbose mode

2020-10-20 Thread Sebastian Benoit
i had observed this before with for i in `jot 5`;do ping6 -c 1 2001:4860:4860:: 1>/dev/null diff fixes the problem and looks correct to me. ok benno@ Florian Obser(flor...@openbsd.org) on 2020.10.20 18:39:58 +0200: > On Tue, Oct 20, 2020 at 04:07:41PM +0200, Martijn van Duren wrote: > >

rpki-client 6.8p0 released

2020-10-20 Thread Sebastian Benoit
the Internet's global routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, and Sebastian Benoit as part of the OpenBSD Project and gets released as a base component of OpenBSD every six months, and follows the OpenBSD release numbering scheme

Re: acme-client: relax certificate parsing

2020-09-15 Thread Sebastian Benoit
ok Florian Obser(flor...@openbsd.org) on 2020.09.14 17:12:01 +0200: > Relax parsing of pem files a bit. Apparently there are CAs that use > \r\n line endings. > From Bartosz Kuzma as part of a larger diff. > > OK? > > diff --git certproc.c certproc.c > index 7fde96e970e..975e12afaaa 100644 >

Re: acme-client(1) and Buypass Go SSL

2020-09-15 Thread Sebastian Benoit
ok! Florian Obser(flor...@openbsd.org) on 2020.09.14 17:15:37 +0200: > > This fell through the cracks back in April. > > We need to be able to provide contact information to use the > buypass.com acme api. > > OK? > > diff --git etc/examples/acme-client.conf etc/examples/acme-client.conf >

Re: [Patch] Change httpd's handling of request "Host:" headers

2020-08-10 Thread Sebastian Benoit
Ross L Richardson(open...@rlr.id.au) on 2020.08.09 20:07:11 +1000: > > At present, if a request contains no "Host:" header [HTTP pre-1.1] or > if the supplied header does not match any of the servers configured > in httpd.conf, the request is directed to the first server. This > isn't

Re: PATCH: iostat spacing

2020-08-09 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2020.08.08 04:12:31 +0200: > On Fri, Aug 07, 2020 at 12:04:59PM -0700, jo...@armadilloaerospace.com wrote: > > IO rates above 100 MB/s are common with SSD; this patch expands the > > column so it stays neatly printed. > This is OK with me as it fixes the default

Re: [Patch] Remove unused functions in httpd's proc(?)

2020-08-03 Thread Sebastian Benoit
Ross L Richardson(open...@rlr.id.au) on 2020.08.03 15:25:05 +1000: > cppcheck reports that proc_iev and proc_ispeer are unused. > > Unless they are wanted for consistency with other versions of proc.c, > tbey can be removed. Yes, proc.c should stay the same across ./sbin/iked/proc.c

Re: [Patch] Remove unused functions in httpd[.ch]

2020-08-03 Thread Sebastian Benoit
ok Ross L Richardson(open...@rlr.id.au) on 2020.08.03 15:37:50 +1000: > cppcheck reports that kv_inherit(), kv_log(), and print_time() are unused. > > The patch below deletes them. > > Ross > -- > > Index: httpd.c > === > RCS

Re: [Patch] Remove redundant condition in httpd's server_http.c

2020-08-03 Thread Sebastian Benoit
ok Ross L Richardson(open...@rlr.id.au) on 2020.08.03 15:06:31 +1000: > cppcheck reports this [and other less simple things]. > > Ross > > Index: server_http.c > === > RCS file: /cvs/src/usr.sbin/httpd/server_http.c,v > retrieving

Re: [Patch] Remove unnecessary assignment in httpd's server_fcgi.c

2020-08-02 Thread Sebastian Benoit
ok Ross L Richardson(open...@rlr.id.au) on 2020.08.02 21:52:50 +1000: > cppcheck finds an unnecessary assignment. > > The patch below deletes it. > > Ross > > Index: server_fcgi.c > === > RCS file:

Re: [Patch] Delete redundant condition in httpd's proc.c

2020-08-02 Thread Sebastian Benoit
ok relayd has the same btw. Ross L Richardson(open...@rlr.id.au) on 2020.08.02 21:41:33 +1000: > cppcheck finds a redundant condition. > > The patch below deletes it. > > Ross > > Index: proc.c > === > RCS file:

Re: [Patch] Delete unread assignments in httpd's config.c

2020-08-02 Thread Sebastian Benoit
ok Ross L Richardson(open...@rlr.id.au) on 2020.08.02 21:32:44 +1000: > cppcheck finds some unread assignments in httpd's config.c > > The patch below deletes them and the resulting unused variables. By way of > [a bit more] context, the last of these is: > >682if

Re: ssh(1), getrrsetbyname(3), SSHFP and DNSSEC

2020-07-29 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2020.07.29 15:51:55 +0200: > On Sun, Jul 26 2020, Jeremie Courreges-Anglas wrote: > > On Sat, Jul 25 2020, Sebastian Benoit wrote: > > [...] > > >> If you enable trust-ad on a system that moves around, e.g. your lapto

Re: ssh(1), getrrsetbyname(3), SSHFP and DNSSEC

2020-07-29 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2020.07.26 22:52:47 +0200: > On Sat, Jul 25 2020, Sebastian Benoit wrote: > > Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2020.07.25 14:01:06 +0200: > >> On Fri, Jul 17 2020, Jesper Wallin wrote: > >> > Hi all, > >

Re: ssh(1), getrrsetbyname(3), SSHFP and DNSSEC

2020-07-25 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2020.07.25 14:01:06 +0200: > On Fri, Jul 17 2020, Jesper Wallin wrote: > > Hi all, > > > > I recently decided to add SSHFP records for my servers, since I never > > memorize or write down my key fingerprints. I learned that if I > > want ssh(1) to

Re: acme-client config grammar improvements

2020-07-21 Thread Sebastian Benoit
Daniel Eisele(daniel_eis...@gmx.de) on 2020.07.16 07:40:35 +0200: > Am 15.07.2020 um 23:51 schrieb Sebastian Benoit: > >> src/usr.sbin/acme-client/parse.y: > >> * The grammar allows the user to omit the newline after the first line > >> in a domain or authority

Re: [Patch] httpd.h - delete unused field and enum

2020-07-21 Thread Sebastian Benoit
Ross L Richardson(open...@rlr.id.au) on 2020.07.15 14:49:23 +1000: > Field kv_type in struct kv is not used. As that's the only use of > enum key_type, delete them both. This is probably because its a copy from relayd. I dont think there is a reason to keep it. i'd like to commit, anyone else

Re: acme-client config grammar improvements

2020-07-15 Thread Sebastian Benoit
Daniel Eisele(daniel_eis...@gmx.de) on 2020.07.15 09:32:37 +0200: > Hi, > > I'm currently porting acme-client to FreeBSD and while doing that I've > noticed a few small issues. > > src/usr.sbin/acme-client/parse.y: > * The grammar allows the user to omit the newline after the first line > in a

Re: 11n Tx aggregation for iwm(4)

2020-06-29 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2020.06.29 16:18:03 +0200: > Stefan Sperling(s...@stsp.name) on 2020.06.26 14:45:53 +0200: > > This patch adds support for 11n Tx aggregation to iwm(4). > > > > Please help with testing if you can by running the patch and using wifi

Re: 11n Tx aggregation for iwm(4)

2020-06-29 Thread Sebastian Benoit
Stefan Sperling(s...@stsp.name) on 2020.06.26 14:45:53 +0200: > This patch adds support for 11n Tx aggregation to iwm(4). > > Please help with testing if you can by running the patch and using wifi > as usual. Nothing should change, except that Tx speed may potentially > improve. If you have time

Re: unveil(2) relayd(8)'s main proc, now for real

2020-06-19 Thread Sebastian Benoit
Ricardo Mestre(ser...@helheim.mooo.com) on 2020.06.18 23:40:54 +0100: > Hi, > > Yes, this is a really broad permission to give but it's needed in order to > read > the config file (and those ones included from it) and also to exec the "check > script(s)" which I missed in my last attempt to

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-13 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2020.06.11 21:46:45 +0200: > > This would be clearer if it used table/tables as appropriate e.g. > > > > Routing table: 0 > > Routing table: 100 > > Routing tables: 0 6 7 77 > > > > the code to handle this gets messy though, maybe someone can think >

Re: netstat -R: list rdomains with associated ifs and tables

2020-06-10 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2020.06.10 22:16:36 +0200: > On Tue, Jun 09, 2020 at 10:02:06AM +0200, Remi Locherer wrote: > > On Tue, Jun 09, 2020 at 09:17:31AM +0200, Claudio Jeker wrote: > > > On Tue, Jun 09, 2020 at 08:44:42AM +0200, Remi Locherer wrote: > > > > On Mon, Jun 08, 2020

Re: urtwn(4) hardware crypto

2020-06-08 Thread Sebastian Benoit
Jonathan Matthew(jonat...@d14n.org) on 2020.06.05 21:54:30 +1000: > This enables use of hardware crypto for CCMP in urtwn(4). As with other > drivers, this reduces cpu usage significantly when moving lots of data. > I've tested this on an assortment of hardware (RTL8188CUS, RTL8188EU, > RTL8192EU)

Re: ospf6d: change the way interfaces are handled

2020-06-03 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2020.06.03 15:36:17 +0200: > On Sat, May 30, 2020 at 04:37:43PM +0200, Denis Fondras wrote: > > This diff updates how ospf6d(8) handles interfaces. > > It is now in line with what ospfd(8) does. > > > > Last step before enabling reload. > > > > Tested

Re: sysupgrade change to allow installing from url

2020-05-25 Thread Sebastian Benoit
Solene Rapenne(sol...@perso.pw) on 2020.05.25 15:25:40 +0200: > Hi, > > I don't know if this will be accepted but I propose to add a -u [url] > parameter to use older snapshots from an archive server for example. > > I wanted to add an optional parameter to -s at first but in case of >

Re: {plus,}67.html: fix link crontab(5)

2020-05-21 Thread Sebastian Benoit
Martin Vahlensieck(open...@academicsolutions.ch) on 2020.05.20 19:15:48 +0200: > Hey there! > > Otherwise it's going to crontab(1). Thanks, commited. Benno

Re: include interface name in rad error message

2020-05-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.20 09:12:23 +0200: > In my syslog I have this: > rad[83563]: RA from non link local address :: > now it would be splendid to know on which of the 4 interfaces rad is > operating on this happened. So here is a diff doing that. ok > > -- >

rpki-client 6.7p0 released

2020-05-18 Thread Sebastian Benoit
the Internet's global routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, and Sebastian Benoit as part of the OpenBSD Project and gets released as a base component of OpenBSD every six months, and follows the OpenBSD release numbering scheme

Re: bgpctl parser cleanup

2020-05-12 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.12 12:42:36 +0200: > Minimal cleanup of things not used in the bgpctl parser. > Bulk is not used and the ADDRESS / PREFIX tokens no longer overwrite the > action since a while. ok benno@ > > -- > :wq Claudio > > Index: parser.c >

Re: teach bgpctl about IPv6 MPLS VPN

2020-05-10 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.05.08 09:40:38 +0200: > Bgpctl has a way to specify the address family to show in 'show rib' > commands. Teach it to also support IPv6 MPLS VPNs (aka VPNv6). > > OK? ok > -- > :wq Claudio > > Index: parser.c >

Re: [patch] relayd.conf.5, DHE params seems incorrect/outdated.

2020-05-02 Thread Sebastian Benoit
Jesper Wallin(jes...@ifconfig.se) on 2020.05.01 12:15:06 +0200: > Hi all, > > I was trying to score 100 on all the tests over at ssllabs.com, but seem > to only reach 90 on "Key Exchange". Not sure if it's related, but I was > playing with the "dhe" option in relayd.conf(5) in order to increase

Re: iked(8): Removing SHA1 from default transforms

2020-05-01 Thread Sebastian Benoit
Stuart Henderson(s...@spacehopper.org) on 2020.05.01 23:46:49 +0100: > On 2020/05/02 00:43, Stephan Mending wrote: > > On 02/05/2020 00:40, Stuart Henderson wrote: > > > On 2020/05/02 00:23, Stephan Mending wrote: > > > > Hi, > > > > > > > > I actually read your thread. By what I understood

Re: JSON support for bgpctl(8)

2020-05-01 Thread Sebastian Benoit
Hiltjo Posthuma(hil...@codemadness.org) on 2020.05.01 16:31:33 +0200: > On Fri, May 01, 2020 at 01:18:03PM +0200, Claudio Jeker wrote: > > This diff add JSON output support for bgpctl. > > Most commands should produce now a resonable JSON object. > > The individual objects can probably be improved

Re: [patch] relayd.conf.5, DHE params seems incorrect/outdated.

2020-05-01 Thread Sebastian Benoit
Jesper Wallin(jes...@ifconfig.se) on 2020.05.01 12:15:06 +0200: > Hi all, > > I was trying to score 100 on all the tests over at ssllabs.com, but seem > to only reach 90 on "Key Exchange". Not sure if it's related, but I was > playing with the "dhe" option in relayd.conf(5) in order to increase

Re: [PATCH] sysupgrade

2020-04-30 Thread Sebastian Benoit
James Jerkins(j...@jamesjerkinscomputer.com) on 2020.04.29 22:28:12 -0500: > Hello, > > This patch adds two new options to sysupgrade. The first option is for > small box systems like an APU system that only has the base and manual We wont add tons of options to this tool for every use case.

alpha installation notes INSTALL.alpha

2020-04-27 Thread Sebastian Benoit
Hi, there have been no floppy images since the 6.2 release. This removes mention of boot floppies from the INSTALL.alpha notes. Maybe someone who knows something about alpha machines can do a check? comments or oks? diff --git distrib/notes/alpha/contents distrib/notes/alpha/contents index

Re: Make Rockchip RK3399 eMMC faster

2020-04-24 Thread Sebastian Benoit
Mark Kettenis(mark.kette...@xs4all.nl) on 2020.04.23 22:56:17 +0200: > I put this in at some point since I couldn't get the eMMC on my > firefly-rk3399 working otherwise. But its eMMC died and on my > rockpro64 and rk3399-q7 boards things work very well without it. On > the latter board it even

Re: bgpd local-address improvement

2020-04-23 Thread Sebastian Benoit
reads ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.04.23 10:04:15 +0200: > local-address is one of those values that need to be set in some cases but > is not very flexible to use. This diff tries to change this a bit. > > It allows to set the local-address for both IPv4 and IPv6 at the

Re: acme-client(1) and Buypass Go SSL

2020-04-21 Thread Sebastian Benoit
Bartosz Kuzma(bartosz.ku...@release11.com) on 2020.04.21 20:59:54 +0200: > Hello, > > thanks for looking at this! > > On 21/04/2020 17:43, Florian Obser wrote: > >Hi, > > > >thanks for working on this and finding another acme implementor! > > > >On Mon, Apr 20, 2020 at 06:51:17PM +0200, Bartosz

Re: acme-client(1) and Buypass Go SSL

2020-04-21 Thread Sebastian Benoit
Bartosz Kuzma(bartosz.ku...@release11.com) on 2020.04.20 18:51:17 +0200: > Hello, > > I've tried to get a certificate from Buypass Go SSL provider using > acme-client(1) but it ends with the following error: > > acme-client: https://api.buypass.com/acme-v02/new-acct: bad HTTP: 400 > acme-client:

Re: unwind(8): recommend supersede in dhclient.conf

2020-04-21 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2020.04.21 06:57:49 +0200: > We didn't get around to run unwind per default and integrate it > tighter with dhclient this release cycle. > But there is also no need anymore to recomend prepend in > dhclient.conf, unwind(8) is no longer closing it's service

rpki-client 6.6p2 (portable) has been released

2020-04-19 Thread Sebastian Benoit
routing stacks. See RFC 6811 for a description of how BGP Prefix Origin Validation secures the Internet's global routing system. rpki-client was primarily developed by Kristaps Dzonsons, Claudio Jeker, Job Snijders, and Sebastian Benoit as part of the OpenBSD Project and gets released as a base

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Sebastian Benoit
Edd Barrett(e...@theunixzoo.co.uk) on 2020.04.13 15:47:03 +0100: > Hi, > > One thing I miss from our top(1) is the ability to see overall CPU > utilisation at a glance (I usually scan for the idle percentage and > invert it in my head). > > This diff adds a way to toggle (using `B`) CPU

Re: slaacd(8): honour rdomain we are running in

2020-04-12 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2020.04.12 19:53:23 +0200: > OK? yes, this is probably better than having it configurable via option. > diff --git slaacd.c slaacd.c > index 58f15bcda37..dae2eab3434 100644 > --- slaacd.c > +++ slaacd.c > @@ -755,7 +755,7 @@ configure_gateway(struct

Re: rpki-client and non-existing files

2020-04-01 Thread Sebastian Benoit
ok you remove the "if (verbose > 0)" in the cms_parse_validate() case on purpose? Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.04.01 16:33:44 +0200: > On Wed, Apr 01, 2020 at 01:06:21PM +0200, Claudio Jeker wrote: > > Currently rpki-client logs missing files like this: > > > > rpki-client:

Re: bgpctl code reshuffle

2020-03-19 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.03.19 18:42:28 +0100: > Move some more output functions to output.c and convert some other > functions to a fmt_xyz() function that returns a string with the value > instead of doing a printf(). This is mostly mechanical but please test. > ok > --

Re: regress: bgpd: config: Fix attribute ordering

2020-03-06 Thread Sebastian Benoit
I dont see that here. Sure that you have an up-to-date tree? And no diff in there? Klemens Nanni(k...@openbsd.org) on 2020.03.05 23:39:20 +0100: > > I ran bgpd to test diffs and stumbled across what looks like simple > disorder in the config checks. > > bgpd must have changed in how it orders

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100: > On Fri, 06 Mar 2020, Job Snijders wrote: > > I believe Robert is referring to this snippet of code: > > > > > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch Thanks for the patch. I

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Job Snijders(j...@openbsd.org) on 2020.03.06 17:31:13 +: > I have a small suggestion, in some deployments I saw the convention to > name it as following so it is clear the data came from user provided > data rather than internal bird structures > > I tested Benno's patch against BIRD 1.6.6 -

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Hi, generate 3 different outputs for BIRD: - bird v1 with IPv4 routes - bird v1 with IPv6 routes - bird v2 when using command line option -B. BIRD v2 output from Robert Scheck, robert AT fedoraproject DOT org Note that I haven't tried this with bird 1 or 2 yet ;) comments, oks?

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100: > On Fri, 06 Mar 2020, Job Snijders wrote: > > I believe Robert is referring to this snippet of code: > > > > > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch > > Exactly. Ah, i

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Robert Scheck(rob...@fedoraproject.org) on 2020.03.03 01:20:24 +0100: > Hi, > > job@ suggested to move this from GitHub to tech@ list (as upstream): > > 1. Currently, BIRD 1.x support in rpki-client seems to be broken: As per >BIRD upstream the "combined format" produced by rpki-client can't

Re: minor bgpd cleanup

2020-02-14 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.02.14 14:06:37 +0100: > Move and rename copy_filterset to rde_filter.c as filterset_copy. > This way it matches the other filterset_* functions. > > OK? > -- > :wq Claudio > > Index: bgpd.h >

Re: mg: fix problems found by gcc 10

2020-02-09 Thread Sebastian Benoit
read ok Florian Obser(flor...@openbsd.org) on 2020.02.09 10:46:34 +0100: > Anyone? I'll commit this soon if I don't hear back, I don't think this > is contentious. > > On Fri, Feb 07, 2020 at 03:59:50PM +0100, Florian Obser wrote: > > Moving from misc to tech. > > > > This is effectively

Re: mention /etc/examples/ in bgpf.conf(5)/bgpd(8)

2020-02-08 Thread Sebastian Benoit
Ingo Schwarze(schwa...@usta.de) on 2020.02.09 00:33:06 +0100: > Hi, > > Jason McIntyre wrote on Sat, Feb 08, 2020 at 10:15:08PM +: > > > - i'm ok with adding the path to these files to a FILES section > > So, here is a specific patch for bgpf.conf(5) and bgpd(8) such > that we can agree on

Re: httpd(8): patch to allow FastCGI chroots in sub-directories

2020-02-08 Thread Sebastian Benoit
ok Florian Obser(flor...@openbsd.org) on 2020.02.07 16:49:08 +0100: > Slightly tweaked diff by me, fixing "new sentence new line" in the man > page. > > This is OK florian@ if someone wants to commit it or I can commit it > if someone OKs it. > > diff --git httpd.conf.5 httpd.conf.5 > index

Re: Teach du(1) the -m flag, disk usage in megabytes

2020-01-29 Thread Sebastian Benoit
Lauri Tirkkonen(la...@hacktheplanet.fi) on 2020.01.29 01:31:56 +0200: > On Tue, Jan 28 2020 18:03:19 +0100, Florian Obser wrote: > > On Tue, Jan 28, 2020 at 09:58:40AM -0700, Todd C. Miller wrote: > > > On Mon, 27 Jan 2020 18:29:39 -0500, Daniel Jakots wrote: > > > > > > > Can't you achieve what

Re: usr.sbin/snmpd: use TAILQ_CONCAT(3)

2020-01-27 Thread Sebastian Benoit
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:53:52 +0100: > Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3). > > Comments/OK? reads ok benno@ > diff --git usr.sbin/snmpd/control.c usr.sbin/snmpd/control.c > index 54b58bbb7b6..dda18c1bad5 100644 > ---

Re: sbin/unwind: use TAILQ_CONCAT(3)

2020-01-27 Thread Sebastian Benoit
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:52:36 +0100: > Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3). > > Comments/OK? reads ok benno@ > diff --git sbin/unwind/frontend.c sbin/unwind/frontend.c > index b64036c4332..d2b69084db7 100644 > ---

Re: usr.sbin/bgpd: use TAILQ_CONCAT(3)

2020-01-27 Thread Sebastian Benoit
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:53:06 +0100: > Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3). > > Comments/OK? ok benno@ > diff --git usr.sbin/bgpd/config.c usr.sbin/bgpd/config.c > index cb43afb81fe..fc81a3efd3b 100644 > --- usr.sbin/bgpd/config.c >

Re: Teach du(1) the -m flag, disk usage in megabytes

2020-01-27 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2020.01.27 19:57:41 +0100: > On Mon, Jan 27, 2020 at 10:33:49AM -0700, Todd C. Miller wrote: > > On Mon, 27 Jan 2020 10:05:41 +1100, Jonathan Gray wrote: > > > > > On Sun, Jan 26, 2020 at 11:59:33AM -0500, David Goerger wrote: > > > > This diff teaches du(1)

Re: Teach du(1) the -m flag, disk usage in megabytes

2020-01-26 Thread Sebastian Benoit
Maybe the manpage text could be better, but i'll leave that to jmc@ ok benno@ David Goerger(da...@goerger.info) on 2020.01.26 11:59:33 -0500: > This diff teaches du(1) the -m flag, report disk usage in megabytes. > This brings us in line with implementations in the other BSDs, Linux, > and

Re: ospf6d: simplify lsa_snap()

2020-01-23 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2020.01.22 06:49:53 +0100: > On Wed, Jan 22, 2020 at 12:56:00AM +0100, Claudio Jeker wrote: > > On Tue, Jan 21, 2020 at 03:58:58PM +0100, Remi Locherer wrote: > > > On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote: > > > > On Tue, Jan 21, 2020

Re: carp: send only IPv4 carp packets on dual stack interface

2020-01-18 Thread Sebastian Benoit
chr...@openbsd.org(chr...@openbsd.org) on 2020.01.18 06:18:21 +0100: > On Wed, Jan 15, 2020 at 12:47:28PM +0100, Sebastian Benoit wrote: > >Christopher Zimmermann(chr...@openbsd.org) on 2020.01.15 11:55:43 +0100: > >>Hi, > >> > >>as far as I can see a dua

Re: carp: send only IPv4 carp packets on dual stack interface

2020-01-15 Thread Sebastian Benoit
Christopher Zimmermann(chr...@openbsd.org) on 2020.01.15 11:55:43 +0100: > Hi, > > as far as I can see a dual stack carp interface does not care whether it > receives advertisements addressed to IPv4 or IPv6. Any one will do. > So I propose to send IPv6 advertisements only when IPv4 is not

Re: in httpd, use the correct configured server config

2020-01-14 Thread Sebastian Benoit
Thanks for the diff, commited. Sebastian Benoit(be...@openbsd.org) on 2020.01.14 21:14:44 +0100: > seems sensible. > > ok benno@ > > > Tracey Emery(tra...@traceyemery.net) on 2020.01.14 13:08:03 -0700: > > Hello, > > > > In the server_response

Re: in httpd, use the correct configured server config

2020-01-14 Thread Sebastian Benoit
seems sensible. ok benno@ Tracey Emery(tra...@traceyemery.net) on 2020.01.14 13:08:03 -0700: > Hello, > > In the server_response function of httpd, the if comparison to > srv_conf->maxrequests is using the wrong value. The value is derived from the > first server configuration in httpd.conf,

Re: iked(8): get rid of IPv6 flow and -6 flag?

2020-01-14 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2020.01.13 18:19:31 +0100: > On Mon, Jan 13, 2020 at 05:55:06PM +0100, Tobias Heider wrote: > > I think we should discuss whether we can remove the flow > > (and the -6 flag) as I constantly hear people complaining > > that it broke their setups and I

Re: ospf(6)d.conf: define interface parameters per area or globally

2020-01-12 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2020.01.12 12:03:40 -0700: > Remi Locherer wrote: > > > On Sun, Jan 12, 2020 at 04:18:26PM +0100, Claudio Jeker wrote: > > > On Sun, Jan 12, 2020 at 03:46:15PM +0100, Remi Locherer wrote: > > > > On Wed, Jan 08, 2020 at 01:13:45PM +0100, Denis Fondras wrote:

Re: small bgpd performance improvement

2020-01-09 Thread Sebastian Benoit
nice, ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 16:25:58 +0100: > The path_hash function is called reasonably often. Calling > SipHash24_Update() over and over for small data is not optimal. > Inspired by /sys/sys/proc.h add a aspath_hashstart and aspath_hashend to > the struct

Re: bgpd sofreconfigure and export default

2020-01-09 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 16:05:06 +0100: > When using 'export default-route' you still need an output filter to allow > the default route out. I'm probably not the only one forgetting this fact > from time to time. Now to make things worse adding the filter rule to >

Re: bgpd, move peer related functions to rde_peer.c

2020-01-09 Thread Sebastian Benoit
ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2020.01.09 13:03:13 +0100: > On Thu, Jan 09, 2020 at 09:42:39AM +0100, Claudio Jeker wrote: > > This diff just moves some of the code from rde.c to rde_peer.c where it > > should be. Apart from moving the code peer_down() was modified so that it > >

Re: snmpd(8): filter pf table addresses

2020-01-02 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.31 11:44:07 +0100: > On Tue, Dec 31, 2019 at 11:16:37AM +0100, Martijn van Duren wrote: > > I'm on the fence about this. So if you feel strongly about this go > > ahead if it works. > > In some regard I agree but in this case I think it makes

Re: bgpd, fairer imsg processing

2019-12-31 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.30 18:35:28 +0100: > The imsg processing in the RDE is sometimes a bit unfair. The problem is > that peers sending many UPDATES starve out the others especially on > intial table dumps. This comes from the fact that imsg are processed to >

Re: LIST_FOREACH_SAFE macro for mnt_vnodelist

2019-12-25 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.12.24 23:11:12 +0100: > Hi, > > Use FOREACH macro for mnt_vnodelist. > > ok? ok benno@ > > bluhm > > Index: nfs/nfs_subs.c > === > RCS file:

Re: ospf6d: rename & move function

2019-12-22 Thread Sebastian Benoit
Denis Fondras(open...@ledeuns.net) on 2019.12.22 10:55:39 +0100: > Rename and move calc_nexthop_clear()/calc_nexthop_add() to > vertex_nexthop_clear()/vertex_nexthop_add() > > It brings ospf6d closer to ospfd. ok > > > Index: rde.h >

Re: bgpctl: split out show functions into own file

2019-12-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.20 08:24:34 +0100: > This diff just moves most show related functions into a new file. > It is mostly mechanical (remove function from bgpctl.c and add it to > output.c). > > OK? ok did you check that bgplg etc still build (i dont see why they

Re: ospf6d: rework priority handling

2019-12-15 Thread Sebastian Benoit
reads ok. unrelated to this diff: I wonder if the manpage (of both ospfd and pspf6d) should mention that changing fib-priority with a reload is equivalent toa uncouple/couple? Denis Fondras(open...@ledeuns.net) on 2019.12.15 09:56:15 +0100: > > Index: kroute.c >

Re: ripd: memory leak and double free/use-after-free

2019-12-11 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2019.12.10 22:39:32 +0100: > On Tue, Dec 10, 2019 at 07:05:27PM +0100, Hiltjo Posthuma wrote: > > Hi, > > > > While looking at the code of ripd: > > > > I think there are (also) 2 small memleaks in a debug/error path > > (IMSG_REQUEST_ADD and

Re: massage tcpdump ip and encapsulation output

2019-12-06 Thread Sebastian Benoit
David Gwynne(da...@gwynne.id.au) on 2019.12.06 15:14:42 +1000: > > > > On 5 Dec 2019, at 21:14, Sebastian Benoit wrote: > > > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100: > >> I would suggest to just pack most of the headers into one

Re: Does rpki-client need to unveil(NULL, NULL)?

2019-12-05 Thread Sebastian Benoit
ok George Brown(321.geo...@gmail.com) on 2019.12.04 18:57:17 +: > After pledge is immediately called without the unveil promise so this > seems redundant. > > diff --git a/usr.sbin/rpki-client/main.c b/usr.sbin/rpki-client/main.c > index f05ec1c5837..53ee4223371 100644 > ---

Re: massage tcpdump ip and encapsulation output

2019-12-05 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.12.05 09:53:49 +0100: > I would suggest to just pack most of the headers into one group of (). > > IPv4 ttl 1 [tos 0x20] 10.0.127.15 > 10.0.127.1 > would become > IPv4 (ttl 1 tos 0x20) 10.0.127.15 > 10.0.127.1 > and > IPv4 ttl 1 [tos 0x20] (id

Re: ldomctl: Add create-vdisk command

2019-12-05 Thread Sebastian Benoit
Klemens Nanni(k...@openbsd.org) on 2019.11.30 01:44:48 +0100: > Just like on amd64 with vmctl(8), I want to be able to easily create > disk images. > > ldomctl(8) currently advises to use dd(1), those files are not sparse > either so creating big images may take a lot of time and the process >

Re: rad unveil

2019-11-26 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2019.11.26 18:46:11 +0100: > > remove include statement and unveil() rad. > > ok? diff --git usr.sbin/rad/parse.y usr.sbin/rad/parse.y index bb18c3d9c9c..443cff66065 100644 --- usr.sbin/rad/parse.y +++ usr.sbin/rad/parse.y @@ -112,7 +112,

unveil slaacd

2019-11-26 Thread Sebastian Benoit
slaacd does not have include statements open the control socket earlier, then unveil(). diff --git sbin/slaacd/slaacd.c sbin/slaacd/slaacd.c index 9c3f64f407d..990614df734 100644 --- sbin/slaacd/slaacd.c +++ sbin/slaacd/slaacd.c @@ -179,6 +179,16 @@ main(int argc, char *argv[]) if

rad unveil

2019-11-26 Thread Sebastian Benoit
remove include statement and unveil() rad. ok? diff --git usr.sbin/rad/parse.y usr.sbin/rad/parse.y index bb18c3d9c9c..443cff66065 100644 --- usr.sbin/rad/parse.y +++ usr.sbin/rad/parse.y @@ -112,7 +112,7 @@ typedef struct { %} -%token RA_IFACE YES NO INCLUDE ERROR +%token RA_IFACE YES NO

Re: ifconfig inet6 netmask

2019-11-18 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.11.18 16:31:05 +0100: > On Thu, Nov 14, 2019 at 11:14:45PM +0100, Sebastian Benoit wrote: > > The alternative is to not allow netmask for ipv6 and only / and > > prefixlen > > . Why support such a crazy way of specifying the m

Re: ifconfig inet6 netmask

2019-11-14 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.11.14 22:50:50 +0100: > Hi, > > While writing my ifconfig regress test I realized that IPv6 netmasks > are parsed, but silently ignored. Ignoring commandline parameters > feels wrong and is inconsistent to IPv4. > > Of course I don't expect

Re: ospfd: correct function name in error message

2019-11-09 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.11.09 15:32:39 +0100: > On Sat, Nov 09, 2019 at 03:27:31PM +0100, Denis Fondras wrote: > > Fix function name in error message. > > > > Index: kroute.c > > === > > RCS file:

Re: mg(1) tell make-backup-files is on by default

2019-11-08 Thread Sebastian Benoit
Solene Rapenne(sol...@perso.pw) on 2019.11.08 18:39:20 +0100: > Someone on reddit had issue with this config file, there was no backup > file, in file directory or in ~/.mg.d > > make-backup-files > backup-to-home-directory > > in fact, having "make-backup-files" disables backups. > > > I've

Re: upgrade66.html missing acme-client.conf staging api url change

2019-11-08 Thread Sebastian Benoit
Solene Rapenne(sol...@perso.pw) on 2019.11.08 18:13:40 +0100: > The staging api changed too. I know people who did not update that url, > it's not especially obvious because the old url doesn't contain v01. > > ok ? Nice! I actually wondered about that and my google foo was too low. Thanks for

Re: fix acme manpage link in faq/upgrade66.html

2019-10-24 Thread Sebastian Benoit
Andras Farkas(deepbluemist...@gmail.com) on 2019.10.24 13:58:26 -0400: > Diff attached, changes bad link: > https://man.openbsd.org/OpenBSD-6.6/acme-client.5 > to > https://man.openbsd.org/OpenBSD-6.6/acme-client.conf.5 > on this page: > https://www.openbsd.org/faq/upgrade66.html > fixed, thanks

Re: Keydisk encryption (sr_crypto_create_keys / sr_crypto_decrypt_key)

2019-10-24 Thread Sebastian Benoit
List(l...@md5collisions.eu) on 2019.10.24 21:06:27 +0200: > Hi, > > in function sr_crypto_create_keys (sys/dev/softraid_crypto.c, 489): > > The keydisk is masked by encrypting(1) a generated random buffer. > > This encrypted random buffer (keydisk) is afterwards used to encrypt(2) > the

Re: bgpctl(8) shutdown communication

2019-10-20 Thread Sebastian Benoit
Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2019.10.19 16:01:45 +0200: > On Sat, Oct 19 2019, "Theo de Raadt" wrote: > > Jeremie Courreges-Anglas wrote: > > > >> On Sat, Oct 19 2019, Claudio Jeker wrote: > >> > bgpd supports up to 255 byte shutdown communications. So the manpage is > >> > not

Re: bgpctl(8) shutdown communication

2019-10-20 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.10.19 11:07:28 +0200: > bgpd supports up to 255 byte shutdown communications. So the manpage is > not telling the truth. Also I don't think it is helpful to mention the > limit at all. bgpctl will exit with 'shutdown reason too long' if the text > is

Re: ifconfig compiler warnings

2019-10-18 Thread Sebastian Benoit
Alexander Bluhm(alexander.bl...@gmx.net) on 2019.10.17 16:23:32 +0200: > Hi, > > I would like to fix some warings in ifconfig when compiled with > WARNINGS=yes. > > - Move all prototypes and variables used in multiple .c files into > common ifconfig.h. Basically rename brconfig.h to

fix $OpenBSD$ tag in sysupgrade/Makefile

2019-10-01 Thread Sebastian Benoit
ok? Index: Makefile === RCS file: /cvs/src/usr.sbin/sysupgrade/Makefile,v retrieving revision 1.1 diff -u -p -r1.1 Makefile --- Makefile25 Apr 2019 20:22:52 - 1.1 +++ Makefile1 Oct 2019 21:17:23 - @@ -1,4 +1,4 @@

Re: bgpd tcp md5sum changes for portable

2019-10-01 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2019.10.01 11:20:33 +0200: > OK, this diff is actually what linux is going to need to be able to > configure TCP MD5SUM on sockets. The listening socket turned out to be a > bit more tricky since the MD5 key for each peer needs to be added to the > socket

  1   2   3   4   5   6   >