[PATCH] iked: Incorrect definition of critical bit (IKEV2_CRITICAL_PAYLOAD)

2017-06-21 Thread Thomas Klute
Hi tech@, I noticed that the definition of IKEV2_CRITICAL_PAYLOAD in ikev2.h is incorrect. According to RFC 7296, Section 3.2 the critical bit is the first/high bit of the second octet of the IKE payload header. An octet with only its first bit set results in a hex value of 0x80, not 0x01. IKEV2_

Re: [PATCH] iked: Bugfixes for IKE rekeying

2017-01-03 Thread Thomas Klute
Am 09.11.2016 um 20:36 schrieb Vincent Gross: > On Wed, 9 Nov 2016 13:16:46 + > Thomas Klute wrote: > >> Hi tech@, >> >> this patch contains fixes for two bugs that break IKE rekeying >> initiated by iked. Please review, and apply or let me know what has to &

[PATCH] iked: Bugfixes for IKE rekeying

2016-11-09 Thread Thomas Klute
Hi tech@, this patch contains fixes for two bugs that break IKE rekeying initiated by iked. Please review, and apply or let me know what has to be changed! Both bugs are fixed by initializing the respective structures of the new IKE SA (struct iked_sa *nsa in the ikev2_ike_sa_rekey function): For

[PATCH] iked: Preserve address information during rekeying

2016-11-08 Thread Thomas Klute
Hi tech@, a week ago I reported to bugs@ that iked "forgets" the local and peer addresses associated with an IKE SA while rekeying it if iked has initiated the rekeying, breaking any IKE requests iked tries to send after rekeying [1]. The patch below fixes the bug by copying the addresses from