libevent: endless loop on excessively large buffers

2019-05-02 Thread Tobias Stöckmann
It is possible to trigger an endless loop or out of boundary write on 64 bit systems with evbuffer_readline calls for buffers which exceed 4 GB (i.e. overflow uint). for (i = 0; i < len; i++) Variable i is unsigned int and len size_t. This leads to an endless loop if len is larger than

Re: unify xmalloc (was Re: [patch] cvs: retire xfree())

2015-11-09 Thread Tobias Stöckmann
> On November 9, 2015 at 5:04 AM Michael McConville wrote: > Tobias, could you split your latest diff into separate diffs for each > function type (xmalloc, xcalloc, etc.)? It'd make it easier to zero in > on the problematic hunks and fast-track the rest. I don't really see

Re: catopen/catgets: out of boundary access

2015-10-06 Thread Tobias Stöckmann
> On October 6, 2015 at 11:40 AM Stefan Sperling wrote: > What do you think about a similar treatment for locale/rune.c? I think you refer to _Read_RuneMagi function, which lacks the same input validation. Before supplying a patch for that one, I wanted to get some feedback for

Re: qsort.3 big O notation

2015-03-03 Thread Tobias Stöckmann
On March 3, 2015 at 5:48 PM frantisek holop min...@obiit.org wrote: If anything, it should be log because that is the name of the mathematical function. libm is completely irrelevant in this context. 'lg' is also a valid name When talking about big O notation, you want to trim as many