Re: awk FS behaviour change

2020-06-27 Thread patrick keshishian
On Sat, Jun 27, 2020 at 06:50:39AM +0100, Jason McIntyre wrote: > On Fri, Jun 26, 2020 at 09:28:00PM -0600, Todd C. Miller wrote: > > On Fri, 26 Jun 2020 23:56:23 +0200, Klemens Nanni wrote: > > > > > How about adding something like "Therefore, FS should be set with -F or > > > in a BEGIN block

Re: ipmi(4): don't block interrupts/systq long time

2019-06-07 Thread patrick keshishian
On Fri, Jun 07, 2019 at 07:29:19PM +0900, Naoki Fukaumi wrote: > hi tech@, > > here is another patch for another issue for ipmi(4). > > ipmi_sendcmd() and ipmi_recvcmd() are always called in order/pairs as a > single task of a single-threaded taskq, remove mutex from there. this > avoids

Re: sed(1) make -i behave a little nicer

2018-12-07 Thread patrick keshishian
On Fri, Dec 07, 2018 at 08:41:21AM +0100, Martijn van Duren wrote: > I ran into a few minor nuisances with sed's -i mode, which are mostly > compatible with gnu sed, but I reckon we should address. > > The problem is sed works by writing the output to a second file in the > same directory as the

Re: mktemp: Clarify error message

2017-12-25 Thread patrick keshishian
On 12/25/17, Otto Moerbeek wrote: > On Tue, Dec 26, 2017 at 12:31:02AM +0100, Klemens Nanni wrote: > >> On Mon, Dec 25, 2017 at 03:57:00PM -0700, Theo de Raadt wrote: >> > I think this is a silly solution, and the documentation is clear >> > enough. >> The manual page certainly is

Re: enum unsigned or not?

2017-08-31 Thread patrick keshishian
On Thu, Aug 31, 2017 at 12:13:19PM -0700, William Ahern wrote: > On Thu, Aug 31, 2017 at 02:08:07PM +0200, Otto Moerbeek wrote: > > Hi, > > > > /usr/src/usr.sbin/sasyncd/carp.c:157:12: warning: comparison of > > unsigned enum expression < 0 is always false [-Wtautological-compare] > > if

Re: [PATCH] rm(1): add -v option for verbosity

2017-06-25 Thread patrick keshishian
On Sun, Jun 25, 2017 at 11:16:00PM +0200, Ingo Schwarze wrote: > Hi, > > Paul de Weerd wrote on Sun, Jun 25, 2017 at 10:46:15PM +0200: > > On Sun, Jun 25, 2017 at 03:12:26PM +0200, Ingo Schwarze wrote: > > > | If you are really unsure, study the output of > > | $ find * > > | first, before

Re: detect post threaded condition

2017-05-30 Thread patrick keshishian
On Tue, May 30, 2017 at 03:48:06AM -0400, Ted Unangst wrote: > talking to stsp, he reminded me of a problematic bug that took some time to > track down in some desktop software that shall not be named. after a program > calls fork(), the child has only a single thread. per the standard, it needs >

Re: ulpt read interface

2017-05-25 Thread patrick keshishian
Ping? On Thu, May 18, 2017 at 07:35:31PM -0700, patrick keshishian wrote: > Hello, > > I would like to propose adding a ulptread call to the ulpt(4). > > This diff adds ulptread and ulpt_do_read functions, similar to > ultpwrite and ulpt_do_write (essentially copy/pa

ulpt read interface

2017-05-18 Thread patrick keshishian
Hello, I would like to propose adding a ulptread call to the ulpt(4). This diff adds ulptread and ulpt_do_read functions, similar to ultpwrite and ulpt_do_write (essentially copy/paste/edit), as well as looking at ugen_do_read (for BULK). One thing to note is the current ultp driver runs two

Re: unmount mountpoints

2017-01-11 Thread patrick keshishian
my initial attempt to send a response is not moving out of the queue...so here is a second attempt. On 1/10/17, Alexander Bluhm wrote: > Hi, > > When I force to unmount a filesystem where another mountpoint is > located, an unlinked mountpoint will remain. I have not

Re: paste-o fix in comment + load average question

2016-11-12 Thread patrick keshishian
? Cheers, --patrick On Fri, Nov 11, 2016 at 01:23:26PM -0800, patrick keshishian wrote: > Hi, > > For a long time I was running an amd64 snapshot from 2016/03/30, > then I installed a snapshot from 2016/10/09 on four machines > (two laptops, a desktop and a 1U supermicro). &g

paste-o fix in comment + load average question

2016-11-11 Thread patrick keshishian
Hi, For a long time I was running an amd64 snapshot from 2016/03/30, then I installed a snapshot from 2016/10/09 on four machines (two laptops, a desktop and a 1U supermicro). One apparent difference was that the load average on all four machines idled at slightly above 1 (1.12, 1.18, ...),

step missing from "2016/10/14" followig -current?

2016-10-28 Thread patrick keshishian
Instructions say: $ cd /sys $ rm -r arch/*/compile/[GR]* $ rm arch/*/compile/.cvsignore $ cvs up The new way of configuring, building and installing a kernel is: $ cd /sys/arch/$(machine)/compile/GENERIC.MP $ doas make obj $ make

Re: xdm halt & reboot buttons

2016-07-01 Thread patrick keshishian
On 7/1/16, Matthieu Herrb wrote: > On Fri, Jul 01, 2016 at 02:22:57PM +0100, Craig Skinner wrote: >> Hi Alexander, >> >> On 2016-06-30 Thu 20:58 PM |, Alexander Hall wrote: >> > >> > 1. xmessage has an sometimes useful, but in general awful, interface. >> >> Aye,... simple, in

Re: splraise for sparc

2016-06-14 Thread patrick keshishian
On Mon, Jun 13, 2016 at 11:29:13AM +1000, David Gwynne wrote: > this is kind of like the change i just made to sparc64. > > sparc created instances of inline functions for each of the splfoo > calls. this provides an splraise call and turns splfoo into a macro > to splraise(IPL_FOO). > > the spl

Re: utvfu driver port

2016-06-01 Thread patrick keshishian
On Wed, Jun 01, 2016 at 12:04:38PM +0200, Stefan Sperling wrote: > On Wed, Jun 01, 2016 at 01:40:14AM -0700, patrick keshishian wrote: > > Here it is... > > Thanks patrick! > > As far as I can see we don't have a man page for this driver yet. > Could you provide one?

Re: utvfu driver port

2016-06-01 Thread patrick keshishian
On Wed, Jun 01, 2016 at 12:24:43AM -0700, patrick keshishian wrote: > On Wed, Jun 01, 2016 at 08:58:21AM +0200, Marcus Glocker wrote: > > On Wed, Jun 01, 2016 at 12:51:22AM -0400, Ted Unangst wrote: > > > > > Marcus Glocker wrote: > > > > Me too. Would it be

Re: utvfu driver port

2016-06-01 Thread patrick keshishian
On Wed, Jun 01, 2016 at 08:58:21AM +0200, Marcus Glocker wrote: > On Wed, Jun 01, 2016 at 12:51:22AM -0400, Ted Unangst wrote: > > > Marcus Glocker wrote: > > > Me too. Would it be ok to merge utvfu.c and utvfu_ops.c by including > > > both Copyrights in this file? Should it be > > > > > >

Re: utvfu driver port

2016-06-01 Thread patrick keshishian
Hello, On Mon, May 30, 2016 at 04:22:56PM +0200, Martin Pieuchot wrote: > On 26/05/16(Thu) 16:09, patrick keshishian wrote: > > > > Included is my initial effort to port the dual-licensed driver > > for Fushicai Audio-Video Grabber (vendor 0x1b71 product 0x3002). > &g

Re: utvfu driver port

2016-05-27 Thread patrick keshishian
On Fri, May 27, 2016 at 08:41:33PM +0200, Marcus Glocker wrote: > Hello Patrick, > > On Thu, May 26, 2016 at 04:09:26PM -0700, patrick keshishian wrote: > > > Hi, > > > > Included is my initial effort to port the dual-licensed driver > > for Fushicai Audio-

Re: uvideo patches: Overview [0/4]

2016-05-26 Thread patrick keshishian
On Thu, May 26, 2016 at 10:55:47PM +0200, Marcus Glocker wrote: > On Tue, May 17, 2016 at 05:15:51PM -0700, patrick keshishian wrote: > > > Greetings, > > > > I have been looking at uvideo trying to model a new driver I'm > > attempting to port over and found a

utvfu driver port

2016-05-26 Thread patrick keshishian
Hi, Included is my initial effort to port the dual-licensed driver for Fushicai Audio-Video Grabber (vendor 0x1b71 product 0x3002). As I mentioned in previous email it is "mostly working". I have tested it on amd64 and macppc. The macppc audio issue mentioned got resolved thanks to a hint from

Re: usbtv driver port (questions)

2016-05-25 Thread patrick keshishian
On Wed, May 25, 2016 at 01:57:36PM +0200, Marcus Glocker wrote: > On Tue, May 24, 2016 at 04:46:57PM -0700, patrick keshishian wrote: > > > Hi, > > > > I have a "mostly working" driver port for Fushicai Audio-Video > > Grabber (vendor 0x1b71 product

Re: usbtv driver port (questions)

2016-05-25 Thread patrick keshishian
On Wed, May 25, 2016 at 08:45:29AM -0400, Ian Darwin wrote: > On 2016-05-25 7:57 AM, Marcus Glocker wrote: > >On Tue, May 24, 2016 at 04:46:57PM -0700, patrick keshishian wrote: > > > >>Hi, > >> > >>I have a "mostly working" driver port for Fus

usbtv driver port (questions)

2016-05-24 Thread patrick keshishian
Hi, I have a "mostly working" driver port for Fushicai Audio-Video Grabber (vendor 0x1b71 product 0x3002). I've had the video bit working for a few days on amd64 and macppc. I finally managed to get the audio bit working this morning on amd64, but still an encoding issue (LE vs BE) on macppc.

uvideo patches: V4L2_BUF_FLAG_{DONE,QUEUED} [4/4]

2016-05-17 Thread patrick keshishian
4/4: I don't believe V4L2_BUF_FLAG_QUEUED and V4L2_BUF_FLAG_DONE flags are handled correctly in our uvideo driver. According to linuxtv.org Buffers Chap 3. Input/Output Table 3.4 Buffer Flags:

uvideo patches: endpoint address vs index 0 [2/4]

2016-05-17 Thread patrick keshishian
2/4: Assumption on endpoint index to use in uvideo_vs_open() vs actual saved endpoint address. Index: uvideo.c === RCS file: /cvs/obsd/src/sys/dev/usb/uvideo.c,v retrieving revision 1.185 diff -u -p -u -p -r1.185 uvideo.c ---

uvideo patches: Alternate Setting [3/4]

2016-05-17 Thread patrick keshishian
3/4: In uvideo_vs_set_alt(), according to the comment within while()-loop searches for an endpoint with requested bandwidth, or best match. An iterator index (int i) is used in the while()-loop, and eventually its value is used in usbd_set_interface(). Is the "matched"

uvideo patches: Overview [0/4]

2016-05-17 Thread patrick keshishian
Greetings, I have been looking at uvideo trying to model a new driver I'm attempting to port over and found a few issues (or what I precive as issues). Since the list likes separate diffs for easier discussion, Here is my attempt to break them up in four emails. I think, with exception of one,

Re: [patch] theo.c [was: TLS now supported on openbsd.org?]

2016-05-09 Thread patrick keshishian
ong and you need to take > that back. You wanna complain about me, great. bring it. But cut someone a > break who is trying to do the right thing on both sides. > > On Monday, 9 May 2016, patrick keshishian <pkesh...@gmail.com> wrote: > >> i

[patch] theo.c [was: TLS now supported on openbsd.org?]

2016-05-09 Thread patrick keshishian
if I didn't, someone else would. Index: theo.c === RCS file: /cvs/src/usr.bin/mg/theo.c,v retrieving revision 1.150 diff -u -p -u -p -r1.150 theo.c --- theo.c 23 Dec 2015 19:37:34 - 1.150 +++ theo.c 10 May 2016

Re: synaptics: two-finger scrolling and coasting

2016-04-21 Thread patrick keshishian
fwiw, I've been running this on my lenovo x120e for a the week. --patrick On 4/21/16, Ulf Brosziewski wrote: > Ping? > > It isn't a severe bug and it doesn't concern a spectacular feature, > but shouldn't we fix it? > > > On 04/16/2016 06:01 PM, Ulf Brosziewski

Re: Allow top(1) to search arguments

2016-02-10 Thread patrick keshishian
On Wed, Feb 10, 2016 at 11:04:18PM +, Edd Barrett wrote: > Hey, > > I'd like top(1)'s filter feature (-g) to search process arguments. This > would make searching for (e.g.) Python scripts by name much easier. The > current behaviour only searches the program name, which for scripts is > the

Re: libc: getusershell, new implementation

2015-12-05 Thread patrick keshishian
On Sat, Dec 05, 2015 at 01:25:10PM -0500, Ted Unangst wrote: > Tobias Stoeckmann wrote: > > > > And I still think that the current code is a bit too permissive in parsing > > things. I mean what's the point in allowing lines like: > > > > sometextwithoutspace/bin/ksh should be used for logins #

Re: kern_tame.c: fix strncmp call

2015-08-23 Thread patrick keshishian
On 8/23/15, Caspar Schutijser cas...@schutijser.com wrote: Patch below. Thanks, Caspar Schutijser Index: sys/kern/kern_tame.c === RCS file: /cvs/src/sys/kern/kern_tame.c,v retrieving revision 1.25 diff -u -p -r1.25

Re: kern_tame.c: fix strncmp call

2015-08-23 Thread patrick keshishian
Apologies, my eyes failed me on this. On 8/23/15, patrick keshishian pkesh...@gmail.com wrote: On 8/23/15, Caspar Schutijser cas...@schutijser.com wrote: Patch below. Thanks, Caspar Schutijser Index: sys/kern/kern_tame.c

Re: [patch] vi: fix file modified more recently than this copy ... error

2015-07-07 Thread patrick keshishian
ping? On 6/9/15, patrick keshishian sids...@boxsoft.com wrote: Hi, Noticed a regression with vi and recent changes to timespec data types. To reproduce, run vi without a file name to edit. Try save buffer via :w and you'll be presented by following message: file modified more recently

Re: [patch] vi: fix file modified more recently than this copy ... error

2015-07-07 Thread patrick keshishian
On 7/7/15, Todd C. Miller todd.mil...@courtesan.com wrote: I prefer this diff instead. Thanks. I too like this better. --patrick - todd Index: usr.bin/vi/common/exf.c === RCS file: /cvs/src/usr.bin/vi/common/exf.c,v

Re: PATCH: faq4.html edit the auto layout

2015-06-29 Thread patrick keshishian
Hi, On 6/29/15, Juan Francisco Cantero Hurtado i...@juanfra.info wrote: It's surprising but many users don't know the R option. OK? The webpage with the patch applied: http://juanfra684.devio.us/tmp/faq4.html#InstDisks diff --git faq/faq4.html faq/faq4.html index 51606b3..f2b9486 100644

Re: systrace patch for chflagsat

2015-06-16 Thread patrick keshishian
Hi, On Sat, Jun 13, 2015 at 09:41:58PM -0700, Philip Guenther wrote: On Thu, 4 Jun 2015, patrick keshishian wrote: With the cp(1) change to use chflagsat(), systrace needs to be taught about chflagsat syscall. databases/db/v4 port fails with USE_SYSTRACE=Yes due to a $(CP) -pr use during

Re: clean the tree from superfluous case '?': /* FALLTHROUGH */

2015-06-09 Thread patrick keshishian
Hi, On Tue, Jun 09, 2015 at 07:46:20PM +0200, Benjamin Baier wrote: Hello tech@ delete case '?': /* FALLTHROUGH */ where it is already handled by default: usage();. Not quite sure it is correct to remove the '?' case from npppd.c, since there is no 'default' case. Also, if the idea is to

[patch] vi: fix file modified more recently than this copy ... error

2015-06-09 Thread patrick keshishian
Hi, Noticed a regression with vi and recent changes to timespec data types. To reproduce, run vi without a file name to edit. Try save buffer via :w and you'll be presented by following message: file modified more recently than this this copy; use ! to override Patch below fixes this. Hope

Re: file(1): is this reasonable?

2015-06-04 Thread patrick keshishian
On Thu, Jun 04, 2015 at 12:46:14PM -0600, Theo de Raadt wrote: Trying to get file to work under systrace(1). Is this a reasonable patch? Semi-reasonable. I think if the ioctl fails, it should be entirely silent. file(1) still fails with systrace because of sendmsg(2), any help

Re: file(1): is this reasonable?

2015-06-04 Thread patrick keshishian
suggestion was to solve this issue with systrace(1)-ed file(1) invocation. Or did I miss something? --patrick On Thu, Jun 04, 2015 at 02:09:43PM -0700, patrick keshishian wrote: On Thu, Jun 04, 2015 at 12:46:14PM -0600, Theo de Raadt wrote: Trying to get file to work under systrace(1

Re: file(1): is this reasonable?

2015-06-04 Thread patrick keshishian
On Thu, Jun 04, 2015 at 11:06:38PM +0100, Nicholas Marriott wrote: /usr/ports/infrastructure/db/systrace.filter has these: native-recvmsg: permit native-sendmsg: sockaddr match /tmp then permit native-sendmsg: sockaddr match /var/tmp then permit native-sendmsg:

Re: file(1): is this reasonable?

2015-06-04 Thread patrick keshishian
Otherwise I think this is fine. On Thu, Jun 04, 2015 at 03:29:06PM -0700, patrick keshishian wrote: On Thu, Jun 04, 2015 at 11:06:38PM +0100, Nicholas Marriott wrote: /usr/ports/infrastructure/db/systrace.filter has these: native-recvmsg: permit native-sendmsg

file(1): is this reasonable?

2015-06-04 Thread patrick keshishian
Trying to get file to work under systrace(1). Is this a reasonable patch? According to systrace(4) ioctl(STRIOCATTACH) can fail for one of five reasons. In context of file(1), the only possible one is number 3. It's being traced already. file(1) still fails with systrace because of sendmsg(2),

systrace patch for chflagsat

2015-06-04 Thread patrick keshishian
Hi, With the cp(1) change to use chflagsat(), systrace needs to be taught about chflagsat syscall. databases/db/v4 port fails with USE_SYSTRACE=Yes due to a $(CP) -pr use during install_docs. Could someone look over these changes and correct any mistakes. I am not 100% sure it is correct;

Re: ftp(1) rewrite

2015-06-01 Thread patrick keshishian
Hi, quick comments inline. On 6/1/15, Sunil Nimmagadda su...@nimmagadda.net wrote: On Thu, May 21, 2015 at 11:16:09PM -0400, Ted Unangst wrote: Sunil Nimmagadda wrote: Hi, The idea is to start with the subset of ftp(1) functionality needed by pkg_add(1): ftp [-o output] url ...

Re: [patch 3/3] ksh: add overflow checking for memory allocations

2015-05-24 Thread patrick keshishian
On 5/24/15, Theo Buehler t...@math.ethz.ch wrote: On Sun, May 24, 2015 at 09:10:08PM +0200, Martin Natano wrote: I highly doubt any part of those three diffs is authored by yourself. (Merely renaming functions doesn't count as original work.) As pointed out before, the efficient overflow

Re: /etc/daily /tmp purge mods; skip open files with fstat test

2015-05-14 Thread patrick keshishian
On 5/14/15, Craig Skinner skin...@britvault.co.uk wrote: [...] Here's a diff of a modified /etc/daily /tmp purge portion: o replace test(1) '-L' with '-h' due to: -L ... Do not rely on its existence; use -h instead Interesting that FreeBSD[1] and MacOS X say the opposite. SUSv4 (one I

Re: [patch] rtl8188eu support for urtwn(4)

2015-04-26 Thread patrick keshishian
On 4/26/15, Mikhail mp39...@gmail.com wrote: On 21:22 26-Apr 2015 Mikhail wrote: On 20:20 26-Apr 2015 Stefan Sperling wrote: On Sun, Apr 26, 2015 at 01:31:17PM +0200, Stefan Sperling wrote: On Sun, Apr 19, 2015 at 11:48:32PM +0300, Mikhail wrote: Bellow new version of the patch with

Re: Do you need/prefer the non-DUID option in the installer?

2015-03-15 Thread patrick keshishian
On Sun, Mar 15, 2015 at 11:24:32AM -0400, Kenneth Westerback wrote: Using DUIDs in the installed /etc/fstab has been the default for some time now. We'd like to eliminate the question in the installer and just use DUIDs unconditionally. But first we need to know you are aware of any

Re: Do you need/prefer the non-DUID option in the installer?

2015-03-15 Thread patrick keshishian
On 3/15/15, Michael W. Lucas mwlu...@michaelwlucas.com wrote: On Sun, Mar 15, 2015 at 01:06:37PM -0600, Theo de Raadt wrote: Look, if people keep being unspecific on how DUIDs interfere with their usage patterns, then the non-DUID configuration mode is going to go away. WHY must be use the

[patch] xdm doesn't clear wtmp/utmp entry after log out

2015-01-13 Thread patrick keshishian
Hi, I've noticed this issue for sometime now. I was hoping one of the Xorg updates would fix it, so finally I decided to read some man pages, specifically sessreg. Evidently the Xservers path is not correct (or has changed) in OBSD's install. No longer found at:

Re: chmod: range checks

2014-12-12 Thread patrick keshishian
On Fri, Dec 12, 2014 at 10:45:04AM -0700, Todd C. Miller wrote: On Fri, 12 Dec 2014 18:16:35 +0100, Tobias Stoeckmann wrote: chmod doesn't check if the program name is at least 3 characters long before checking its index 2. OK. Just throwing this out there: will this program ever get

Re: Violating randomization standards

2014-12-08 Thread patrick keshishian
Hello, Small comment below. On Mon, Dec 08, 2014 at 01:55:47PM -0700, Theo de Raadt wrote: I have spent the last week researching all the uses of the srand(), srandom(), and srand48() subsystems in the ports tree. [...] RAND(3)Library Functions Manual

Re: httpd errata

2014-11-20 Thread patrick keshishian
Hi, On Thu, Nov 20, 2014 at 06:24:23PM -0500, Ted Unangst wrote: [on behalf of reyk] Many people want to test the new httpd in OpenBSD 5.6; so we decided to provide various improvements from -current for 5.6. See the description below for more details. [...] Index: usr.sbin/httpd/httpd.c

Re: tetris(6): fix select() - poll() conversion

2014-11-07 Thread patrick keshishian
On Wed, Nov 05, 2014 at 02:44:54PM -0800, patrick keshishian wrote: On Wed, Nov 05, 2014 at 08:45:07PM +0100, Theo Buehler wrote: Pausing a tetris game currently causes a segfault due to a a null pointer dereference. Fix this by checking that s is non-NULL before accessing its members

Re: tetris(6): fix select() - poll() conversion

2014-11-05 Thread patrick keshishian
On Wed, Nov 05, 2014 at 08:45:07PM +0100, Theo Buehler wrote: Pausing a tetris game currently causes a segfault due to a a null pointer dereference. Fix this by checking that s is non-NULL before accessing its members. A number of comments and an error message still refer to select()

Re: swap affinity?

2014-09-20 Thread patrick keshishian
On Sat, Sep 20, 2014 at 08:53:58AM +0200, Otto Moerbeek wrote: On Fri, Sep 19, 2014 at 10:05:35PM -0700, patrick keshishian wrote: Hi, Just ran into something strange. I was running 'sudo cdio cdrip' and in another shell running a memory-hungry perl script, this caused a bunch

swap affinity?

2014-09-19 Thread patrick keshishian
Hi, Just ran into something strange. I was running 'sudo cdio cdrip' and in another shell running a memory-hungry perl script, this caused a bunch of processes to swap out (namely Xorg). Once the cdrip was done, and I killed the perl script, and let the system calm down, I still noticed lag in

Re: autonetd, Wi-Fi automated configuration

2014-08-13 Thread patrick keshishian
Hi, Since you did ask for input. On Wed, Aug 13, 2014 at 07:06:23PM +0400, Vadim Zhukov wrote: Hello all. I won't describe the problem, you all new it: when you switch between hotspots, your network interface doesn't follow you. Also, you probably want to have some sort of fallback

Re: Print strings with double quotes safely in ifconfig(8)

2014-08-10 Thread patrick keshishian
On 8/10/14, Vadim Zhukov persg...@gmail.com wrote: This changes the way ifconfig(8) to print lines like 'crazy nwid', i.e., containing double quotes inside the data being output. At the present, such lines will be printed in the following way: crazy nwid And this makes everything that tries

Re: [PATCH]unused NULL check before calling free

2014-07-30 Thread patrick keshishian
On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote: Hi tech, there is an unnecessary NULL check before calling free. fritjof Index: xmalloc.c === RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v retrieving

Re: lsearch.c

2014-07-17 Thread patrick keshishian
On 7/17/14, Matthew Dempsky matt...@dempsky.org wrote: Hrm. It seems silly to me to change it to require a non-const pointer argument, Silly even though, the description of lsearch says it will modify (it shall be added at the end of) the table, for which base argument points to the first

Re: PATCH: further kernel malloc - mallocarray

2014-07-16 Thread patrick keshishian
Question, comment and a potential bug ... On Wed, Jul 16, 2014 at 04:54:49AM +, Doug Hogan wrote: === RCS file: /cvs/src/sys/arch/amd64/amd64/est.c,v retrieving revision 1.33 diff -u -p -d -r1.33 est.c ---

[patch] sys/dev/ic/mfi.c

2014-07-16 Thread patrick keshishian
Hi, I think is a bug in sys/dev/ic/mfi.c noticed during PATCH: further kernel malloc - mallocarray review[1] I see the mallocarray() patch seems to have been applied. Want to make sure if this is in fact a bug, that it is not overlooked. Ignore if this is noise. Cheers, --patrick [1]

Re: Probably you already know but http://www.openbsd.org/cgi-bin/cvsweb/ is returning HTTP 403 Forbidden

2014-07-16 Thread patrick keshishian
On 7/16/14, Bob Beck b...@obtuse.com wrote: I've disabled it due to persistant DOS attacks. It may come back later. wait ... what? you helping'em? :P --patrick On Wed, Jul 16, 2014 at 12:11 PM, Rafael Neves rafaelne...@gmail.com wrote: Hi Beck, Probably you already know

Re: mallocarray() in sys/dev, first pass

2014-07-13 Thread patrick keshishian
On Sun, Jul 13, 2014 at 11:29:22AM -0600, dera...@cvs.openbsd.org wrote: This is the first pass of mallocarray() in sys/dev. Please proofread. [...] === RCS file: /cvs/src/sys/dev/softraid.c,v retrieving revision 1.334 diff -u

Re: lynx: disable old protocols

2014-07-11 Thread patrick keshishian
On 7/11/14, Theo de Raadt dera...@cvs.openbsd.org wrote: If lynx was removed from base, and only available in ports... how many of you would even know of it's existance and use it? asking rhetorically? either way, yes, I would install lynx if it wasn't in base. I use it on a daily basis.

Re: cvs admin for commitids

2014-06-30 Thread patrick keshishian
On Sun, Jun 29, 2014 at 07:39:59PM -0500, joshua stein wrote: On Sun, 29 Jun 2014 at 19:37:18 -0500, joshua stein wrote: This adds a -C option to cvs's admin command which can add, change, or delete a revision's commitid. I couldn't find any similar functionality in any other CVS

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread patrick keshishian
On Wed, Jun 25, 2014 at 10:01:06PM -0700, patrick keshishian wrote: On Thu, Jun 26, 2014 at 06:37:00AM +0200, Alexander Hall wrote: On 06/25/14 20:52, Bob Beck wrote: If you or someone you love runs an anoncvs server, they need to see this. As you know we recently added commitid support

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-26 Thread patrick keshishian
On Thu, Jun 26, 2014 at 10:19:09AM +0100, Stuart Henderson wrote: On 2014/06/26 11:02, Mike Belopuhov wrote: On 26 June 2014 08:53, patrick keshishian sids...@boxsoft.com wrote: On Wed, Jun 25, 2014 at 10:01:06PM -0700, patrick keshishian wrote: On Thu, Jun 26, 2014 at 06:37:00AM +0200

simple fstab.5 diff

2014-06-26 Thread patrick keshishian
fix missing forward-slash. Index: fstab.5 === RCS file: /cvs/obsd/src/share/man/man5/fstab.5,v retrieving revision 1.48 diff -u -p -u -p -r1.48 fstab.5 --- fstab.5 6 Jan 2014 00:52:21 - 1.48 +++ fstab.5 27 Jun 2014

Re: ANONCVS MIRROR MAINTAINERS.. YOU NEED TO READ THIS!

2014-06-25 Thread patrick keshishian
On Thu, Jun 26, 2014 at 06:37:00AM +0200, Alexander Hall wrote: On 06/25/14 20:52, Bob Beck wrote: If you or someone you love runs an anoncvs server, they need to see this. As you know we recently added commitid support to cvs, and we had you update your cvsync binary. Unfortunately, the

Re: [PATCH]: Convert select() to poll() in amd/info_hes.c

2014-05-07 Thread patrick keshishian
On Wed, May 07, 2014 at 02:47:32PM +0100, Dimitris Papastamos wrote: Hi, This piece of code now uses poll() instead of select(). I have not got round to test this yet, but I will as soon as I have a working setup. Thoughts?

Re: malloc in libssl/src/apps

2014-05-04 Thread patrick keshishian
On Sun, May 04, 2014 at 02:38:40AM -0400, Jean-Philippe Ouellet wrote: Hello, I've gone through lib/libssl/src/apps with the goal of making {m,c,re}alloc uses more idiomatic, adding error checking in some places where missing, and some minor style unification. Feedback appreciated, better

Re: malloc in libssl/src/apps

2014-05-04 Thread patrick keshishian
On Sun, May 04, 2014 at 12:29:59AM -0700, Philip Guenther wrote: On Sun, May 4, 2014 at 12:21 AM, patrick keshishian sids...@boxsoft.comwrote: On Sun, May 04, 2014 at 02:38:40AM -0400, Jean-Philippe Ouellet wrote: ... - if ((irow = (char **)malloc(sizeof(char

Re: malloc in libssl/src/apps

2014-05-04 Thread patrick keshishian
On Sun, May 04, 2014 at 01:26:18AM -0700, Philip Guenther wrote: On Sunday, May 4, 2014, patrick keshishian sids...@boxsoft.com wrote: On Sun, May 04, 2014 at 12:29:59AM -0700, Philip Guenther wrote: On Sun, May 4, 2014 at 12:21 AM, patrick keshishian sids...@boxsoft.comjavascript

Re: malloc in libssl/src/apps

2014-05-04 Thread patrick keshishian
On Sun, May 04, 2014 at 02:38:40AM -0400, Jean-Philippe Ouellet wrote: Hello, I've gone through lib/libssl/src/apps with the goal of making {m,c,re}alloc uses more idiomatic, adding error checking in some places where missing, and some minor style unification. Feedback appreciated, better

Re: malloc in libssl/src/apps

2014-05-04 Thread patrick keshishian
On Sun, May 04, 2014 at 03:50:06PM -0400, Jean-Philippe Ouellet wrote: On Sun, May 04, 2014 at 12:17:16PM -0600, Theo de Raadt wrote: We are going to completely ignore diffs which change multiple idioms at once. Okay. That is how mistakes get made. Yep, more true than I realized.

Re: vfs references to strncpy and MFSNAMELEN

2014-05-01 Thread patrick keshishian
On 4/29/14, H??ctor Luis Gimbatti h...@etale.com.ar wrote: The constant MFSNAMELEN as defined in: lib/libc/sys/getfsstat.2:#define MFSNAMELEN 16 lib/libc/sys/statfs.2:#define MFSNAMELEN 16 sys/sys/mount.h: #define MFSNAMELEN 16 defines the fs type name and, according to

Re: [PATCH| zero a freed pointer passed in a struct, to prevent reuse after free

2014-04-22 Thread patrick keshishian
On Tue, Apr 22, 2014 at 10:33:55PM -0600, Bob Beck wrote: Yes, ok committed On Wed, Apr 23, 2014 at 03:55:19AM +0200, Dirk Engling wrote: Index: x_x509.c === RCS file: /cvs/src/lib/libssl/src/crypto/asn1/x_x509.c,v

Re: segfault in dhclient 5.4 please help

2014-04-14 Thread patrick keshishian
On 4/14/14, sven falempin sven.falem...@gmail.com wrote: [..] OpenBSD 5.4 (GENERIC) #37: Tue Jul 30 12:05:01 MDT 2013 dera...@i386.openbsd.org:/usr/src/sys/arch/i386/compile/GENERIC [...] so i got gdb back to the machine because i cannot reproduce outside of the box. gdb too old cannot

Re: Switch OpenBSD manuals to DocBook

2014-04-01 Thread patrick keshishian
On 4/1/14, Theo de Raadt dera...@cvs.openbsd.org wrote: In the short-run, can't you achieve your goal the same way with this: pod2mdoc - doclifter - docbook2mdoc - man Eventually, we can re-write man to accept more sophisticated formats directly instead of being tied to mdoc(7), but this

Re: Switch OpenBSD manuals to DocBook

2014-04-01 Thread patrick keshishian
On 4/1/14, Hendrickson, Kenneth khend...@harris.com wrote: On 4/1/2014, Patrick Keshishian wrote: sorry to crash your party, but i think you've got something there with the usage() example. this could reduce man executable to a one line shell script (or a builtin): $ cat /usr/bin/man

Re: dd oldebcdic is old

2014-03-24 Thread patrick keshishian
On 3/24/14, Ted Unangst t...@tedunangst.com wrote: Last call, convert your oldebcdic tapes (not to be confused with old ebcdic tapes) now before it's too late. Just curious why this removal? Saving space? --patrick Index: args.c

[diff] calendar.birthday

2014-03-05 Thread patrick keshishian
Index: calendar.birthday === RCS file: /cvs/obsd/src/usr.bin/calendar/calendars/calendar.birthday,v retrieving revision 1.57 diff -u -p -u -p -r1.57 calendar.birthday --- calendar.birthday 11 Feb 2014 12:20:34 - 1.57 +++

Re: panic: __mp_lock_held(sched_lock) 2013-DEC-27 snapshot

2014-01-29 Thread patrick keshishian
On Wed, Jan 29, 2014 at 07:50:34AM +0100, J??r??mie Courr??ges-Anglas wrote: patrick keshishian sids...@boxsoft.com writes: On Tue, Jan 28, 2014 at 09:02:31PM -0800, Philip Guenther wrote: On Tue, Jan 28, 2014 at 4:55 PM, patrick keshishian sids...@boxsoft.com wrote: Side note 1

panic: __mp_lock_held(sched_lock) 2013-DEC-27 snapshot

2014-01-28 Thread patrick keshishian
Hi, Not sure if anyone is interested in this panic as the snapshot is a bit old. Happend while gdb-ing a process. (typing off images; expect typos) login: panic: kernel diagnostic assertion __mp_lock_held(sched_lock) == 0 failed: file ../../../../lock.c, line 126 Stopped at Debugger+0x5:

Re: panic: __mp_lock_held(sched_lock) 2013-DEC-27 snapshot

2014-01-28 Thread patrick keshishian
On Tue, Jan 28, 2014 at 09:02:31PM -0800, Philip Guenther wrote: On Tue, Jan 28, 2014 at 4:55 PM, patrick keshishian sids...@boxsoft.com wrote: Not sure if anyone is interested in this panic as the snapshot is a bit old. Happend while gdb-ing a process. (typing off images; expect

Re: restoring keyboard layout after suspend or hibernate

2014-01-23 Thread patrick keshishian
On Thu, Jan 23, 2014 at 08:57:43PM +, Miod Vallat wrote: [cc: tech@, reply-to set to tech@] After suspend or hibernate, I lose my designated console keyboard layout (sv) and it reverts to the default (us?) wsconsctl shows that the encoding to still be sv,

Re: restoring keyboard layout after suspend or hibernate

2014-01-23 Thread patrick keshishian
On 1/23/14, Miod Vallat m...@online.fr wrote: Something is inconsistent here. Do you mean the uk is not the default? Or there is a difference between mux default and new attach default? How does one know whether plugging a keyboard in is reattaching it or attachning a new one? There is a

Re: ulpt question

2014-01-16 Thread patrick keshishian
On Wed, Jan 15, 2014 at 11:41:05PM -0800, Philip Guenther wrote: On Wed, Jan 15, 2014 at 11:07 PM, patrick keshishian pkesh...@gmail.com wrote: Now here, I need an expert's help. I must be looking at this upside down or sideways, because I don't see where ulpt_do_write() is called, well

ulpt question

2014-01-15 Thread patrick keshishian
Hello, $ sysctl kern.version kern.version=OpenBSD 5.4-current (GENERIC.MP) #222: Fri Dec 27 22:33:50 MST 2013 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP I just got this USB printer and I'm trying to write some code to directly control it. It attaches as ulpt, which

Re: Request for Funding our Electricity

2014-01-14 Thread patrick keshishian
On 1/14/14, Theo de Raadt dera...@cvs.openbsd.org wrote: On Tue, Jan 14, 2014 at 3:03 PM, Bob Beck b...@openbsdfoundation.org wrote: Just to bring this issue back to the forefront. In light of shrinking funding, we do need to look for a source to cover project expenses. If need be

Re: column memory leak fix

2013-12-30 Thread patrick keshishian
On Mon, Dec 30, 2013 at 04:58:50PM +0100, Mike Belopuhov wrote: On 30 December 2013 16:35, Loganaden Velvindron lo...@elandsys.com wrote: On Mon, Dec 30, 2013 at 08:42:00AM -0500, Ted Unangst wrote: On Mon, Dec 30, 2013 at 13:53, Mike Belopuhov wrote: On Mon, Dec 30, 2013 at 03:59 -0800,

Re: ldconfig fd leak fix

2013-12-29 Thread patrick keshishian
Hi, Accidentally deleted this message from my inbox. This is a reconstruction from mailing list archive. Suggestion/comment below. Earlier today: Hi All, From NetBSD: Fix file descriptor leak. Found by cppcheck. Index: src/libexec/ld.so/ldconfig/ldconfig.c

Re: ldconfig fd leak fix

2013-12-29 Thread patrick keshishian
On Sun, Dec 29, 2013 at 11:49:29AM -0800, Loganaden Velvindron wrote: On Sun, Dec 29, 2013 at 09:51:28AM -0800, patrick keshishian wrote: Hi, Accidentally deleted this message from my inbox. This is a reconstruction from mailing list archive. Suggestion/comment below. Earlier

  1   2   >