On Sat, Aug 02, 2014 at 10:35:43PM +0200, Fritjof Bornebusch wrote:
Ping?
On Fri, Aug 01, 2014 at 08:03:58AM -0400, Ted Unangst wrote:
Half true. :)
The behavior is intended. I don't really know why they care about
freeing null, but the intention is clearly to check for it; otherwise
On Fri, Aug 01, 2014 at 08:03:58AM -0400, Ted Unangst wrote:
Half true. :)
The behavior is intended. I don't really know why they care about
freeing null, but the intention is clearly to check for it; otherwise
they would just call free() in the first place. (actually, i think the
rationale
On Thu, Jul 31, 2014 at 18:10, Remco wrote:
Fritjof Bornebusch wrote:
Hi tech,
there is an unnecessary NULL check before calling free.
fritjof
Index: xmalloc.c
===
RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v
retrieving
On Wed, Jul 30, 2014 at 07:37:29PM -0700, patrick keshishian wrote:
On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote:
Hi tech,
there is an unnecessary NULL check before calling free.
fritjof
Index: xmalloc.c
On Thu, Jul 31, 2014 at 6:39 AM, Fritjof Bornebusch frit...@alokat.org wrote:
On Wed, Jul 30, 2014 at 07:37:29PM -0700, patrick keshishian wrote:
On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote:
Hi tech,
there is an unnecessary NULL check before calling free.
fritjof
On Thu, Jul 31, 2014 at 10:32:07AM -0400, sven falempin wrote:
On Thu, Jul 31, 2014 at 6:39 AM, Fritjof Bornebusch frit...@alokat.org
wrote:
On Wed, Jul 30, 2014 at 07:37:29PM -0700, patrick keshishian wrote:
On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote:
Hi tech,
On 07/31/14 12:39, Fritjof Bornebusch wrote:
That's why there is no need, to use a condition like:
if(ptr == NULL)
errx(1, xfree: NULL pointer given as argument);
Yes, there is.
There is a big difference between free(NULL) and xfree(NULL).
Hi tech,
there is an unnecessary NULL check before calling free.
fritjof
Index: xmalloc.c
===
RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v
retrieving revision 1.4
diff -u -p -r1.4 xmalloc.c
--- xmalloc.c 7 Jun 2009 08:39:13 -
On Wed, Jul 30, 2014 at 10:14:54PM +0200, Fritjof Bornebusch wrote:
Hi tech,
there is an unnecessary NULL check before calling free.
fritjof
Index: xmalloc.c
===
RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v
retrieving