Re: [patch] Remove archaic manual sizing from dump(8)

2015-07-26 Thread Theo de Raadt
 On 2015-07-23, Michael McConville mmcco...@sccs.swarthmore.edu wrote:
 
  --- sbin/dump/main.c23 May 2015 05:17:20 -  1.56
  +++ sbin/dump/main.c15 Jun 2015 23:16:10 -
  @@ -115,7 +115,7 @@ main(int argc, char *argv[])
  usage();
   
  obsolete(argc, argv);
  -   while ((ch = getopt(argc, argv, 0123456789aB:b:cd:f:h:ns:ST:uWw)) != 
  -1)
  +   while ((ch = getopt(argc, argv, 0123456789AB:b:cd:f:h:ns:ST:uWw)) != 
  -1)
 
 This will break lots of backup scripts.  Should -a continue to be
 supported for some time?

Definately.  At minimum, as a no-op.  Though if it previously acted as any
sort of override over other selected options, that might be needed too.



Re: [patch] Remove archaic manual sizing from dump(8)

2015-07-24 Thread Michael McConville
On Fri, Jul 24, 2015 at 10:17:12PM +, Christian Weisgerber wrote:
 On 2015-07-23, Michael McConville mmcco...@sccs.swarthmore.edu wrote:
 
  --- sbin/dump/main.c23 May 2015 05:17:20 -  1.56
  +++ sbin/dump/main.c15 Jun 2015 23:16:10 -
  @@ -115,7 +115,7 @@ main(int argc, char *argv[])
  usage();
   
  obsolete(argc, argv);
  -   while ((ch = getopt(argc, argv, 0123456789aB:b:cd:f:h:ns:ST:uWw)) != 
  -1)
  +   while ((ch = getopt(argc, argv, 0123456789AB:b:cd:f:h:ns:ST:uWw)) != 
  -1)
 
 This will break lots of backup scripts.  Should -a continue to be
 supported for some time?

I removed it because I wasn't sure whether the project liked placebo
legacy flags. Should I replace it?



Re: [patch] Remove archaic manual sizing from dump(8)

2015-07-24 Thread trondd

On 2015-07-24 19:15, Michael McConville wrote:

I removed it because I wasn't sure whether the project liked placebo
legacy flags. Should I replace it?


For reference: When -U was removed it was removed.

http://marc.info/?t=14280712873r=1w=2

Tim.



Re: [patch] Remove archaic manual sizing from dump(8)

2015-07-24 Thread Christian Weisgerber
On 2015-07-23, Michael McConville mmcco...@sccs.swarthmore.edu wrote:

 --- sbin/dump/main.c  23 May 2015 05:17:20 -  1.56
 +++ sbin/dump/main.c  15 Jun 2015 23:16:10 -
 @@ -115,7 +115,7 @@ main(int argc, char *argv[])
   usage();
  
   obsolete(argc, argv);
 - while ((ch = getopt(argc, argv, 0123456789aB:b:cd:f:h:ns:ST:uWw)) != 
 -1)
 + while ((ch = getopt(argc, argv, 0123456789AB:b:cd:f:h:ns:ST:uWw)) != 
 -1)

This will break lots of backup scripts.  Should -a continue to be
supported for some time?

-- 
Christian naddy Weisgerber  na...@mips.inka.de



Re: [patch] Remove archaic manual sizing from dump(8)

2015-07-24 Thread Alexander Hall

On 07/25/15 01:46, trondd wrote:

On 2015-07-24 19:15, Michael McConville wrote:

I removed it because I wasn't sure whether the project liked placebo
legacy flags. Should I replace it?


For reference: When -U was removed it was removed.


Compared to -a, which we've had since -97, -U was a glitch in the 
matrix, surviving for less than a year. I doubt it was as widely used as 
-a either.


A bit of grace time, possibly with a warning, might be reasonable.

/Alexander



http://marc.info/?t=14280712873r=1w=2

Tim.





[patch] Remove archaic manual sizing from dump(8)

2015-07-23 Thread Michael McConville
ping

https://marc.info/?l=openbsd-techm=143432732005608w=2

https://marc.info/?l=openbsd-techm=143441062327954w=2



Index: sbin/dump/dump.8
===
RCS file: /cvs/src/sbin/dump/dump.8,v
retrieving revision 1.49
diff -u -p -r1.49 dump.8
--- sbin/dump/dump.83 May 2015 01:44:34 -   1.49
+++ sbin/dump/dump.815 Jun 2015 23:16:10 -
@@ -40,7 +40,7 @@
 .Sh SYNOPSIS
 .Nm dump
 .Bk -words
-.Op Fl 0123456789acnSuWw
+.Op Fl 0123456789AcnSuWw
 .Op Fl B Ar records
 .Op Fl b Ar blocksize
 .Op Fl d Ar density
@@ -62,8 +62,8 @@ A dump that is larger than the output me
 multiple volumes.
 On most media the size is determined by writing until an
 end-of-media indication is returned.
-This can be enforced by using the
-.Fl a
+This is the default behavior and can be overridden with the
+.Fl A
 option.
 .Pp
 .Nm
@@ -98,7 +98,10 @@ On media that cannot reliably return an 
 each volume is of a fixed size;
 the actual size is determined by the tape size, density and/or
 block count options below.
-By default, the same output file name is used for each volume
+The
+.Fl A
+option should be used with such media.
+The same output file name is used for each volume
 after prompting the operator to change media.
 .Pp
 Rewinding or ejecting tape features after a close operation on
@@ -126,15 +129,24 @@ to
 copy all files new or modified since the
 last dump of a lower level.
 The default level is 0.
-.It Fl a
-.Dq auto-size .
-Bypass all tape length considerations, and enforce writing until
-an end-of-media indication is returned.
-This option is recommended for most modern tape drives.
-Use of this option is particularly
-recommended when appending to an existing tape, or using a tape
-drive with hardware compression (where you can never be sure about
-the compression ratio).
+.It Fl A
+.Dq fixed-size .
+Assume that the media cannot reliably return
+an end-of-media indication, and therefore use fixed
+volume sizes.
+.Nm
+will prompt the operator
+for the readiness of each
+volume before it is written to.
+.Pp
+This was once the default behavior of
+.Nm dump Ns ,
+while the
+.Fl a
+option enforced auto-sizing. The default was reversed
+because backup volumes
+without end-of-media indication are becoming
+increasingly rare.
 .It Fl B Ar records
 The number of kilobytes per volume, rounded
 down to a multiple of the blocksize.
@@ -451,6 +463,13 @@ The
 .Bx 4.3
 option syntax is implemented for backward compatibility but
 is not documented here.
+.Pp
+The
+.Fl A
+option first appeared and the
+.Fl a
+option was removed in
+.Ox 5.8 .
 .Sh BUGS
 Fewer than 32 read errors on the filesystem are ignored.
 .Pp
Index: sbin/dump/dump.h
===
RCS file: /cvs/src/sbin/dump/dump.h,v
retrieving revision 1.24
diff -u -p -r1.24 dump.h
--- sbin/dump/dump.h23 May 2015 05:17:20 -  1.24
+++ sbin/dump/dump.h15 Jun 2015 23:16:10 -
@@ -68,7 +68,7 @@ int   newtape;/* new tape flag */
 intdensity;/* density in 0.1 units */
 int64_ttapesize;   /* estimated tape size, blocks */
 int64_ttsize;  /* tape size in 0.1 units */
-intunlimited;  /* if set, write to end of medium */
+intfixed;  /* if set, use fixed volume size */
 int64_tasize;  /* number of 0.1 units written on current tape 
*/
 intetapes; /* estimated number of tapes */
 intnonodump;   /* if set, do not honor UF_NODUMP user flags */
Index: sbin/dump/main.c
===
RCS file: /cvs/src/sbin/dump/main.c,v
retrieving revision 1.56
diff -u -p -r1.56 main.c
--- sbin/dump/main.c23 May 2015 05:17:20 -  1.56
+++ sbin/dump/main.c15 Jun 2015 23:16:10 -
@@ -115,7 +115,7 @@ main(int argc, char *argv[])
usage();
 
obsolete(argc, argv);
-   while ((ch = getopt(argc, argv, 0123456789aB:b:cd:f:h:ns:ST:uWw)) != 
-1)
+   while ((ch = getopt(argc, argv, 0123456789AB:b:cd:f:h:ns:ST:uWw)) != 
-1)
switch (ch) {
/* dump level */
case '0': case '1': case '2': case '3': case '4':
@@ -193,8 +193,8 @@ main(int argc, char *argv[])
exit(X_FINOK);  /* do nothing else */
break;
 
-   case 'a':   /* `auto-size', Write to EOM. */
-   unlimited = 1;
+   case 'A':   /* `fixed-size' volumes */
+   fixed = 1;
break;
 
default:
@@ -291,7 +291,7 @@ main(int argc, char *argv[])
 
if (blocksperfile)
blocksperfile = blocksperfile / ntrec * ntrec; /* round down */
-   else if (!unlimited) {
+   else if (fixed) {
/*
 * Determine how to default tape size and density
 *
@@