Re: EV_SET(2) shadows variable

2020-04-05 Thread Philip Guenther
On Sat, 4 Apr 2020, Theo de Raadt wrote: > Philip Guenther wrote: > > > On Fri, 3 Apr 2020, Martin Pieuchot wrote: > > > Thanks, here it is, ok? > > > > ok guenther@ > > Should we do the same to all other macros, just in case? Checking /usr/include/{,sys/}*.h, the diff below fixes the only

Re: EV_SET(2) shadows variable

2020-04-04 Thread Theo de Raadt
Philip Guenther wrote: > On Fri, 3 Apr 2020, Martin Pieuchot wrote: > > Thanks, here it is, ok? > > ok guenther@ Should we do the same to all other macros, just in case?

Re: EV_SET(2) shadows variable

2020-04-03 Thread Philip Guenther
On Fri, 3 Apr 2020, Martin Pieuchot wrote: > Thanks, here it is, ok? ok guenther@

Re: EV_SET(2) shadows variable

2020-04-03 Thread Martin Pieuchot
On 02/04/20(Thu) 13:36, Philip Guenther wrote: > On Tue, Mar 31, 2020 at 11:24 PM Martin Pieuchot wrote: > > > The current form of EV_SET(2) declares a `kevp' variable. This can > > cause to subtle bugs hard to discover if one uses a variable of the > > same to retrieve events. > > > > Diff

Re: EV_SET(2) shadows variable

2020-04-02 Thread Philip Guenther
On Tue, Mar 31, 2020 at 11:24 PM Martin Pieuchot wrote: > The current form of EV_SET(2) declares a `kevp' variable. This can > cause to subtle bugs hard to discover if one uses a variable of the > same to retrieve events. > > Diff below prefixes the locally declared variable by an underscore, >

EV_SET(2) shadows variable

2020-04-01 Thread Martin Pieuchot
The current form of EV_SET(2) declares a `kevp' variable. This can cause to subtle bugs hard to discover if one uses a variable of the same to retrieve events. Diff below prefixes the locally declared variable by an underscore, like it it done in FD_ZERO(), which should be good enough to prevent