Re: Kill cdev_mousewr_init()

[Jonathan Gray]

On Fri, Apr 03, 2020 at 10:56:32AM +0200, Martin Pieuchot wrote:
> Unused macro, found while auditing d_poll() functions, ok?

ok jsg@

> 
> Index: sys/conf.h
> ===
> RCS file: /cvs/src/sys/sys/conf.h,v
> retrieving revision 1.148
> diff -u -p -r1.148 conf.h
> --- sys/conf.h22 Jan 2020 23:06:05 -  1.148
> +++ sys/conf.h2 Apr 2020 15:29:59 -
> @@ -196,13 +196,6 @@ extern struct cdevsw cdevsw[];
>   (dev_type_stop((*))) enodev, 0, dev_init(c,n,poll), \
>   (dev_type_mmap((*))) enodev , 0, 0, dev_init(c,n,kqfilter) }
>  
> -/* open, close, read, write, ioctl, poll, nokqfilter */
> -#define  cdev_mousewr_init(c,n) { \
> - dev_init(c,n,open), dev_init(c,n,close), dev_init(c,n,read), \
> - dev_init(c,n,write), dev_init(c,n,ioctl), \
> - (dev_type_stop((*))) enodev, 0, dev_init(c,n,poll), \
> - (dev_type_mmap((*))) enodev }
> -
>  #define  cdev_notdef() { \
>   (dev_type_open((*))) enodev, (dev_type_close((*))) enodev, \
>   (dev_type_read((*))) enodev, (dev_type_write((*))) enodev, \
> 
> 

Re: Kill cdev_mousewr_init()

[Jeremie Courreges-Anglas]

On Fri, Apr 03 2020, Martin Pieuchot  wrote:
> Unused macro, found while auditing d_poll() functions, ok?

ok

> Index: sys/conf.h
> ===
> RCS file: /cvs/src/sys/sys/conf.h,v
> retrieving revision 1.148
> diff -u -p -r1.148 conf.h
> --- sys/conf.h22 Jan 2020 23:06:05 -  1.148
> +++ sys/conf.h2 Apr 2020 15:29:59 -
> @@ -196,13 +196,6 @@ extern struct cdevsw cdevsw[];
>   (dev_type_stop((*))) enodev, 0, dev_init(c,n,poll), \
>   (dev_type_mmap((*))) enodev , 0, 0, dev_init(c,n,kqfilter) }
>  
> -/* open, close, read, write, ioctl, poll, nokqfilter */
> -#define  cdev_mousewr_init(c,n) { \
> - dev_init(c,n,open), dev_init(c,n,close), dev_init(c,n,read), \
> - dev_init(c,n,write), dev_init(c,n,ioctl), \
> - (dev_type_stop((*))) enodev, 0, dev_init(c,n,poll), \
> - (dev_type_mmap((*))) enodev }
> -
>  #define  cdev_notdef() { \
>   (dev_type_open((*))) enodev, (dev_type_close((*))) enodev, \
>   (dev_type_read((*))) enodev, (dev_type_write((*))) enodev, \
>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Kill cdev_mousewr_init()

[Martin Pieuchot]

Unused macro, found while auditing d_poll() functions, ok?

Index: sys/conf.h
===
RCS file: /cvs/src/sys/sys/conf.h,v
retrieving revision 1.148
diff -u -p -r1.148 conf.h
--- sys/conf.h  22 Jan 2020 23:06:05 -  1.148
+++ sys/conf.h  2 Apr 2020 15:29:59 -
@@ -196,13 +196,6 @@ extern struct cdevsw cdevsw[];
(dev_type_stop((*))) enodev, 0, dev_init(c,n,poll), \
(dev_type_mmap((*))) enodev , 0, 0, dev_init(c,n,kqfilter) }
 
-/* open, close, read, write, ioctl, poll, nokqfilter */
-#definecdev_mousewr_init(c,n) { \
-   dev_init(c,n,open), dev_init(c,n,close), dev_init(c,n,read), \
-   dev_init(c,n,write), dev_init(c,n,ioctl), \
-   (dev_type_stop((*))) enodev, 0, dev_init(c,n,poll), \
-   (dev_type_mmap((*))) enodev }
-
 #definecdev_notdef() { \
(dev_type_open((*))) enodev, (dev_type_close((*))) enodev, \
(dev_type_read((*))) enodev, (dev_type_write((*))) enodev, \