Re: LC_MESSAGES in xargs(1)

2020-07-19 Thread Ingo Schwarze
Hi Martijn, Martijn van Duren wrote on Thu, Jul 16, 2020 at 11:13:31PM +0200: > I gave a quick look at replacing prompt with readpassphrase(3), but that > would be more trouble than it's worth. (adjusting pledge, semantics > change in where the "?..." would be printed). > > Minor nits inline,

Re: LC_MESSAGES in xargs(1)

2020-07-16 Thread Martijn van Duren
I gave a quick look at replacing prompt with readpassphrase(3), but that would be more trouble than it's worth. (adjusting pledge, semantics change in where the "?..." would be printed). Minor nits inline, but either way OK martijn@ On Thu, 2020-07-16 at 21:49 +0200, Ingo Schwarze wrote: > Hi

Re: LC_MESSAGES in xargs(1)

2020-07-16 Thread Klemens Nanni
On Thu, Jul 16, 2020 at 09:49:21PM +0200, Ingo Schwarze wrote: > That allows a nice cleanup, simplifying the code and getting rid > of several headers and several calls to complicated functions. OK kn

Re: LC_MESSAGES in xargs(1)

2020-07-16 Thread Ingo Schwarze
Hi Jan, Jan Stary wrote on Thu, Jul 16, 2020 at 09:45:44AM +0200: > Does xargs need to set LC_MESSAGES? As it stands, your patch doesn't make much sense. It is true that it doesn't change behaviour, but it leaves more cruft behund than it tidies up. That said, i agree that we will never

LC_MESSAGES in xargs(1)

2020-07-16 Thread Jan Stary
Does xargs need to set LC_MESSAGES? Jan Index: usr.bin/xargs/xargs.c === RCS file: /cvs/src/usr.bin/xargs/xargs.c,v retrieving revision 1.34 diff -u -p -r1.34 xargs.c --- usr.bin/xargs/xargs.c 12 Jun 2018 15:24:31