Re: fix format warning

2017-08-07 Thread Florian Obser
OK florian@ On Mon, Aug 07, 2017 at 11:53:13AM +0200, Mark Kettenis wrote: > > Date: Mon, 7 Aug 2017 11:32:55 +0200 (CEST) > > From: Mark Kettenis > > > > > Date: Mon, 7 Aug 2017 11:04:51 +0200 (CEST) > > > From: Markus Hennecke > > > > > > On Thu, 3 Aug 2017, Mark Kettenis wrote: > > > > > >

Re: fix format warning

2017-08-07 Thread Alexander Bluhm
On Mon, Aug 07, 2017 at 11:53:13AM +0200, Mark Kettenis wrote: > Or as pirofti@ suggests, simply droppy the 'h' modifier altogether is > safe as well as u_char gets promoted to int in a varargs function. > And clang doesn't want about this one. > > Any preference? When I encountered this problem

Re: fix format warning

2017-08-07 Thread Mark Kettenis
> Date: Mon, 7 Aug 2017 11:32:55 +0200 (CEST) > From: Mark Kettenis > > > Date: Mon, 7 Aug 2017 11:04:51 +0200 (CEST) > > From: Markus Hennecke > > > > On Thu, 3 Aug 2017, Mark Kettenis wrote: > > > > > Currently clang ignores the "kprintf" format attribute. I've got a > > > fix for that, but

Re: fix format warning

2017-08-07 Thread Mark Kettenis
> Date: Mon, 7 Aug 2017 11:04:51 +0200 (CEST) > From: Markus Hennecke > > On Thu, 3 Aug 2017, Mark Kettenis wrote: > > > Currently clang ignores the "kprintf" format attribute. I've got a > > fix for that, but with that fix it complains about the code fixed in > > the diff below. > > > > Now o