Re: syspatch exit state

2020-12-07 Thread Solene Rapenne
On Mon, 7 Dec 2020 13:39:30 +0100 Antoine Jacoutot : > Index: syspatch.8 > === > RCS file: /cvs/src/usr.sbin/syspatch/syspatch.8,v > retrieving revision 1.21 > diff -u -p -r1.21 syspatch.8 > --- syspatch.825 Jul 2020

Re: syspatch exit state

2020-12-07 Thread Ingo Schwarze
Hi Antoine, Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 01:39:30PM +0100: > On Mon, Dec 07, 2020 at 01:30:55PM +0100, Ingo Schwarze wrote: >> Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 01:01:27PM +0100: >>> I just tested this change and it seems to work: [...] >> I think a slightly more

Re: syspatch exit state

2020-12-07 Thread Antoine Jacoutot
On Mon, Dec 07, 2020 at 01:30:55PM +0100, Ingo Schwarze wrote: > Hello Antoine, > > Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 01:01:27PM +0100: > > > I just tested this change and it seems to work: > > I did not repeat my testing, but here is some quick feedback purely > from code

Re: syspatch exit state

2020-12-07 Thread Ingo Schwarze
Hello Antoine, Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 01:01:27PM +0100: > I just tested this change and it seems to work: I did not repeat my testing, but here is some quick feedback purely from code inspection: The proposed code change makes sense to me. The proposed manual page text

Re: syspatch exit state

2020-12-07 Thread Antoine Jacoutot
On Mon, Dec 07, 2020 at 11:54:04AM +0100, Ingo Schwarze wrote: > > Index: syspatch.sh > > === > > RCS file: /cvs/src/usr.sbin/syspatch/syspatch.sh,v > > retrieving revision 1.166 > > diff -u -p -r1.166 syspatch.sh > > --- syspatch.sh

Re: syspatch exit state

2020-12-07 Thread Ingo Schwarze
Hi Antoine, Antoine Jacoutot wrote on Mon, Dec 07, 2020 at 09:48:36AM +0100: > On Sun, Dec 06, 2020 at 10:52:37PM +0100, Alexander Hall wrote: >> On December 6, 2020 8:13:26 PM GMT+01:00, Antoine Jacoutot wrote: >>> On Sun, Dec 06, 2020 at 05:20:31PM +, Stuart Henderson wrote: On

Re: syspatch exit state

2020-12-07 Thread Antoine Jacoutot
On Sun, Dec 06, 2020 at 10:52:37PM +0100, Alexander Hall wrote: > > > On December 6, 2020 8:13:26 PM GMT+01:00, Antoine Jacoutot > wrote: > >On Sun, Dec 06, 2020 at 05:20:31PM +, Stuart Henderson wrote: > >> On 2020/12/06 16:39, Otto Moerbeek wrote: > >> > On Sun, Dec 06, 2020 at

Re: syspatch exit state

2020-12-06 Thread Janne Johansson
> > Returning a non-zero exit status is generally a sign of some sort of > failure. Not applying a patch due to already having the patch applied > is not really a failure. > The joys of running Solaris 2.x patches in the late 90s, where "ERROR 02" means the above, you already have the patch. And

Re: syspatch exit state

2020-12-06 Thread Alexander Hall
On December 6, 2020 8:13:26 PM GMT+01:00, Antoine Jacoutot wrote: >On Sun, Dec 06, 2020 at 05:20:31PM +, Stuart Henderson wrote: >> On 2020/12/06 16:39, Otto Moerbeek wrote: >> > On Sun, Dec 06, 2020 at 03:31:19PM +, SW wrote: >> > >> > > On 06/12/2020 14:32, Otto Moerbeek wrote: >>

Re: syspatch exit state

2020-12-06 Thread Antoine Jacoutot
On Sun, Dec 06, 2020 at 05:20:31PM +, Stuart Henderson wrote: > On 2020/12/06 16:39, Otto Moerbeek wrote: > > On Sun, Dec 06, 2020 at 03:31:19PM +, SW wrote: > > > > > On 06/12/2020 14:32, Otto Moerbeek wrote: > > > > On Sun, Dec 06, 2020 at 02:19:05PM +, SW wrote: > > > > > > > >>

Re: syspatch exit state

2020-12-06 Thread Stuart Henderson
On 2020/12/06 16:39, Otto Moerbeek wrote: > On Sun, Dec 06, 2020 at 03:31:19PM +, SW wrote: > > > On 06/12/2020 14:32, Otto Moerbeek wrote: > > > On Sun, Dec 06, 2020 at 02:19:05PM +, SW wrote: > > > > > >> Hi, > > >> I've been looking to have syspatch give me a quick indication of

Re: syspatch exit state

2020-12-06 Thread SW
> Returning a non-zero exit status is generally a sign of some sort of > failure. Not applying a patch due to already having the patch applied > is not really a failure. Generally agreed, though at the same time, sysupgrade returns non-zero if there is no upgrade to apply so the same behaviour

Re: syspatch exit state

2020-12-06 Thread Andreas Kusalananda Kähäri
On Sun, Dec 06, 2020 at 02:19:05PM +, SW wrote: > Hi, > I've been looking to have syspatch give me a quick indication of whether > a reboot is likely to be required. As a quick and dirty check, I've just > been treating "Were patches applied?" as the indicator. > > The following diff will

Re: syspatch exit state

2020-12-06 Thread Otto Moerbeek
On Sun, Dec 06, 2020 at 03:31:19PM +, SW wrote: > On 06/12/2020 14:32, Otto Moerbeek wrote: > > On Sun, Dec 06, 2020 at 02:19:05PM +, SW wrote: > > > >> Hi, > >> I've been looking to have syspatch give me a quick indication of whether > >> a reboot is likely to be required. As a quick and

Re: syspatch exit state

2020-12-06 Thread SW
On 06/12/2020 14:32, Otto Moerbeek wrote: > On Sun, Dec 06, 2020 at 02:19:05PM +, SW wrote: > >> Hi, >> I've been looking to have syspatch give me a quick indication of whether >> a reboot is likely to be required. As a quick and dirty check, I've just >> been treating "Were patches applied?"

Re: syspatch exit state

2020-12-06 Thread Otto Moerbeek
On Sun, Dec 06, 2020 at 02:19:05PM +, SW wrote: > Hi, > I've been looking to have syspatch give me a quick indication of whether > a reboot is likely to be required. As a quick and dirty check, I've just > been treating "Were patches applied?" as the indicator. > > The following diff will