Re: asmc: restore keyboard backlight on resume

2017-02-11 Thread Theo de Raadt
>I'm not sure if you choose DVACT_WAKEUP on purpose, another way of doing >it would be to do a task_add() in DVACT_RESUME. The difference is that >the resuming thread is not allowed to sleep in RESUME. At some point we >tried to keep the number of WAKEUP low, but I'm not sure if it is still

Re: asmc: restore keyboard backlight on resume

2017-02-10 Thread Mike Larkin
On Thu, Feb 09, 2017 at 06:41:38PM -0600, joshua stein wrote: > After resume, the keyboard backlight is still off, so restore it > (this was also helpful to figure out the machine was actually > resuming). > looks ok to me. ok mlarkin@ -ml > > Index: sys/dev/isa/asmc.c >

Re: asmc: restore keyboard backlight on resume

2017-02-10 Thread Martin Pieuchot
On 09/02/17(Thu) 18:41, joshua stein wrote: > After resume, the keyboard backlight is still off, so restore it > (this was also helpful to figure out the machine was actually > resuming). ok mpi@ I'm not sure if you choose DVACT_WAKEUP on purpose, another way of doing it would be to do a

asmc: restore keyboard backlight on resume

2017-02-09 Thread joshua stein
After resume, the keyboard backlight is still off, so restore it (this was also helpful to figure out the machine was actually resuming). Index: sys/dev/isa/asmc.c === RCS file: /cvs/src/sys/dev/isa/asmc.c,v retrieving revision 1.30