Re: cdio: read_track: plug leak

2017-09-10 Thread Scott Cheloha
> On Sep 10, 2017, at 9:35 PM, Michael W. Bombardieri wrote: > > Patch was also posted here, but I didn't test it. > https://marc.info/?l=openbsd-tech=149784342025304=2 omg we're twins

Re: cdio: read_track: plug leak

2017-09-10 Thread Michael W. Bombardieri
Hi, Patch was also posted here, but I didn't test it. https://marc.info/?l=openbsd-tech=149784342025304=2 - Michael On Sun, Sep 10, 2017 at 04:23:49PM -0500, Scott Cheloha wrote: > Hi, > > Saw this when preparing the monotonic clock patch. > > This is a leak, right? Every other return path

cdio: read_track: plug leak

2017-09-10 Thread Scott Cheloha
Hi, Saw this when preparing the monotonic clock patch. This is a leak, right? Every other return path in read_track() aside from the malloc failure frees sec. I think the function itself is more confusing than it needs to be and could use a refactor but that belongs in a separate patch.