Re: mention vdrop in vhold.9

2012-09-16 Thread Jason McIntyre
On Sat, Sep 15, 2012 at 07:26:40PM -0700, Philip Guenther wrote: On Sat, Sep 15, 2012 at 1:42 AM, Jason McIntyre j...@kerhand.co.uk wrote: On Sat, Sep 15, 2012 at 10:19:35AM +0200, Michal Mazurek wrote: doesn;t the code mean the check is for zero, not less than or equal to zero? Oops,

Re: mention vdrop in vhold.9

2012-09-16 Thread Jason McIntyre
On Sun, Sep 16, 2012 at 10:54:40AM +0059, Jason McIntyre wrote: thanks, i think that reads better too. ok? jmc just spotted that the name description (Nd) for this file is now out of date. updated accordingly (from freebsd). ok? jmc Index: Makefile

Re: mention vdrop in vhold.9

2012-09-16 Thread Philip Guenther
On Sun, Sep 16, 2012 at 9:18 AM, Jason McIntyre j...@kerhand.co.uk wrote: just spotted that the name description (Nd) for this file is now out of date. updated accordingly (from freebsd). ok? Ship it! guenther@

Re: mention vdrop in vhold.9

2012-09-16 Thread Jason McIntyre
On Fri, Sep 14, 2012 at 08:08:48PM +0200, Michal Mazurek wrote: Taken from FreeBSD. an altered version of your diff was committed. thanks for the mail, jmc

Re: mention vdrop in vhold.9

2012-09-15 Thread Jason McIntyre
On Fri, Sep 14, 2012 at 08:08:48PM +0200, Michal Mazurek wrote: Taken from FreeBSD. Index: Makefile === RCS file: /cvs/src/share/man/man9/Makefile,v retrieving revision 1.171 diff -u -p -r1.171 Makefile --- Makefile 21 Jun

Re: mention vdrop in vhold.9

2012-09-15 Thread Michal Mazurek
On Sat, Sep 15, 2012 at 08:44:17AM +0100, Jason McIntyre wrote: in vfs_subr.c (bear with me ;) it has: /* Lose interest in a vnode. */ void vdrop(struct vnode *vp) { #ifdef DIAGNOSTIC if (vp-v_holdcnt == 0) panic(vdrop:

Re: mention vdrop in vhold.9

2012-09-15 Thread Jason McIntyre
On Sat, Sep 15, 2012 at 10:19:35AM +0200, Michal Mazurek wrote: doesn;t the code mean the check is for zero, not less than or equal to zero? Oops, you're right. everything else looks alright. i'll commit it soon if no one objects, though i'd prefer it if another developer would ok

Re: mention vdrop in vhold.9

2012-09-15 Thread Philip Guenther
On Sat, Sep 15, 2012 at 1:42 AM, Jason McIntyre j...@kerhand.co.uk wrote: On Sat, Sep 15, 2012 at 10:19:35AM +0200, Michal Mazurek wrote: doesn;t the code mean the check is for zero, not less than or equal to zero? Oops, you're right. everything else looks alright. i'll commit it soon if

mention vdrop in vhold.9

2012-09-14 Thread Michal Mazurek
Taken from FreeBSD. Index: Makefile === RCS file: /cvs/src/share/man/man9/Makefile,v retrieving revision 1.171 diff -u -p -r1.171 Makefile --- Makefile21 Jun 2012 18:02:21 - 1.171 +++ Makefile14 Sep 2012 18:06:46