Re: reduce the direct fd_ofileflags poking

2017-02-11 Thread Todd C. Miller
On Sat, 11 Feb 2017 01:29:08 -0800, Philip Guenther wrote: > To simplify the filedesc fd_ofileflags handling, how about if we make > falloc() take optional flags to OR into the new fd's ofileflags? That > eliminates a quarter of the references to fd_ofileflags. OK, this seems much better than

reduce the direct fd_ofileflags poking

2017-02-11 Thread Philip Guenther
To simplify the filedesc fd_ofileflags handling, how about if we make falloc() take optional flags to OR into the new fd's ofileflags? That eliminates a quarter of the references to fd_ofileflags. While here, make falloc() assert that its return arguments are non-NULL, as it doesn't make sense