Re: /dev/crypto removal (3bis): DTYPE_CRYPTO

[Philip Guenther]

On Mon, Aug 18, 2014 at 8:02 AM, Mike Belopuhov m...@belopuhov.com wrote:

 I don't know if we recycle them somehow, but just in case...

 --- sys/sys/file.h
 +++ sys/sys/file.h

...

 -#defineDTYPE_CRYPTO5   /* crypto */
 +/* was define  DTYPE_CRYPTO5 */


When it goes, this is the way to document it, yep.

...but you better delete the code in usr.bin/fstat/fstat.c and
usr.sbin/pstat/pstat.c before that.


Philip

Re: /dev/crypto removal (3bis): DTYPE_CRYPTO

[Theo de Raadt]

  I don't know if we recycle them somehow, but just in case...
 
  --- sys/sys/file.h
  +++ sys/sys/file.h
 
 ...
 
  -#defineDTYPE_CRYPTO5   /* crypto */
  +/* was define  DTYPE_CRYPTO5 */
 
 
 When it goes, this is the way to document it, yep.
 
 ...but you better delete the code in usr.bin/fstat/fstat.c and
 usr.sbin/pstat/pstat.c before that.

I also approve of this way of cleaning up /dev/crypto.  Just do make
builds after every change.

/dev/crypto removal (3bis): DTYPE_CRYPTO

[Mike Belopuhov]

I don't know if we recycle them somehow, but just in case...

diff --git sys/sys/file.h sys/sys/file.h
index d98118e..64c0f31 100644
--- sys/sys/file.h
+++ sys/sys/file.h
@@ -67,11 +67,11 @@ struct file {
short   f_flag; /* see fcntl.h */
 #defineDTYPE_VNODE 1   /* file */
 #defineDTYPE_SOCKET2   /* communications endpoint */
 #defineDTYPE_PIPE  3   /* pipe */
 #defineDTYPE_KQUEUE4   /* event queue */
-#defineDTYPE_CRYPTO5   /* crypto */
+/* was define  DTYPE_CRYPTO5 */
 #defineDTYPE_SYSTRACE  6   /* system call tracing */
short   f_type; /* descriptor type */
longf_count;/* reference count */
longf_msgcount; /* references from message queue */
struct  ucred *f_cred;  /* credentials associated with descriptor */