Re: /usr/local/sbin in default PATH?

2017-12-06 Thread Theo de Raadt
Intentional.

wheel users add that sbin directory to their path when they need it.

Other users should not have it.

> Both _PATH_DEFPATH and _PATH_STDPATH, as defined in paths.h,
> include /usr/local/bin but not /usr/local/sbin,
> as opposed to /usr/bin:/bin:/usr/sbin:/sbin.
> Is that intentional?
> 
>   Jan
> 
> Index: include/paths.h
> ===
> RCS file: /cvs/src/include/paths.h,v
> retrieving revision 1.25
> diff -u -p -r1.25 paths.h
> --- include/paths.h   13 Mar 2014 15:24:41 -  1.25
> +++ include/paths.h   6 Dec 2017 12:43:29 -
> @@ -36,9 +36,9 @@
>  #define  _PATHS_H_
>  
>  /* Default search path. */
> -#define  _PATH_DEFPATH   
> "/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin"
> +#define  _PATH_DEFPATH   
> "/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin"
>  /* All standard utilities path. */
> -#define  _PATH_STDPATH   
> "/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin"
> +#define  _PATH_STDPATH   
> "/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin"
>  
>  #define  _PATH_BSHELL"/bin/sh"
>  #define  _PATH_CONSOLE   "/dev/console"
> Index: share/man/man7/environ.7
> ===
> RCS file: /cvs/src/share/man/man7/environ.7,v
> retrieving revision 1.19
> diff -u -p -r1.19 environ.7
> --- share/man/man7/environ.7  10 Sep 2015 18:47:57 -  1.19
> +++ share/man/man7/environ.7  6 Dec 2017 12:43:29 -
> @@ -99,8 +99,9 @@ but expanded to include
>  .Pa /usr/sbin ,
>  .Pa /sbin ,
>  .Pa /usr/X11R6/bin ,
> -and
>  .Pa /usr/local/bin
> +and
> +.Pa /usr/local/sbin
>  in
>  .Ox .
>  .It Ev PRINTER
> 



/usr/local/sbin in default PATH?

2017-12-06 Thread Jan Stary
Both _PATH_DEFPATH and _PATH_STDPATH, as defined in paths.h,
include /usr/local/bin but not /usr/local/sbin,
as opposed to /usr/bin:/bin:/usr/sbin:/sbin.
Is that intentional?

Jan

Index: include/paths.h
===
RCS file: /cvs/src/include/paths.h,v
retrieving revision 1.25
diff -u -p -r1.25 paths.h
--- include/paths.h 13 Mar 2014 15:24:41 -  1.25
+++ include/paths.h 6 Dec 2017 12:43:29 -
@@ -36,9 +36,9 @@
 #define_PATHS_H_
 
 /* Default search path. */
-#define_PATH_DEFPATH   
"/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin"
+#define_PATH_DEFPATH   
"/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin"
 /* All standard utilities path. */
-#define_PATH_STDPATH   
"/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin"
+#define_PATH_STDPATH   
"/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin"
 
 #define_PATH_BSHELL"/bin/sh"
 #define_PATH_CONSOLE   "/dev/console"
Index: share/man/man7/environ.7
===
RCS file: /cvs/src/share/man/man7/environ.7,v
retrieving revision 1.19
diff -u -p -r1.19 environ.7
--- share/man/man7/environ.710 Sep 2015 18:47:57 -  1.19
+++ share/man/man7/environ.76 Dec 2017 12:43:29 -
@@ -99,8 +99,9 @@ but expanded to include
 .Pa /usr/sbin ,
 .Pa /sbin ,
 .Pa /usr/X11R6/bin ,
-and
 .Pa /usr/local/bin
+and
+.Pa /usr/local/sbin
 in
 .Ox .
 .It Ev PRINTER