Re: [PATCH] Macbook1,1 - minimal diff to swap 2 key for ISO internal kbd

2020-10-28 Thread Theo de Raadt
Yes to all of that, the better names also. Mark Kettenis wrote: > > From: Mathias Schmocker > > Date: Wed, 28 Oct 2020 20:54:13 +0100 > > > > Hello, > > Here a minimal diff to solve the swapped keys of the internal ISO > > keyboard/trackpad found on my older Macbook1,1 13inch black laptop >

Re: [PATCH] Macbook1,1 - minimal diff to swap 2 key for ISO internal kbd

2020-10-28 Thread Mark Kettenis
> From: Mathias Schmocker > Date: Wed, 28 Oct 2020 20:54:13 +0100 > > Hello, > Here a minimal diff to solve the swapped keys of the internal ISO > keyboard/trackpad found on my older Macbook1,1 13inch black laptop > (6.8 i386 release) > cvs diff: Diffing . > Index: ukbd.c > =

Re: [PATCH] Macbook1,1 - minimal diff to swap 2 key for ISO internal kbd

2020-10-28 Thread Tobias Heider
On Wed, Oct 28, 2020 at 08:54:13PM +0100, Mathias Schmocker wrote: > Hello, > Here a minimal diff to solve the swapped keys of the internal ISO > keyboard/trackpad found on my older Macbook1,1 13inch black laptop Looks ok. One nit: I would propose changing the name of the device. It seems the com

[PATCH] Macbook1,1 - minimal diff to swap 2 key for ISO internal kbd

2020-10-28 Thread Mathias Schmocker
Hello, Here a minimal diff to solve the swapped keys of the internal ISO keyboard/trackpad found on my older Macbook1,1 13inch black laptop (6.8 i386 release) cvs diff: Diffing . Index: ukbd.c === RCS file: /home/cvs/src/sys/dev/usb