Re: [PATCH] Mistake in Intel/DRM...

2013-05-08 Thread Jonathan Gray
On Sun, May 05, 2013 at 01:01:28PM +0200, Maxime Villard wrote: I have been making a code scanner for a while, and I wanted to test a new rule, so I scanned sys/pci/drm. It found an uninitialized variable in intel_ddi.c. Quite simple, if !(val DDI_BUF_CTL_ENABLE) at l.1420, the variable

Re: [PATCH] Mistake in Intel/DRM...

2013-05-06 Thread David Coppa
On Sun, May 5, 2013 at 1:01 PM, Maxime Villard rusty...@gmx.fr wrote: I have been making a code scanner for a while, and I wanted to test a new rule, so I scanned sys/pci/drm. It found an uninitialized variable in intel_ddi.c. Quite simple, if !(val DDI_BUF_CTL_ENABLE) at l.1420, the

[PATCH] Mistake in Intel/DRM...

2013-05-05 Thread Maxime Villard
I have been making a code scanner for a while, and I wanted to test a new rule, so I scanned sys/pci/drm. It found an uninitialized variable in intel_ddi.c. Quite simple, if !(val DDI_BUF_CTL_ENABLE) at l.1420, the variable 'wait' is not initialized at l.1432. I guess I should send it upstream,