Re: [PATCH] VMD: Ensure disk is a regular file prior to vm boot

2017-08-30 Thread Mike Larkin
On Wed, Aug 30, 2017 at 04:56:20PM -0700, Carlos Cardenas wrote: > Add check(s) in vmd/vmctl to ensure a VM's disk are regular files. > > Tested with the following: > vmctl start "test1" -d /dev/sd3c #block device > vmctl start "test2" -d /dev/rsd3c #char device > vmctl start "test3" -d fifo #name

Re: [PATCH] VMD: Ensure disk is a regular file prior to vm boot

2017-08-30 Thread Mike Larkin
On Thu, Aug 31, 2017 at 06:56:45AM +0100, Raf Czlonka wrote: > Hi Carlos, > > Doesn't this mean that, even though it might not be possible to do > this today (is it?), you're effectively disabling the usage of > physical disks for VMs, i.e. equivalent of a raw disk device used > in other hyperviso

Re: [PATCH] VMD: Ensure disk is a regular file prior to vm boot

2017-08-30 Thread Raf Czlonka
Hi Carlos, Doesn't this mean that, even though it might not be possible to do this today (is it?), you're effectively disabling the usage of physical disks for VMs, i.e. equivalent of a raw disk device used in other hypervisors? Regards, Raf On Thu, Aug 31, 2017 at 12:56:20AM BST, Carlos Carden

[PATCH] VMD: Ensure disk is a regular file prior to vm boot

2017-08-30 Thread Carlos Cardenas
Add check(s) in vmd/vmctl to ensure a VM's disk are regular files. Tested with the following: vmctl start "test1" -d /dev/sd3c #block device vmctl start "test2" -d /dev/rsd3c #char device vmctl start "test3" -d fifo #named pipe Comments? Ok? diff --git usr.sbin/vmctl/vmctl.c usr.sbin/vmctl/vmctl