Hi tech, I have a minor KNF patch for if_pppoe.c... Submitting this in case anyone is interested.
- Michael Index: if_pppoe.c =================================================================== RCS file: /cvs/src/sys/net/if_pppoe.c,v retrieving revision 1.35 diff -u -r1.35 if_pppoe.c --- if_pppoe.c 11 Apr 2012 17:42:53 -0000 1.35 +++ if_pppoe.c 11 Mar 2013 02:18:04 -0000 @@ -389,7 +389,8 @@ } /* Analyze and handle a single received packet while not in session state. */ -static void pppoe_dispatch_disc_pkt(struct mbuf *m, int off) +static void +pppoe_dispatch_disc_pkt(struct mbuf *m, int off) { struct pppoe_softc *sc; struct pppoehdr *ph; @@ -1108,9 +1109,8 @@ PPPOE_ADD_16(p, l1); memcpy(p, sc->sc_service_name, l1); p += l1; - } else { + } else PPPOE_ADD_16(p, 0); - } if (sc->sc_concentrator_name != NULL) { PPPOE_ADD_16(p, PPPOE_TAG_ACNAME); PPPOE_ADD_16(p, l2);