Re: [PATCH] ntpd: allow to specify a source IP address for outgoing queries

2017-05-30 Thread Job Snijders
Dear team, Henning Brauer (off-list) made a few suggestions, which I summerized in the following four points: 1) poor initialization style, instead of: struct xxx yyy = { .property = zzz }; use: struct xxx yyy; yyy.property = zzz; 2) avoid creatio

Re: [PATCH] ntpd: allow to specify a source IP address for outgoing queries

2017-05-30 Thread Paul de Weerd
Works for me, verified both v4 and v6 selection actually uses that address. Suggested a small improvement for ntpd.conf(5) to Job privately. Would love to see this feature get imported :) Thanks Job! Paul On Tue, May 30, 2017 at 06:10:03PM +0200, Job Snijders wrote: | On Sun, May 28, 2017 at 1

Re: [PATCH] ntpd: allow to specify a source IP address for outgoing queries

2017-05-30 Thread Job Snijders
On Sun, May 28, 2017 at 10:52:24PM +0200, Sebastian Benoit wrote: > which makes me think: > would a global local-address be good enough? Attached is a patch that allows you to specify the source for outgoing queries, as a global option. Example ntpd.conf: query from 165.254.255.33 query f

Re: [PATCH] ntpd: allow to specify a source IP address for outgoing queries

2017-05-29 Thread Stuart Henderson
On 2017/05/29 10:04, Henning Brauer wrote: > * Sebastian Benoit [2017-05-28 22:52]: > > which makes me think: > > would a global local-address be good enough? > > I think so. This is a kinda weird/rare case. I agree. There's always NAT for special cases.

Re: [PATCH] ntpd: allow to specify a source IP address for outgoing queries

2017-05-29 Thread Henning Brauer
* Sebastian Benoit [2017-05-28 22:52]: > which makes me think: > would a global local-address be good enough? I think so. This is a kinda weird/rare case. -- Henning Brauer, h...@bsws.de, henn...@openbsd.org BS Web Services GmbH, http://bsws.de, Full-Service ISP Secure Hosting, Mail and DNS. Vi

Re: [PATCH] ntpd: allow to specify a source IP address for outgoing queries

2017-05-28 Thread Sebastian Benoit
> "servers ntp.ring.nlnog.net \ > local-address 165.254.255.27,2001:728:1808::26" yes > > or allow one to repeat the 'local-address' keyword: > > "servers ntp.ring.nlnog.net \ > local-address 165.254.255.27 \ > local-address 2001:728:1808::26" > > or use differe

[PATCH] ntpd: allow to specify a source IP address for outgoing queries

2017-05-28 Thread Job Snijders
Dear team, I have the following use-case on some of my routers: ntpd will opportunistically select a source address, regardless of whether that source address is actually a globally routable IP address. Most of the time this is great, but not in some deployment scenarios. For instance, IP address