henkjan gersen(h.ger...@gmail.com) on 2020.11.14 19:00:15 +:
> OK, no problem it just looked strange when reading the code as most
> definitions in that file don't have them.
>
> btw) I'm by now way more puzzled why this file has a function to create a pipe
>
> struct pipe_pair
OK, no problem it just looked strange when reading the code as most
definitions in that file don't have them.
btw) I'm by now way more puzzled why this file has a function to create a pipe
struct pipe_pair *pipe_pair_create(void);
but lacks a corresponding destroy function. This makes it look
I don't see the point of this.
Yes, style(9) says don't do that. It is because of cpp issues.
It definately matters for userland-exposed definitions.
But the kernel is largely immune to this concern, even in .h files
Sice this is on one file, it matters even less since nothing in
any .h file
Patch below removes a couple of variable names from function prototypes
in sys_pipe.c to match style(9)
---
diff --git sys/kern/sys_pipe.c sys/kern/sys_pipe.c
index 04ec907d21f..85e69af7741 100644
--- sys/kern/sys_pipe.c
+++ sys/kern/sys_pipe.c
@@ -62,9 +62,9 @@ int pipe_read(struct file *,
