Re: [PATCH] ure improvement

2017-07-27 Thread sc dying
On 2017/07/27 12:22, Martin Pieuchot wrote: > On 25/07/17(Tue) 00:30, sc dying wrote: >> On 2017/07/24 14:35, Martin Pieuchot wrote: >>> [...] >>> Here's a diff to try and play with. I'd guess the problem is in >>> pipe_close(). Which state has the EP you're closing? Do we close >>> the EP corre

Re: [PATCH] ure improvement

2017-07-27 Thread Martin Pieuchot
On 25/07/17(Tue) 00:30, sc dying wrote: > On 2017/07/24 14:35, Martin Pieuchot wrote: > > [...] > > Here's a diff to try and play with. I'd guess the problem is in > > pipe_close(). Which state has the EP you're closing? Do we close > > the EP correctly? > > EP 3 is RX pipe, EP 4 is TX pipe. >

Re: [PATCH] ure improvement

2017-07-24 Thread sc dying
On 2017/07/24 14:35, Martin Pieuchot wrote: > On 21/07/17(Fri) 07:57, sc dying wrote: >> On 2017/07/20 08:31, Martin Pieuchot wrote: >>> On 18/07/17(Tue) 13:43, sc dying wrote: On 2017/07/18 09:12, Martin Pieuchot wrote: > On 17/07/17(Mon) 15:24, sc dying wrote: >> On 2017/07/17 08:24,

Re: [PATCH] ure improvement

2017-07-21 Thread sc dying
On 2017/07/20 08:31, Martin Pieuchot wrote: > On 18/07/17(Tue) 13:43, sc dying wrote: >> On 2017/07/18 09:12, Martin Pieuchot wrote: >>> On 17/07/17(Mon) 15:24, sc dying wrote: On 2017/07/17 08:24, Martin Pieuchot wrote: > On 15/07/17(Sat) 21:16, sc dying wrote: >> - Call usbd_set_conf

Re: [PATCH] ure improvement

2017-07-20 Thread Martin Pieuchot
On 18/07/17(Tue) 13:43, sc dying wrote: > On 2017/07/18 09:12, Martin Pieuchot wrote: > > On 17/07/17(Mon) 15:24, sc dying wrote: > >> On 2017/07/17 08:24, Martin Pieuchot wrote: > >>> On 15/07/17(Sat) 21:16, sc dying wrote: > - Call usbd_set_config before configuring endpoints in ure_init to

Re: [PATCH] ure improvement

2017-07-18 Thread sc dying
On 2017/07/18 09:12, Martin Pieuchot wrote: > On 17/07/17(Mon) 15:24, sc dying wrote: >> On 2017/07/17 08:24, Martin Pieuchot wrote: >>> On 15/07/17(Sat) 21:16, sc dying wrote: - Call usbd_set_config before configuring endpoints in ure_init to fix an error when re-opening pipes. I gra

Re: [PATCH] ure improvement

2017-07-18 Thread Martin Pieuchot
On 17/07/17(Mon) 15:24, sc dying wrote: > On 2017/07/17 08:24, Martin Pieuchot wrote: > > On 15/07/17(Sat) 21:16, sc dying wrote: > >> This patch does: > >> > >> - Enable RX aggregation. > > > > Does it work on all chips? > > I don't have all, but it works with mine that have RTL8152 (ver 4c10) >

Re: [PATCH] ure improvement

2017-07-17 Thread sc dying
On 2017/07/17 08:24, Martin Pieuchot wrote: > On 15/07/17(Sat) 21:16, sc dying wrote: >> Hi, >> >> This patch does: >> >> - Enable RX aggregation. > > Does it work on all chips? I don't have all, but it works with mine that have RTL8152 (ver 4c10) and RTL8153 (ver 5c20). > >> - Fix RX packet buff

Re: [PATCH] ure improvement

2017-07-17 Thread Martin Pieuchot
On 15/07/17(Sat) 21:16, sc dying wrote: > Hi, > > This patch does: > > - Enable RX aggregation. Does it work on all chips? > - Fix RX packet buffer alignment, using roundup() macro in sys/params.h. Why is that needed? pktlen should already be aligned, no? > - Call usbd_set_config before conf

[PATCH] ure improvement

2017-07-15 Thread sc dying
Hi, This patch does: - Enable RX aggregation. - Fix RX packet buffer alignment, using roundup() macro in sys/params.h. - Call usbd_set_config before configuring endpoints in ure_init to fix an error when re-opening pipes. I grabbed the code from if_kue.c. - Make the chip recognize given MAC a