Re: [PATCH 1/3] openbgpd: Allow localpref of zero

[Peter Hessler]

OK

On 2017 Jun 23 (Fri) at 16:01:16 +0200 (+0200), Job Snijders wrote:
:Dear team,
:
:The lowest valid BGP LOCAL_PREF is 0, allowing bgpd to set 0 too will
:accomodate interopability.
:
:Kind regards,
:
:Job
:
:--- a/usr.sbin/bgpd/parse.y
:+++ b/usr.sbin/bgpd/parse.y
:@@ -1988,7 +1988,7 @@ filter_set_opt   : LOCALPREF NUMBER  {
:   }
:   if (($$ = calloc(1, sizeof(struct filter_set))) == NULL)
:   fatal(NULL);
:-  if ($2 > 0) {
:+  if ($2 >= 0) {
:   $$->type = ACTION_SET_LOCALPREF;
:   $$->action.metric = $2;
:   } else {
:

-- 
"A radioactive cat has eighteen half-lives."

[PATCH 1/3] openbgpd: Allow localpref of zero

[Job Snijders]

Dear team,

The lowest valid BGP LOCAL_PREF is 0, allowing bgpd to set 0 too will
accomodate interopability.

Kind regards,

Job

--- a/usr.sbin/bgpd/parse.y
+++ b/usr.sbin/bgpd/parse.y
@@ -1988,7 +1988,7 @@ filter_set_opt: LOCALPREF NUMBER  {
}
if (($$ = calloc(1, sizeof(struct filter_set))) == NULL)
fatal(NULL);
-   if ($2 > 0) {
+   if ($2 >= 0) {
$$->type = ACTION_SET_LOCALPREF;
$$->action.metric = $2;
} else {