Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-14 Thread Stefan Fritsch
On Monday 13 August 2012 17:00:56 Mike Belopuhov wrote: you're calling MCLGETI and provide an interface pointer but you forget to set watermarks via m_clsetwms. OK. The MCLGETI man page should probably get a pointer to m_clsetwms(). -- genua Gesellschaft fuer Netzwerk- und Unix-Administration

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-14 Thread Bryan Venteicher
Hi, - Original Message - From: Mark Kettenis mark.kette...@xs4all.nl To: Stefan Fritsch stefan_frit...@genua.de Cc: tech@openbsd.org Sent: Monday, August 13, 2012 2:20:50 PM Subject: Re: [Patch] Virtio drivers for OpenBSD V5 From: Stefan Fritsch stefan_frit...@genua.de Date

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 4:24 PM, Stefan Fritsch stefan_frit...@genua.de wrote: - virtio: use lfence/sfence because __sync_synchronize() is broken on gcc 4.4 please don't. use bus_space_barrier.

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 4:24 PM, Stefan Fritsch stefan_frit...@genua.de wrote: Hi, here is the next iteration of my patch. Changes from V4 include: - virtio: support RING_EVENT_IDX - virtio: use lfence/sfence because __sync_synchronize() is broken on gcc 4.4 - net:

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Stefan Fritsch
On Monday 13 August 2012 17:07:41 you wrote:  * Note: the i386 does not currently require barriers, but we must  * provide the flags to MI code. This is not correct for virtio. We need a memory barrier. sure, copy it from amd64. OK. A slight complication: sfence/mfence/lfence do not

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 5:30 PM, Stefan Fritsch stefan_frit...@genua.de wrote: On Monday 13 August 2012 17:07:41 you wrote: * Note: the i386 does not currently require barriers, but we must * provide the flags to MI code. This is not correct for virtio. We need a memory barrier. sure,

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 5:36 PM, Mike Belopuhov m...@crypt.org.ru wrote: On Mon, Aug 13, 2012 at 5:30 PM, Stefan Fritsch stefan_frit...@genua.de wrote: On Monday 13 August 2012 17:07:41 you wrote: * Note: the i386 does not currently require barriers, but we must * provide the flags to MI

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mike Belopuhov
On Mon, Aug 13, 2012 at 5:41 PM, Mike Belopuhov m...@crypt.org.ru wrote: On Mon, Aug 13, 2012 at 5:36 PM, Mike Belopuhov m...@crypt.org.ru wrote: On Mon, Aug 13, 2012 at 5:30 PM, Stefan Fritsch stefan_frit...@genua.de wrote: On Monday 13 August 2012 17:07:41 you wrote: * Note: the i386

Re: [Patch] Virtio drivers for OpenBSD V5

2012-08-13 Thread Mark Kettenis
From: Stefan Fritsch stefan_frit...@genua.de Date: Mon, 13 Aug 2012 16:24:15 +0200 Hi, here is the next iteration of my patch. Changes from V4 include: - virtio: support RING_EVENT_IDX - virtio: use lfence/sfence because __sync_synchronize() is broken on gcc 4.4