Re: [libcrypto] Don't build empty ecp_nistp* objects

2017-07-17 Thread Kinichiro Inoguchi
Absolutely.

ok inoguchi@

On Mon, Jul 17, 2017 at 06:26:30AM -0500, Brent Cook wrote:
> OPENSSL_NO_EC_NISTP_64_GCC_128 has been defined in opensslfeatures.h for a
> long time, which effectively means that ecp_nistp* are all empty files. So,
> there is no reason to build them in the first place. OK?
> 
> Index: Makefile
> ===
> RCS file: /cvs/src/lib/libcrypto/Makefile,v
> retrieving revision 1.20
> diff -u -p -u -p -r1.20 Makefile
> --- Makefile10 Jul 2017 21:30:37 -  1.20
> +++ Makefile17 Jul 2017 11:21:23 -
> @@ -126,7 +126,6 @@ SRCS+= dso_openssl.c
>  SRCS+= ec_lib.c ecp_smpl.c ecp_mont.c ecp_nist.c ec_cvt.c ec_mult.c
>  SRCS+= ec_err.c ec_curve.c ec_check.c ec_print.c ec_asn1.c ec_key.c
>  SRCS+= ec2_smpl.c ec2_mult.c ec_ameth.c ec_pmeth.c eck_prn.c
> -SRCS+= ecp_nistp224.c ecp_nistp256.c ecp_nistp521.c ecp_nistputil.c
>  SRCS+= ecp_oct.c ec2_oct.c ec_oct.c
> 
>  # ecdh/



[libcrypto] Don't build empty ecp_nistp* objects

2017-07-17 Thread Brent Cook
OPENSSL_NO_EC_NISTP_64_GCC_128 has been defined in opensslfeatures.h for a
long time, which effectively means that ecp_nistp* are all empty files. So,
there is no reason to build them in the first place. OK?

Index: Makefile
===
RCS file: /cvs/src/lib/libcrypto/Makefile,v
retrieving revision 1.20
diff -u -p -u -p -r1.20 Makefile
--- Makefile10 Jul 2017 21:30:37 -  1.20
+++ Makefile17 Jul 2017 11:21:23 -
@@ -126,7 +126,6 @@ SRCS+= dso_openssl.c
 SRCS+= ec_lib.c ecp_smpl.c ecp_mont.c ecp_nist.c ec_cvt.c ec_mult.c
 SRCS+= ec_err.c ec_curve.c ec_check.c ec_print.c ec_asn1.c ec_key.c
 SRCS+= ec2_smpl.c ec2_mult.c ec_ameth.c ec_pmeth.c eck_prn.c
-SRCS+= ecp_nistp224.c ecp_nistp256.c ecp_nistp521.c ecp_nistputil.c
 SRCS+= ecp_oct.c ec2_oct.c ec_oct.c

 # ecdh/