>> - activate stack protector
>
> Hm? Changing the exit to a return does this?
yes, stack protector only works if the function returns.
frit...@alokat.org wrote:
> Hi tech@,
>
> here are some basename(1) tweaks:
> - remove (void) cast for puts(3) and fprintf(3)
We typically leave these. I agree that they're usually pointless visual
distractions in 2015 because there are a set of functions (mostly
blocking IO functions to stdout
Hi tech@,
here are some basename(1) tweaks:
- remove (void) cast for puts(3) and fprintf(3)
- activate stack protector
- put includes in correct order
--F.
Index: basename.c
===
RCS file: /cvs/src/usr.bin/basename/basename.c,v
Theo de Raadt wrote:
> I don't know if I am alone in this -- I am getting a bit tired of
> changes which are can be summarized as: "fighting someone else's
> style".
>
> I do not really see the value in changes of this sort.
Agreed. I ordered the includes, but the void casts should just stay.
>Theo de Raadt wrote:
>> I don't know if I am alone in this -- I am getting a bit tired of
>> changes which are can be summarized as: "fighting someone else's
>> style".
>>
>> I do not really see the value in changes of this sort.
>
>Agreed. I ordered the includes, but the void casts should just
I don't know if I am alone in this -- I am getting a bit tired of
changes which are can be summarized as: "fighting someone else's style".
I do not really see the value in changes of this sort.
>frit...@alokat.org wrote:
>> Hi tech@,
>>
>> here are some basename(1) tweaks:
>> - remove (void)
