2016-01-23 14:08 GMT+03:00 Theo Buehler :
> On Sat, Jan 23, 2016 at 11:03:39AM +0100, Martijn van Duren wrote:
>> Here's a small update:
>> On 01/22/16 21:18, Martijn van Duren wrote:
>> >3) 3_vi_remove_progname.diff: Don't keep a copy of the progname in
>> >memory, use getprogname instead.
>> Atta
On Sat, Jan 23, 2016 at 11:03:39AM +0100, Martijn van Duren wrote:
> Here's a small update:
> On 01/22/16 21:18, Martijn van Duren wrote:
> >3) 3_vi_remove_progname.diff: Don't keep a copy of the progname in
> >memory, use getprogname instead.
> Attached without the setprogname. The reason I includ
Here's a small update:
On 01/22/16 21:18, Martijn van Duren wrote:
3) 3_vi_remove_progname.diff: Don't keep a copy of the progname in
memory, use getprogname instead.
Attached without the setprogname. The reason I included setprogname was
because getprogname in the manpage doesn't mention that i
On Sat, Jan 23, 2016 at 01:45:05AM -0500, Michael McConville wrote:
> Vadim Zhukov wrote:
> > 2016-01-22 23:18 GMT+03:00 Martijn van Duren
> > :
> > > 5) 5_vi_remove_v_strdup.diff: Use strdup instead of v_strdup.
> >
> > Not okay: MALLOC macro prints information message to user, while
> > patched
Vadim Zhukov wrote:
> 2016-01-22 23:18 GMT+03:00 Martijn van Duren
> :
> > 5) 5_vi_remove_v_strdup.diff: Use strdup instead of v_strdup.
>
> Not okay: MALLOC macro prints information message to user, while
> patched version isn't. I think refactoring shouldn't have such visible
> impact on functi
from part 3:
> diff --git cl/cl_main.c cl/cl_main.c
> index ed4abda..cc48ad3 100644
> --- cl/cl_main.c
> +++ cl/cl_main.c
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> #include
> @@ -36,7 +37,7 @@ sigset_t __sigblockset;
2016-01-22 23:18 GMT+03:00 Martijn van Duren :
> Hello tech@,
>
> Attached are 6 patches to do some initial cleanup in vi (these complement
> the perr patch that got comitted earlier). They are intended to be applied
> in sequential order, because there may be slight overlap, but they (almost)
> al
Hello tech@,
Attached are 6 patches to do some initial cleanup in vi (these
complement the perr patch that got comitted earlier). They are intended
to be applied in sequential order, because there may be slight overlap,
but they (almost) all do more or less the same thing: Remove custom code