Re: [patch] httpd: don't add date header if already set

2017-07-31 Thread Ian Sutton
committed, thanks

Re: [patch] httpd: don't add date header if already set

2017-07-31 Thread Florian Obser
On Sun, Jul 30, 2017 at 09:43:09PM -0400, Ted Unangst wrote: > Florian Obser wrote: > > OK florian@ > > > > p.s. whoever commits this please add extra ( ) around the && term, > > Apparently clang no longer supports operator precedence *sigh*. > > > > I'm wondering if it also warns for a * b + c

Re: [patch] httpd: don't add date header if already set

2017-07-30 Thread Ted Unangst
Florian Obser wrote: > OK florian@ > > p.s. whoever commits this please add extra ( ) around the && term, > Apparently clang no longer supports operator precedence *sigh*. > > I'm wondering if it also warns for a * b + c > > /usr/src/usr.sbin/httpd/server_fcgi.c:665:56: warning: '&&' within

Re: [patch] httpd: don't add date header if already set

2017-07-30 Thread Florian Obser
OK florian@ p.s. whoever commits this please add extra ( ) around the && term, Apparently clang no longer supports operator precedence *sigh*. I'm wondering if it also warns for a * b + c /usr/src/usr.sbin/httpd/server_fcgi.c:665:56: warning: '&&' within '||' [-Wlogical-op-parentheses]

Re: [patch] httpd: don't add date header if already set

2017-07-29 Thread Nick Owens
ping? On Jul 18, 2017 19:01, "Nick Owens" wrote: hello tech@, here is a diff that will cause httpd's fcgi code to not set the HTTP date header if it has already been set. the code i am using for an fcgi server

[patch] httpd: don't add date header if already set

2017-07-18 Thread Nick Owens
hello tech@, here is a diff that will cause httpd's fcgi code to not set the HTTP date header if it has already been set. the code i am using for an fcgi server (https://github.com/golang/go/blob/master/src/net/http/fcgi/child.go#L102) unconditionally sets the Date header, so with httpd there