Re: [patch] kern/exec_script: return error when the shell name is not specified

> Date: Fri, 5 Feb 2016 13:06:56 -0500 > From: Michael McConville > > Michael McConville wrote: > > Michael McConville wrote: > > > Maxim Pugachev wrote: > > > > In a case when the shell name is not specified (i.e. just "#!" without > > > > a path), don't run the heavy logic

Re: [patch] kern/exec_script: return error when the shell name is not specified

I think that 'cp += shellarglen + 1;' is a dead store. The 'cp' variable is not used anymore after that line. Either way your diff reads fine to me! natano > Index: sys/kern/exec_script.c > === > RCS file:

Re: [patch] kern/exec_script: return error when the shell name is not specified

Mark Kettenis wrote: > > Date: Fri, 5 Feb 2016 13:06:56 -0500 > > From: Michael McConville > > > > Michael McConville wrote: > > > Michael McConville wrote: > > > > Maxim Pugachev wrote: > > > > > In a case when the shell name is not specified (i.e. just "#!" without > > > > >

Re: [patch] kern/exec_script: return error when the shell name is not specified

Michael McConville wrote: > Maxim Pugachev wrote: > > In a case when the shell name is not specified (i.e. just "#!" without > > a path), don't run the heavy logic that checks shell, simply return > > ENOENT. > > I'm not sure whether this is a reasonable thing to do. Someone with more > kernel

Re: [patch] kern/exec_script: return error when the shell name is not specified

Maxim Pugachev wrote: > In a case when the shell name is not specified (i.e. just "#!" without > a path), don't run the heavy logic that checks shell, simply return > ENOENT. I'm not sure whether this is a reasonable thing to do. Someone with more kernel API experience will have to comment. >

Re: [patch] kern/exec_script: return error when the shell name is not specified

Ping? On Thu, Dec 17, 2015 at 8:18 PM, Ted Unangst wrote: > Maxim Pugachev wrote: >> Ping? >> >> On Sun, Dec 13, 2015 at 12:28 AM, Maxim Pugachev >> wrote: >> > Hi, >> > >> > In a case when the shell name is not specified (i.e. just "#!" without >> >

Re: [patch] kern/exec_script: return error when the shell name is not specified

Maxim Pugachev wrote: > Ping? > > On Sun, Dec 13, 2015 at 12:28 AM, Maxim Pugachev > wrote: > > Hi, > > > > In a case when the shell name is not specified (i.e. just "#!" without > > a path), don't run the heavy logic that checks shell, simply return > > ENOENT. > > > >

[patch] kern/exec_script: return error when the shell name is not specified

Hi, In a case when the shell name is not specified (i.e. just "#!" without a path), don't run the heavy logic that checks shell, simply return ENOENT. Also, as a tiny improvement: avoid a loop when calculating shell's args length. Index: sys/kern/exec_script.c