Re: [patch] mandoc: Remove argument names from function prototypes

[Martin Vahlensieck]

Hi Ingo

On Fri, Apr 03, 2020 at 01:55:56PM +0200, Ingo Schwarze wrote:
> Hi Martin,
> 
> Martin Vahlensieck wrote on Thu, Apr 02, 2020 at 10:57:04AM +0200:
> 
> > I think these are superfluous.
> 
> Correct, and it is irritating to have a general style of not using
> argument names in prototypes in mandoc, but then a few scattered
> names here and there, so i committed your patch.
> Thanks for sending it.
> 
> In the future, when sending patches, could you please restore your
> last name to the From: header?  I consider it disrespectful forcing
> developers who want to commit your patches to waste time on the
> extra, useless work of searching for your name.
I meant no disrespect. Thanks for pointing it out. Fixed.
> For an extremely simple, probably not Copyright-worthy patch like
> this one, it may not matter much, but as soon as you send a patch
> that (even potentially) might meet the threshold of originality
> with respect to Copyright, it becomes important that the developer
> committing the patch mentions the full real name of the person who
> sent in the patch in the commit message, such that it is clear who
> owns the Copyright on the changes and, by implication, who the
> person is putting these changes under the license displayed at the
> top of the file.
> 
> Thanks,
>   Ingo
> 

Best,

Martin

Re: [patch] mandoc: Remove argument names from function prototypes

[Ingo Schwarze]

Hi Martin,

Martin Vahlensieck wrote on Thu, Apr 02, 2020 at 10:57:04AM +0200:

> I think these are superfluous.

Correct, and it is irritating to have a general style of not using
argument names in prototypes in mandoc, but then a few scattered
names here and there, so i committed your patch.
Thanks for sending it.

In the future, when sending patches, could you please restore your
last name to the From: header?  I consider it disrespectful forcing
developers who want to commit your patches to waste time on the
extra, useless work of searching for your name.

For an extremely simple, probably not Copyright-worthy patch like
this one, it may not matter much, but as soon as you send a patch
that (even potentially) might meet the threshold of originality
with respect to Copyright, it becomes important that the developer
committing the patch mentions the full real name of the person who
sent in the patch in the commit message, such that it is clear who
owns the Copyright on the changes and, by implication, who the
person is putting these changes under the license displayed at the
top of the file.

Thanks,
  Ingo

[patch] mandoc: Remove argument names from function prototypes

[Martin]

Hi there!

I think these are superfluous.

Best,

Martin

Index: cgi.c
===
RCS file: /cvs/src/usr.bin/mandoc/cgi.c,v
retrieving revision 1.109
diff -u -p -r1.109 cgi.c
--- cgi.c   10 Jan 2020 15:20:49 -  1.109
+++ cgi.c   2 Apr 2020 08:54:45 -
@@ -66,9 +66,9 @@ enum  focus {
 static void html_print(const char *);
 static void html_putchar(char);
 static int  http_decode(char *);
-static void http_encode(const char *p);
+static void http_encode(const char *);
 static void parse_manpath_conf(struct req *);
-static void parse_path_info(struct req *req, const char *path);
+static void parse_path_info(struct req *, const char *);
 static void parse_query_string(struct req *, const char *);
 static void pg_error_badrequest(const char *);
 static void pg_error_internal(void);
Index: libmandoc.h
===
RCS file: /cvs/src/usr.bin/mandoc/libmandoc.h,v
retrieving revision 1.63
diff -u -p -r1.63 libmandoc.h
--- libmandoc.h 19 Jan 2020 16:16:32 -  1.63
+++ libmandoc.h 2 Apr 2020 08:54:45 -
@@ -73,7 +73,7 @@ void   roff_man_reset(struct roff_man *)
 int roff_parseln(struct roff *, int, struct buf *, int *);
 voidroff_userret(struct roff *);
 voidroff_endparse(struct roff *);
-voidroff_setreg(struct roff *, const char *, int, char sign);
+voidroff_setreg(struct roff *, const char *, int, char);
 int roff_getreg(struct roff *, const char *);
 char   *roff_strdup(const struct roff *, const char *);
 char   *roff_getarg(struct roff *, char **, int, int *);
Index: mandoc.h
===
RCS file: /cvs/src/usr.bin/mandoc/mandoc.h,v
retrieving revision 1.208
diff -u -p -r1.208 mandoc.h
--- mandoc.h19 Jan 2020 17:59:01 -  1.208
+++ mandoc.h2 Apr 2020 08:54:45 -
@@ -299,7 +299,7 @@ enummandoc_esc {
 };
 
 
-enum mandoc_esc  mandoc_font(const char *, int sz);
+enum mandoc_esc  mandoc_font(const char *, int);
 enum mandoc_esc  mandoc_escape(const char **, const char **, int *);
 void mandoc_msg_setoutfile(FILE *);
 const char  *mandoc_msg_getinfilename(void);
Index: mandocdb.c
===
RCS file: /cvs/src/usr.bin/mandoc/mandocdb.c,v
retrieving revision 1.215
diff -u -p -r1.215 mandocdb.c
--- mandocdb.c  26 Jan 2020 21:24:58 -  1.215
+++ mandocdb.c  2 Apr 2020 08:54:45 -
@@ -107,7 +107,7 @@ struct  mdoc_handler {
 int mandocdb(int, char *[]);
 
 static void dbadd(struct dba *, struct mpage *);
-static void dbadd_mlink(const struct mlink *mlink);
+static void dbadd_mlink(const struct mlink *);
 static void dbprune(struct dba *);
 static void dbwrite(struct dba *);
 static void filescan(const char *);
Index: mdoc_markdown.c
===
RCS file: /cvs/src/usr.bin/mandoc/mdoc_markdown.c,v
retrieving revision 1.34
diff -u -p -r1.34 mdoc_markdown.c
--- mdoc_markdown.c 27 Feb 2020 01:25:57 -  1.34
+++ mdoc_markdown.c 2 Apr 2020 08:54:45 -
@@ -29,16 +29,16 @@
 #include "main.h"
 
 struct md_act {
-   int (*cond)(struct roff_node *n);
-   int (*pre)(struct roff_node *n);
-   void(*post)(struct roff_node *n);
+   int (*cond)(struct roff_node *);
+   int (*pre)(struct roff_node *);
+   void(*post)(struct roff_node *);
const char   *prefix; /* pre-node string constant */
const char   *suffix; /* post-node string constant */
 };
 
 static void md_nodelist(struct roff_node *);
 static void md_node(struct roff_node *);
-static const char *md_stack(char c);
+static const char *md_stack(char);
 static void md_preword(void);
 static void md_rawword(const char *);
 static void md_word(const char *);
Index: out.h
===
RCS file: /cvs/src/usr.bin/mandoc/out.h,v
retrieving revision 1.24
diff -u -p -r1.24 out.h
--- out.h   18 Aug 2018 20:17:58 -  1.24
+++ out.h   2 Apr 2020 08:54:45 -
@@ -64,5 +64,5 @@ structrofftbl {
 struct tbl_span;
 
 const char  *a2roffsu(const char *, struct roffsu *, enum roffscale);
-void tblcalc(struct rofftbl *tbl,
+void tblcalc(struct rofftbl *,
const struct tbl_span *, size_t, size_t);
Index: roff.c
===
RCS file: /cvs/src/usr.bin/mandoc/roff.c,v
retrieving revision 1.243
diff -u -p -r1.243 roff.c
---