Re: [patch] rebound: add NULL pointer checks

2018-09-10 Thread Ted Unangst
Anton Lindqvist wrote: > > > > Since it's a daemon I guess it makes sense to continue execution instead > > > > of dying. However, we should make sure to not leak memory along the > > > > error paths. Also, log something when preloading the cache fails. > > Committed, I settled on using goto.

Re: [patch] rebound: add NULL pointer checks

2018-09-08 Thread Anton Lindqvist
On Sat, Sep 08, 2018 at 11:48:35AM +0200, Clemens Goessnitzer wrote: > > > On 08/09/18 11:40, Theo Buehler wrote: > > On Sat, Sep 08, 2018 at 11:07:30AM +0200, Anton Lindqvist wrote: > > > On Fri, Sep 07, 2018 at 09:22:33PM +0200, Theo Buehler wrote: > > > > On Fri, Sep 07, 2018 at 09:15:30PM

Re: [patch] rebound: add NULL pointer checks

2018-09-08 Thread Clemens Goessnitzer
On 08/09/18 11:40, Theo Buehler wrote: On Sat, Sep 08, 2018 at 11:07:30AM +0200, Anton Lindqvist wrote: On Fri, Sep 07, 2018 at 09:22:33PM +0200, Theo Buehler wrote: On Fri, Sep 07, 2018 at 09:15:30PM +0200, Clemens Goessnitzer wrote: This patch adds 2 missing NULL pointer checks to

Re: [patch] rebound: add NULL pointer checks

2018-09-08 Thread Theo Buehler
On Sat, Sep 08, 2018 at 11:07:30AM +0200, Anton Lindqvist wrote: > On Fri, Sep 07, 2018 at 09:22:33PM +0200, Theo Buehler wrote: > > On Fri, Sep 07, 2018 at 09:15:30PM +0200, Clemens Goessnitzer wrote: > > > This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). > > > > The

Re: [patch] rebound: add NULL pointer checks

2018-09-08 Thread Anton Lindqvist
On Fri, Sep 07, 2018 at 09:22:33PM +0200, Theo Buehler wrote: > On Fri, Sep 07, 2018 at 09:15:30PM +0200, Clemens Goessnitzer wrote: > > This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). > > The same function also contains an unchecked calloc. Since it's a daemon I guess

Re: [patch] rebound: add NULL pointer checks

2018-09-07 Thread Clemens Goessnitzer
On 07/09/18 21:15, Clemens Goessnitzer wrote: This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). Clemens Updated patch to also check the return of calloc() Clemens Index: rebound.c === RCS file:

Re: [patch] rebound: add NULL pointer checks

2018-09-07 Thread Theo Buehler
On Fri, Sep 07, 2018 at 09:15:30PM +0200, Clemens Goessnitzer wrote: > This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). The same function also contains an unchecked calloc. > Index: rebound.c > === > RCS

[patch] rebound: add NULL pointer checks

2018-09-07 Thread Clemens Goessnitzer
This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). Clemens Index: rebound.c === RCS file: /cvs/src/usr.sbin/rebound/rebound.c,v retrieving revision 1.98 diff -u -p -r1.98 rebound.c --- rebound.c 1 May 2018