Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

Hiltjo Posthuma(hil...@codemadness.org) on 2019.06.21 13:32:10 +0200: > On Wed, Jun 12, 2019 at 06:58:31PM +0200, Hiltjo Posthuma wrote: > > On Thu, Jun 06, 2019 at 02:14:05PM +0200, Christian Weisgerber wrote: > > > Bj??rn Ketelaars: > > > > > > > Diff below is based on the latest diff from naddy

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

On Wed, Jun 12, 2019 at 06:58:31PM +0200, Hiltjo Posthuma wrote: > On Thu, Jun 06, 2019 at 02:14:05PM +0200, Christian Weisgerber wrote: > > Björn Ketelaars: > > > > > Diff below is based on the latest diff from naddy@. Changes: > > > - reallocarray likes type_t, as such changes type of nxdev and

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

On Thu, Jun 06, 2019 at 02:14:05PM +0200, Christian Weisgerber wrote: > Björn Ketelaars: > > > Diff below is based on the latest diff from naddy@. Changes: > > - reallocarray likes type_t, as such changes type of nxdev and i; > > - use reallocarray instead of malloc as xdev is initialised as NULL.

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

Björn Ketelaars: > Diff below is based on the latest diff from naddy@. Changes: > - reallocarray likes type_t, as such changes type of nxdev and i; > - use reallocarray instead of malloc as xdev is initialised as NULL. ok naddy@ -- Christian "naddy" Weisgerber na...@mip

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

On Thu 06/06/2019 00:37, Christian Weisgerber wrote: > Christian Weisgerber: > > > > To reproduce: > > > > > > mkdir -p /tmp/test /tmp/plop > > > openrsync -rx /tmp/test/ /tmp/plop/ > > > > > > Result: > > > > > > openrsync(3470) in free(): bogus pointer (double free?) 0x7f7dcdc8 > >

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

OK On Thu, Jun 06, 2019 at 12:37:13AM +0200, Christian Weisgerber wrote: > Christian Weisgerber: > > > > To reproduce: > > > > > > mkdir -p /tmp/test /tmp/plop > > > openrsync -rx /tmp/test/ /tmp/plop/ > > > > > > Result: > > > > > > openrsync(3470) in free(): bogus pointer (double free?

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

On Thu, Jun 06, 2019 at 12:37:13AM +0200, Christian Weisgerber wrote: > Christian Weisgerber: > > > > To reproduce: > > > > > > mkdir -p /tmp/test /tmp/plop > > > openrsync -rx /tmp/test/ /tmp/plop/ > > > > > > Result: > > > > > > openrsync(3470) in free(): bogus pointer (double free?) 0x

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

Christian Weisgerber: > > To reproduce: > > > > mkdir -p /tmp/test /tmp/plop > > openrsync -rx /tmp/test/ /tmp/plop/ > > > > Result: > > > > openrsync(3470) in free(): bogus pointer (double free?) 0x7f7dcdc8 > > Abort trap (core dumped) > > > > The patch below fixes it and

Re: [patch] rsync: fix free() on uninitialized pointer with -rx and same device

Hiltjo Posthuma: > I noticed a free() issue on an uninitialized pointer on a certain condition. > > To reproduce: > > mkdir -p /tmp/test /tmp/plop > openrsync -rx /tmp/test/ /tmp/plop/ > > Result: > > openrsync(3470) in free(): bogus pointer (double free?) 0x7f7dcdc8 >

[patch] rsync: fix free() on uninitialized pointer with -rx and same device

Hi, I noticed a free() issue on an uninitialized pointer on a certain condition. To reproduce: mkdir -p /tmp/test /tmp/plop openrsync -rx /tmp/test/ /tmp/plop/ Result: openrsync(3470) in free(): bogus pointer (double free?) 0x7f7dcdc8 Abort trap (core dumped