Re: [patch] ssh: null pointer dereference

2010-04-10 Thread Damien Miller
On Sat, 27 Mar 2010, Matthew Haub wrote: Hello, If channel_by_id() in mux_master_control_cleanup_cb() fails to find the session channel then pointer sc will be NULL when dereferenced. Applied - thanks. This case shouldn't happen, if you are able to hit this code then please tell me how you

Re: [patch] ssh: null pointer dereference

2010-04-10 Thread Matthew Haub
Hello, On Sat, Apr 10, 2010 at 03:49:07PM +1000, Damien Miller wrote: Applied - thanks. This case shouldn't happen, if you are able to hit this code then please tell me how you do it :| I haven't hit this code, it was just something suspicious that I found. I've been looking for bugs to fix

[patch] ssh: null pointer dereference

2010-03-27 Thread Matthew Haub
Hello, If channel_by_id() in mux_master_control_cleanup_cb() fails to find the session channel then pointer sc will be NULL when dereferenced. Index: usr.bin/ssh/mux.c === RCS file: /cvs/src/usr.bin/ssh/mux.c,v retrieving revision