Re: [patch] tcpdump - better BGP UPDATE AS_PATH size calculations

2015-10-29 Thread Kevin Reay
On Tue, Oct 27, 2015 at 12:59:20AM -0600, Kevin Reay wrote: > I did add an additional check for "zero" ASNs to the 2-byte default, > inspired by a quick glance at Wireshark's heuristics. I now flip > through each segment's ASNs inside of bgp_attr_get_as_size(), looking > for any zero-value 16bit

Re: [patch] tcpdump - better BGP UPDATE AS_PATH size calculations

2015-10-25 Thread Claudio Jeker
On Sat, Oct 24, 2015 at 12:37:44PM -0600, Kevin Reay wrote: > Adopt an updated version of the tcpdump.org ASN size calculation for > BGP UPDATE message AS_PATHs. This corrects some bad behaviour due to > incorrect ASN size calculations. > > I believe that the current way of calculating the ASN

[patch] tcpdump - better BGP UPDATE AS_PATH size calculations

2015-10-24 Thread Kevin Reay
Adopt an updated version of the tcpdump.org ASN size calculation for BGP UPDATE message AS_PATHs. This corrects some bad behaviour due to incorrect ASN size calculations. I believe that the current way of calculating the ASN size for an UPDATE AS_PATH attribute is flawed. Currently, the ASN