Re: [patch] telnet: stored value never read

[Michael McConville]

frit...@alokat.org wrote:
> the value stored in "old" is never read.

It's best to leave these unless there's a good reason not to. It
probably means that the programmer wanted to maintain the validity of
the variable in case we decide to use it later in the function.

> Index: sys_bsd.c
> ===
> RCS file: /cvs/src/usr.bin/telnet/sys_bsd.c,v
> retrieving revision 1.31
> diff -u -r1.31 sys_bsd.c
> --- sys_bsd.c 29 Nov 2015 14:18:40 -  1.31
> +++ sys_bsd.c 6 Mar 2016 20:36:11 -
> @@ -272,7 +272,6 @@
>   } while (old < 0 || old > 1);
>  }
>  
> -old = prevmode;
>  prevmode = f&~MODE_FORCE;
>  tmp_tc = new_tc;
>  
> 

[patch] telnet: stored value never read

[fritjof]

Hi tech@,

the value stored in "old" is never read.

--F.


Index: sys_bsd.c
===
RCS file: /cvs/src/usr.bin/telnet/sys_bsd.c,v
retrieving revision 1.31
diff -u -r1.31 sys_bsd.c
--- sys_bsd.c   29 Nov 2015 14:18:40 -  1.31
+++ sys_bsd.c   6 Mar 2016 20:36:11 -
@@ -272,7 +272,6 @@
} while (old < 0 || old > 1);
 }
 
-old = prevmode;
 prevmode = f&~MODE_FORCE;
 tmp_tc = new_tc;