Re: [patch]diff: uninitialized values

2015-11-08 Thread Fritjof Bornebusch
On Wed, Jun 17, 2015 at 09:19:28PM +0200, Fritjof Bornebusch wrote: > On Wed, Jun 17, 2015 at 08:53:57PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. > > > > Such initializers hiding a false positive, cause the

Re: [patch]diff: uninitialized values

2015-09-18 Thread Fritjof Bornebusch
On Wed, Jun 17, 2015 at 09:19:28PM +0200, Fritjof Bornebusch wrote: > On Wed, Jun 17, 2015 at 08:53:57PM +0200, Fritjof Bornebusch wrote: > > Hi tech@, > > > > *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. > > > > Such initializers hiding a false positive, cause the

Re: [patch]diff: uninitialized values

2015-06-18 Thread Todd C. Miller
On Wed, 17 Jun 2015 20:53:57 +0200, Fritjof Bornebusch wrote: *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. I don't think so. If dirp1 is non-NULL, so must edp1 be. Likewise for dirp2 and edp2. The compiler just doesn't know that scandir() does not modify its

[patch]diff: uninitialized values

2015-06-17 Thread Fritjof Bornebusch
Hi tech@, *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. Regards, --F. Index: diffdir.c === RCS file: /cvs/src/usr.bin/diff/diffdir.c,v retrieving revision 1.43 diff -u -p -r1.43 diffdir.c ---

Re: [patch]diff: uninitialized values

2015-06-17 Thread Fritjof Bornebusch
On Wed, Jun 17, 2015 at 08:53:57PM +0200, Fritjof Bornebusch wrote: Hi tech@, *edp1* and *edp2* could be used uninitialized, if *goto closem;* is called. Such initializers hiding a false positive, cause the compiler does not understand this case can never happen. - warning: 'edp1' may be