Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-17 Thread Fritjof Bornebusch
On Mon, Jun 15, 2015 at 10:22:27AM +0100, Nicholas Marriott wrote: What about diff and ssh and file? They all use the a copy of the same xmalloc.c. Personally, I would recommend that xstrdup just calls strdup(3), as Theo said: it's 100.00% portable. But I don't think I'm the right person

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-17 Thread Nicholas Marriott
On Wed, Jun 17, 2015 at 01:25:07PM +0200, Fritjof Bornebusch wrote: On Mon, Jun 15, 2015 at 10:22:27AM +0100, Nicholas Marriott wrote: What about diff and ssh and file? They all use the a copy of the same xmalloc.c. Personally, I would recommend that xstrdup just calls strdup(3), as

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-15 Thread Nicholas Marriott
What about diff and ssh and file? They all use the a copy of the same xmalloc.c. On Mon, Jun 15, 2015 at 10:00:01AM +0200, Fritjof Bornebusch wrote: Hi, thanks for the hint. This one should do the trick. Index: xmalloc.c

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-15 Thread Nicholas Marriott
On Mon, Jun 15, 2015 at 10:09:39AM +0200, Fritjof Bornebusch wrote: On Sun, Jun 14, 2015 at 05:02:05PM -0600, Theo de Raadt wrote: But I am not sure about this change. xmalloc.c came from ssh (and is also used by file and diff). Would it be better to keep it in sync? How portable is

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-15 Thread Fritjof Bornebusch
Hi, thanks for the hint. This one should do the trick. Index: xmalloc.c === RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v retrieving revision 1.9 diff -u -p -r1.9 xmalloc.c --- xmalloc.c 13 Jun 2015 20:15:21 - 1.9 +++

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-15 Thread Fritjof Bornebusch
On Sun, Jun 14, 2015 at 05:02:05PM -0600, Theo de Raadt wrote: But I am not sure about this change. xmalloc.c came from ssh (and is also used by file and diff). Would it be better to keep it in sync? How portable is strdup? strdup is extremely portable. The last mainstream operating

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-14 Thread Fritjof Bornebusch
On Wed, Jun 10, 2015 at 07:37:57PM +0200, Fritjof Bornebusch wrote: On Wed, May 20, 2015 at 10:55:34AM +0200, Fritjof Bornebusch wrote: On Tue, May 19, 2015 at 08:57:06PM +0200, Fritjof Bornebusch wrote: Hi, xstrdup just wrappes strdup, so there is no need to call xmalloc and

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-14 Thread Theo de Raadt
But I am not sure about this change. xmalloc.c came from ssh (and is also used by file and diff). Would it be better to keep it in sync? How portable is strdup? strdup is extremely portable. The last mainstream operating system which lacked it was Ultrix. So you could call it 100.00%

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-14 Thread Nicholas Marriott
Convention is usually to do err(1, strdup) with no additional text if using err rather than errx. But I am not sure about this change. xmalloc.c came from ssh (and is also used by file and diff). Would it be better to keep it in sync? How portable is strdup? On Sun, Jun 14, 2015 at 01:38:33PM

Re: [patch]rcs: xstrdup just wrappes strdup

2015-06-10 Thread Fritjof Bornebusch
On Wed, May 20, 2015 at 10:55:34AM +0200, Fritjof Bornebusch wrote: On Tue, May 19, 2015 at 08:57:06PM +0200, Fritjof Bornebusch wrote: Hi, xstrdup just wrappes strdup, so there is no need to call xmalloc and strlcpy instead. Ping Use err() instead of errx(), so errno will be

Re: [patch]rcs: xstrdup just wrappes strdup

2015-05-20 Thread Fritjof Bornebusch
On Tue, May 19, 2015 at 08:57:06PM +0200, Fritjof Bornebusch wrote: Hi, xstrdup just wrappes strdup, so there is no need to call xmalloc and strlcpy instead. Use err() instead of errx(), so errno will be printed additionally. Thanks to Tim. Regards, --F. Regards, --F. Index:

[patch]rcs: xstrdup just wrappes strdup

2015-05-19 Thread Fritjof Bornebusch
Hi, xstrdup just wrappes strdup, so there is no need to call xmalloc and strlcpy instead. Regards, --F. Index: xmalloc.c === RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v retrieving revision 1.8 diff -u -p -r1.8 xmalloc.c ---