On Fri, Feb 03, 2023 at 06:08:09PM +, Miod Vallat wrote:
> Yes and no. You are right that KASSERT is a nop on non-DIAGNOSTIC
> kernels, but there are sometimes good reasons to keep a single KASSERT
> (or a set of KASSERTs) wrapped within #ifdef DIAGNOSTIC.
...
> In this case, I would keep
> Here are a few more instances of KASSERT being placed in an #ifdef DIAGNOSTIC
> block. This is redundant, as KASSERT is already a nop if DIAGNOSTIC is not
> defined.
Yes and no. You are right that KASSERT is a nop on non-DIAGNOSTIC
kernels, but there are sometimes good reasons to keep a single
Here are a few more instances of KASSERT being placed in an #ifdef DIAGNOSTIC
block. This is redundant, as KASSERT is already a nop if DIAGNOSTIC is not
defined.
Index: crypto/blake2s.c
===
RCS file: /cvs/src/sys/crypto/blake2s.c,v
