Re: AMD 17h/1xh HD Audio testers wanted!

2023-03-07 Thread Stefan Hagen
Stefan Hagen wrote (2023-03-05 09:19 CET):
> Alexandre Ratchov wrote (2023-03-05 08:53 CET):
> > If you've an azalia(4) attaching as "AMD 17h/1xh HD Audio", please
> > test this diff and report regressions. Especially audio lock ups that
> > require reboot.
> > 
> > IIRC, MSI was disabled few years ago to "fix" such lockups, and now
> > this diff suggests we need MSI on certain boards.
> 
> At least no lockup in the first 5 minutes. I'll keep this in my tree.

It took a few days, but I hit the bug now. No lockup, but audio simply
stops and can not be reactivated until reboot.

> OpenBSD 7.2-current (GENERIC.MP) #20: Sun Mar  5 09:10:14 CET 2023
> s...@x13.home.codevoid.de:/sys/arch/amd64/compile/GENERIC.MP
> real mem = 16301219840 (15546MB)
> avail mem = 15789305856 (15057MB)
> random: good seed from bootblocks
> mpath0 at root
> scsibus0 at mpath0: 256 targets
> mainbus0 at root
> bios0 at mainbus0: SMBIOS rev. 3.2 @ 0xbf71 (68 entries)
> bios0: vendor LENOVO version "R1CET73W(1.42 )" date 12/09/2022
> bios0: LENOVO 20UGS00800
> efi0 at bios0: UEFI 2.7
> efi0: Lenovo rev 0x1360
> acpi0 at bios0: ACPI 6.3
> acpi0: sleep states S0 S3 S4 S5
> acpi0: tables DSDT FACP SSDT SSDT SSDT IVRS SSDT SSDT POAT BATB HPET APIC 
> MCFG SBST WSMT VFCT SSDT CRAT CDIT FPDT SSDT SSDT SSDT SSDT UEFI SSDT SSDT
> acpi0: wakeup devices GPP0(S3) RESA(S3) GPP4(S4) GPP5(S3) L850(S3) GPP6(S3) 
> GPP7(S3) GP17(S3) XHC0(S3) XHC1(S3) LID_(S4) SLPB(S3)
> acpitimer0 at acpi0: 3579545 Hz, 32 bits
> acpihpet0 at acpi0: 14318180 Hz
> acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
> cpu0 at mainbus0: apid 0 (boot processor)
> cpu0: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
> cpu0: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
> cpu0: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 
> 64b/line 8-way L2 cache, 4MB 64b/line 16-way L3 cache
> cpu0: smt 0, core 0, package 0
> mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
> cpu0: apic clock running at 100MHz
> cpu0: mwait min=64, max=64, C-substates=1.1, IBE
> cpu1 at mainbus0: apid 1 (application processor)
> cpu1: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
> cpu1: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
> cpu1: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 
> 64b/line 8-way L2 cache, 4MB 64b/line 16-way L3 cache
> cpu1: smt 1, core 0, package 0
> cpu2 at mainbus0: apid 2 (application processor)
> cpu2: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
> cpu2: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
> cpu2: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 
> 64b/line 8-way L2 cache, 4MB 64b/line 16-way L3 cache
> cpu2: smt 0, core 1, package 0
> cpu3 at mainbus0: apid 3 (application processor)
> cpu3: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
> cpu3: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
> cpu3: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 
> 64b/line 8-way L2 cache, 4MB 64b/line 16-way L3 cache
> cpu3: smt 1, core 1, package 0
> cpu4 at mainbus0: apid 4 (application processor)
> cpu4: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
> cpu4: 
> 

Re: AMD 17h/1xh HD Audio testers wanted!

2023-03-05 Thread Bryan Steele
On Sun, Mar 05, 2023 at 08:53:00AM +0100, Alexandre Ratchov wrote:
> If you've an azalia(4) attaching as "AMD 17h/1xh HD Audio", please
> test this diff and report regressions. Especially audio lock ups that
> require reboot.
> 
> IIRC, MSI was disabled few years ago to "fix" such lockups, and now
> this diff suggests we need MSI on certain boards.
> 
> Context and diff below:
> 
> - Forwarded message from Andreas Bartelt  -
> 
> Date: Sat, 4 Mar 2023 16:12:22 +0100
> From: Andreas Bartelt 
> To: Alexandre Ratchov , b...@openbsd.org
> Subject: Re: audio(4) output doesn't work yet on ASUS ProArt X670E-CREATOR 
> WIFI mainboard (ALC1220
>   CODEC)
> User-Agent: Mozilla/5.0 (X11; OpenBSD amd64; rv:102.0) Gecko/20100101 
> Thunderbird/102.8.0
> 
> On 2/27/23 6:41 PM, Andreas Bartelt wrote:
> > On 2/27/23 2:40 PM, Alexandre Ratchov wrote:
> > > On Sat, Feb 25, 2023 at 05:20:53PM +0100, Andreas Bartelt wrote:
> > > > Hi,
> > > > 
> > > > I've tested a recent OpenBSD snapshot of CURRENT on an ASUS ProArt
> > > > X670E-CREATOR WIFI mainboard. According to the information
> > > > provided by ASUS,
> > > > this mainboard features a "Realtek S1220A CODEC" which attaches as
> > > > Realtek
> > > > ALC1220 on OpenBSD -- however, audio output (tested with
> > > > headphones on the
> > > > line out connector) doesn't work there yet. Applications (e.g., mplayer,
> > > > mpg123) hang and I can hear no sound.
> > > > 
> > > > [I don't know if this helps but I previously also had access to an
> > > > ASUS ROG
> > > > STRIX B550-E GAMING mainboard which, according to ASUS, also features an
> > > > S1220A CODEC which also attaches as Realtek ALC1220 on OpenBSD -- audio
> > > > output (tested on the line out connector) works there without problems.]
> > > > 
> > > > In order to verify that the new mainboard doesn't have a physical defect
> > > > with regard to the line out audio connector, I've also tested a
> > > > FreeBSD 13.2
> > > > BETA3 snapshot on the ASUS ProArt X670E-CREATOR WIFI mainboard.
> > > > Audio output
> > > > worked there out-of-the-box, so this might be a fixable problem on
> > > > OpenBSD.
> > > > 
> > > > I've found some info with regard to audio debugging at
> > > > https://www.openbsd.org/faq/faq13.html#audioprob . While running
> > > > # cat > /dev/audio0 < /dev/zero
> > > > play.bytes doesn't increase at all:
> > > > # audioctl play.{bytes,errors}
> > > > play.bytes=0
> > > > play.errors=0
> > > > 
> > > 
> > > mixerctl shows that the host manages communicate with the codec, but
> > > above lines suggest that DMA doesn't start. Could you check if there
> > > are any audio-related options in the BIOS? Especially, if there's an
> > > option to disable the microphone (or "recording" or alike), please
> > > enable it.
> > 
> > There's no microphone or recording specific options available. I could
> > only identify a single audio related configuration option. Under
> > Advanced\Onboard Devices Configuration: enable/disable "HD Audio
> > Controller" (description says Enable/Disable Azalia HD Audio). It does
> > exactly that, i.e., disabling this option removes the azalia1 device from
> > OpenBSD's dmesg.
> > 
> > With this option enabled again, mp3 playback works with FreeBSD but hangs
> > with OpenBSD -- same BIOS config.
> > 
> 
> I've made audio work on the ASUS ProArt X670E-CREATOR WIFI mainboard, simply
> by enabling msi.
> 
> azalia1 at pci21 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: msi
> azalia1: codecs: Realtek ALC1220
> audio0 at azalia1
> 
> The following diff fixes the problem:
> Index: src/sys/dev/pci/azalia.c
> ===
> RCS file: /cvs/src/sys/dev/pci/azalia.c,v
> retrieving revision 1.283
> diff -u -p -r1.283 azalia.c
> --- src/sys/dev/pci/azalia.c  21 Feb 2023 13:42:59 -  1.283
> +++ src/sys/dev/pci/azalia.c  4 Mar 2023 15:02:31 -
> @@ -554,7 +554,6 @@ azalia_pci_attach(struct device *parent,
>   if (PCI_VENDOR(sc->pciid) == PCI_VENDOR_AMD) {
>   switch (PCI_PRODUCT(sc->pciid)) {
>   case PCI_PRODUCT_AMD_17_HDA:
> - case PCI_PRODUCT_AMD_17_1X_HDA:
>   case PCI_PRODUCT_AMD_HUDSON2_HDA:
>   pa->pa_flags &= ~PCI_FLAGS_MSI_ENABLED;
>   }
> 
> OK?
> 
> 
> - End forwarded message -

No, this workaround is still needed. thfr@ and I tried to debug this years
ago but could not determine the cause at the time.

This audio hang is still there on many systems, e.g: playback works for a
breif time until the it hangs, and only a reboot will fix it. But we could
never reproduce it with MSI disabled, so that was the best option we had.

-Bryan.



Re: AMD 17h/1xh HD Audio testers wanted!

2023-03-05 Thread Matthieu Herrb
On Sun, Mar 05, 2023 at 09:59:49AM +0100, Matthieu Herrb wrote:
> On Sun, Mar 05, 2023 at 08:53:00AM +0100, Alexandre Ratchov wrote:
> > If you've an azalia(4) attaching as "AMD 17h/1xh HD Audio", please
> > test this diff and report regressions. Especially audio lock ups that
> > require reboot.
> > 
> > IIRC, MSI was disabled few years ago to "fix" such lockups, and now
> > this diff suggests we need MSI on certain boards.
> > 
> > Context and diff below:
> >
> 
> Seems to work fine on my X395.
> 
> -azalia1 at pci5 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: apic 33 
> int 30
> +azalia1 at pci5 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: msi


I spoke too soon. After ~ 1hour of music playing, it did hang. No
message in dmesg, but all process trying to do audio fail to run.

-- 
Matthieu Herrb



Re: AMD 17h/1xh HD Audio testers wanted!

2023-03-05 Thread Matthieu Herrb
On Sun, Mar 05, 2023 at 08:53:00AM +0100, Alexandre Ratchov wrote:
> If you've an azalia(4) attaching as "AMD 17h/1xh HD Audio", please
> test this diff and report regressions. Especially audio lock ups that
> require reboot.
> 
> IIRC, MSI was disabled few years ago to "fix" such lockups, and now
> this diff suggests we need MSI on certain boards.
> 
> Context and diff below:
>

Seems to work fine on my X395.

-azalia1 at pci5 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: apic 33 int 
30
+azalia1 at pci5 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: msi

I'm also noticing less (or even no) glitches while playing videos with
mplayer while firefox is running. But I think those where already gone
due to other recent kernel work, not just with this patch.

Full dmesg below.:

OpenBSD 7.3-beta (GENERIC.MP) #92: Sun Mar  5 09:37:21 CET 2023
matth...@zuma.herrb.net:/usr/obj/GENERIC.MP
real mem = 14902902784 (14212MB)
avail mem = 14431854592 (13763MB)
random: good seed from bootblocks
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 3.1 @ 0xbc003000 (62 entries)
bios0: vendor LENOVO version "R13ET53W(1.27 )" date 07/28/2022
bios0: LENOVO 20NLCTO1WW
efi0 at bios0: UEFI 2.7
efi0: Lenovo rev 0x11b0
acpi0 at bios0: ACPI 5.0
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP SSDT SSDT SSDT TPM2 SSDT MSDM SLIC BATB HPET APIC MCFG 
SBST WSMT VFCT IVRS SSDT CRAT CDIT FPDT SSDT SSDT SSDT BGRT UEFI SSDT
acpi0: wakeup devices GPP0(S3) GPP1(S3) GPP2(S3) GPP3(S4) GPP4(S3) L850(S3) 
GPP5(S3) GPP6(S3) GP17(S3) XHC0(S3) XHC1(S3) GP18(S3) LID_(S3) SLPB(S3)
acpitimer0 at acpi0: 3579545 Hz, 32 bits
acpihpet0 at acpi0: 14318180 Hz
acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: AMD Ryzen 5 PRO 3500U w/ Radeon Vega Mobile Gfx, 2100.00 MHz, 17-18-01
cpu0: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,RDSEED,ADX,SMAP,CLFLUSHOPT,SHA,IBPB,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu0: 32KB 64b/line 8-way D-cache, 64KB 64b/line 4-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
cpu0: apic clock running at 25MHz
cpu0: mwait min=64, max=64, C-substates=1.1, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: AMD Ryzen 5 PRO 3500U w/ Radeon Vega Mobile Gfx, 2100.00 MHz, 17-18-01
cpu1: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,RDSEED,ADX,SMAP,CLFLUSHOPT,SHA,IBPB,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu1: 32KB 64b/line 8-way D-cache, 64KB 64b/line 4-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu1: smt 1, core 0, package 0
cpu2 at mainbus0: apid 2 (application processor)
cpu2: AMD Ryzen 5 PRO 3500U w/ Radeon Vega Mobile Gfx, 2100.00 MHz, 17-18-01
cpu2: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,RDSEED,ADX,SMAP,CLFLUSHOPT,SHA,IBPB,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu2: 32KB 64b/line 8-way D-cache, 64KB 64b/line 4-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu2: smt 0, core 1, package 0
cpu3 at mainbus0: apid 3 (application processor)
cpu3: AMD Ryzen 5 PRO 3500U w/ Radeon Vega Mobile Gfx, 2100.01 MHz, 17-18-01
cpu3: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,RDSEED,ADX,SMAP,CLFLUSHOPT,SHA,IBPB,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu3: 32KB 64b/line 8-way D-cache, 64KB 64b/line 4-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu3: smt 1, core 1, package 0
cpu4 at mainbus0: apid 4 (application processor)
cpu4: AMD Ryzen 5 PRO 3500U w/ Radeon Vega Mobile Gfx, 2100.00 MHz, 17-18-01
cpu4: 

Re: AMD 17h/1xh HD Audio testers wanted!

2023-03-05 Thread Stefan Hagen
Alexandre Ratchov wrote (2023-03-05 08:53 CET):
> If you've an azalia(4) attaching as "AMD 17h/1xh HD Audio", please
> test this diff and report regressions. Especially audio lock ups that
> require reboot.
> 
> IIRC, MSI was disabled few years ago to "fix" such lockups, and now
> this diff suggests we need MSI on certain boards.

At least no lockup in the first 5 minutes. I'll keep this in my tree.

OpenBSD 7.2-current (GENERIC.MP) #20: Sun Mar  5 09:10:14 CET 2023
s...@x13.home.codevoid.de:/sys/arch/amd64/compile/GENERIC.MP
real mem = 16301219840 (15546MB)
avail mem = 15789305856 (15057MB)
random: good seed from bootblocks
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 3.2 @ 0xbf71 (68 entries)
bios0: vendor LENOVO version "R1CET73W(1.42 )" date 12/09/2022
bios0: LENOVO 20UGS00800
efi0 at bios0: UEFI 2.7
efi0: Lenovo rev 0x1360
acpi0 at bios0: ACPI 6.3
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP SSDT SSDT SSDT IVRS SSDT SSDT POAT BATB HPET APIC MCFG 
SBST WSMT VFCT SSDT CRAT CDIT FPDT SSDT SSDT SSDT SSDT UEFI SSDT SSDT
acpi0: wakeup devices GPP0(S3) RESA(S3) GPP4(S4) GPP5(S3) L850(S3) GPP6(S3) 
GPP7(S3) GP17(S3) XHC0(S3) XHC1(S3) LID_(S4) SLPB(S3)
acpitimer0 at acpi0: 3579545 Hz, 32 bits
acpihpet0 at acpi0: 14318180 Hz
acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
cpu0: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu0: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
cpu0: apic clock running at 100MHz
cpu0: mwait min=64, max=64, C-substates=1.1, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
cpu1: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu1: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu1: smt 1, core 0, package 0
cpu2 at mainbus0: apid 2 (application processor)
cpu2: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
cpu2: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu2: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu2: smt 0, core 1, package 0
cpu3 at mainbus0: apid 3 (application processor)
cpu3: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
cpu3: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,FMA3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,RDRAND,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TCE,TOPEXT,CPCTR,DBKP,PCTRL3,MWAITX,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,PQM,RDSEED,ADX,SMAP,CLFLUSHOPT,CLWB,SHA,UMIP,IBPB,IBRS,STIBP,SSBD,XSAVEOPT,XSAVEC,XGETBV1,XSAVES
cpu3: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 64b/line 
8-way L2 cache, 4MB 64b/line 16-way L3 cache
cpu3: smt 1, core 1, package 0
cpu4 at mainbus0: apid 4 (application processor)
cpu4: AMD Ryzen 7 PRO 4750U with Radeon Graphics, 1700.00 MHz, 17-60-01
cpu4: 

AMD 17h/1xh HD Audio testers wanted!

2023-03-04 Thread Alexandre Ratchov
If you've an azalia(4) attaching as "AMD 17h/1xh HD Audio", please
test this diff and report regressions. Especially audio lock ups that
require reboot.

IIRC, MSI was disabled few years ago to "fix" such lockups, and now
this diff suggests we need MSI on certain boards.

Context and diff below:

- Forwarded message from Andreas Bartelt  -

Date: Sat, 4 Mar 2023 16:12:22 +0100
From: Andreas Bartelt 
To: Alexandre Ratchov , b...@openbsd.org
Subject: Re: audio(4) output doesn't work yet on ASUS ProArt X670E-CREATOR WIFI 
mainboard (ALC1220
CODEC)
User-Agent: Mozilla/5.0 (X11; OpenBSD amd64; rv:102.0) Gecko/20100101 
Thunderbird/102.8.0

On 2/27/23 6:41 PM, Andreas Bartelt wrote:
> On 2/27/23 2:40 PM, Alexandre Ratchov wrote:
> > On Sat, Feb 25, 2023 at 05:20:53PM +0100, Andreas Bartelt wrote:
> > > Hi,
> > > 
> > > I've tested a recent OpenBSD snapshot of CURRENT on an ASUS ProArt
> > > X670E-CREATOR WIFI mainboard. According to the information
> > > provided by ASUS,
> > > this mainboard features a "Realtek S1220A CODEC" which attaches as
> > > Realtek
> > > ALC1220 on OpenBSD -- however, audio output (tested with
> > > headphones on the
> > > line out connector) doesn't work there yet. Applications (e.g., mplayer,
> > > mpg123) hang and I can hear no sound.
> > > 
> > > [I don't know if this helps but I previously also had access to an
> > > ASUS ROG
> > > STRIX B550-E GAMING mainboard which, according to ASUS, also features an
> > > S1220A CODEC which also attaches as Realtek ALC1220 on OpenBSD -- audio
> > > output (tested on the line out connector) works there without problems.]
> > > 
> > > In order to verify that the new mainboard doesn't have a physical defect
> > > with regard to the line out audio connector, I've also tested a
> > > FreeBSD 13.2
> > > BETA3 snapshot on the ASUS ProArt X670E-CREATOR WIFI mainboard.
> > > Audio output
> > > worked there out-of-the-box, so this might be a fixable problem on
> > > OpenBSD.
> > > 
> > > I've found some info with regard to audio debugging at
> > > https://www.openbsd.org/faq/faq13.html#audioprob . While running
> > > # cat > /dev/audio0 < /dev/zero
> > > play.bytes doesn't increase at all:
> > > # audioctl play.{bytes,errors}
> > > play.bytes=0
> > > play.errors=0
> > > 
> > 
> > mixerctl shows that the host manages communicate with the codec, but
> > above lines suggest that DMA doesn't start. Could you check if there
> > are any audio-related options in the BIOS? Especially, if there's an
> > option to disable the microphone (or "recording" or alike), please
> > enable it.
> 
> There's no microphone or recording specific options available. I could
> only identify a single audio related configuration option. Under
> Advanced\Onboard Devices Configuration: enable/disable "HD Audio
> Controller" (description says Enable/Disable Azalia HD Audio). It does
> exactly that, i.e., disabling this option removes the azalia1 device from
> OpenBSD's dmesg.
> 
> With this option enabled again, mp3 playback works with FreeBSD but hangs
> with OpenBSD -- same BIOS config.
> 

I've made audio work on the ASUS ProArt X670E-CREATOR WIFI mainboard, simply
by enabling msi.

azalia1 at pci21 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: msi
azalia1: codecs: Realtek ALC1220
audio0 at azalia1

The following diff fixes the problem:
Index: src/sys/dev/pci/azalia.c
===
RCS file: /cvs/src/sys/dev/pci/azalia.c,v
retrieving revision 1.283
diff -u -p -r1.283 azalia.c
--- src/sys/dev/pci/azalia.c21 Feb 2023 13:42:59 -  1.283
+++ src/sys/dev/pci/azalia.c4 Mar 2023 15:02:31 -
@@ -554,7 +554,6 @@ azalia_pci_attach(struct device *parent,
if (PCI_VENDOR(sc->pciid) == PCI_VENDOR_AMD) {
switch (PCI_PRODUCT(sc->pciid)) {
case PCI_PRODUCT_AMD_17_HDA:
-   case PCI_PRODUCT_AMD_17_1X_HDA:
case PCI_PRODUCT_AMD_HUDSON2_HDA:
pa->pa_flags &= ~PCI_FLAGS_MSI_ENABLED;
}

OK?


- End forwarded message -