Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-16 Thread Joerg Jung
up in another thread. Trivial implementations of CLOCK_VIRTUAL and CLOCK_PROF, modeled after what FreeBSD does. out of curiousity, what program needs these? Possibly none, but we currently define CLOCK_VIRTUAL but don't actually support it. IMO we should just delete CLOCK_VIRTUAL from

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-16 Thread Todd C. Miller
On Wed, 15 Oct 2014 21:50:44 -0700, Philip Guenther wrote: IMO we should just delete CLOCK_VIRTUAL from sys/_time.h and clock_gettime(2) Easy enough. - todd Index: sys/sys/_time.h === RCS file: /home/cvs/openbsd/src/sys/sys

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-16 Thread Stuart Henderson
On 2014/10/16 07:33, Todd C. Miller wrote: On Wed, 15 Oct 2014 21:50:44 -0700, Philip Guenther wrote: IMO we should just delete CLOCK_VIRTUAL from sys/_time.h and clock_gettime(2) Easy enough. ports should be pretty much OK with this, if there's any breakage it will be minor and can

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-16 Thread Mark Kettenis
From: Todd C. Miller todd.mil...@courtesan.com Date: Thu, 16 Oct 2014 07:33:23 -0600 On Wed, 15 Oct 2014 21:50:44 -0700, Philip Guenther wrote: IMO we should just delete CLOCK_VIRTUAL from sys/_time.h and clock_gettime(2) Easy enough. ok kettenis@ Index: sys/sys/_time.h

implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Todd C. Miller
Since this came up in another thread. Trivial implementations of CLOCK_VIRTUAL and CLOCK_PROF, modeled after what FreeBSD does. - todd Index: sys/sys/_time.h === RCS file: /home/cvs/openbsd/src/sys/sys/_time.h,v retrieving

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Mark Kettenis
From: Todd C. Miller todd.mil...@courtesan.com Date: Wed, 15 Oct 2014 11:37:26 -0600 Since this came up in another thread. Trivial implementations of CLOCK_VIRTUAL and CLOCK_PROF, modeled after what FreeBSD does. Shouldn't this do a tuagg() on all the threads of the process like we do

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Mark Kettenis
Date: Wed, 15 Oct 2014 20:18:10 +0200 (CEST) From: Mark Kettenis mark.kette...@xs4all.nl From: Todd C. Miller todd.mil...@courtesan.com Date: Wed, 15 Oct 2014 11:37:26 -0600 Since this came up in another thread. Trivial implementations of CLOCK_VIRTUAL and CLOCK_PROF, modeled after

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Mark Kettenis
this came up in another thread. Trivial implementations of CLOCK_VIRTUAL and CLOCK_PROF, modeled after what FreeBSD does. Shouldn't this do a tuagg() on all the threads of the process like we do for getrusage? Otherwise the CLOCK_VIRTUAL and CLOCK_PROF clocks will only be updated upon

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Todd C. Miller
On Wed, 15 Oct 2014 20:36:33 +0200, Mark Kettenis wrote: Hmm, looking at the FreeBSD man page... isn't CLOCK_PROF the same thing as CLOCK_PROCESS_CPUTIME_ID? I was wondering that too, but I get different results as they are not calculated the same way. CLOCK_PROCESS_CPUTIME_ID always yields a

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Todd C. Miller
On Wed, 15 Oct 2014 20:18:10 +0200, Mark Kettenis wrote: Shouldn't this do a tuagg() on all the threads of the process like we do for getrusage? Otherwise the CLOCK_VIRTUAL and CLOCK_PROF clocks will only be updated upon a context switch. Probably. I wasn't 100% sure going the rusage route

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Todd C. Miller
On Wed, 15 Oct 2014 21:04:43 +0200, Mark Kettenis wrote: Oh, and while FreeBSD seems to implement CLOCK_VIRTUAL and CLOCK_PROF as per-process, Solaris implements them as per-thread (but doesn't document them). And on Solaris CLOCK_PROF is just an alias for CLOCK_THREAD_CPUTIME_ID

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Alexandre Ratchov
On Wed, Oct 15, 2014 at 11:37:26AM -0600, Todd C. Miller wrote: Since this came up in another thread. Trivial implementations of CLOCK_VIRTUAL and CLOCK_PROF, modeled after what FreeBSD does. out of curiousity, what program needs these?

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Todd C. Miller
On Wed, 15 Oct 2014 21:53:47 +0200, Alexandre Ratchov wrote: On Wed, Oct 15, 2014 at 11:37:26AM -0600, Todd C. Miller wrote: Since this came up in another thread. Trivial implementations of CLOCK_VIRTUAL and CLOCK_PROF, modeled after what FreeBSD does. out of curiousity, what program

Re: implement CLOCK_VIRTUAL and CLOCK_PROF

2014-10-15 Thread Philip Guenther
On Wed, Oct 15, 2014 at 2:08 PM, Todd C. Miller todd.mil...@courtesan.com wrote: On Wed, 15 Oct 2014 21:53:47 +0200, Alexandre Ratchov wrote: On Wed, Oct 15, 2014 at 11:37:26AM -0600, Todd C. Miller wrote: Since this came up in another thread. Trivial implementations of CLOCK_VIRTUAL

CLOCK_VIRTUAL

2014-10-14 Thread Jonas 'Sortie' Termansen
Hi, I noticed clock_gettime(2) describes a CLOCK_VIRTUAL clock that measures how long a process has run in user-space. However, it is not implemented in sys/kern/kern_time.c where it fails with EINVAL in the default switch case. It does seem to be implemented in FreeBSD and NetBSD along