I propose some changes in this diff. I move more of cmake calls to target
specific calls (target_sources, target_compile_definitions) to clean up the
files and reduce their scope.
On 14 Jun 2018, at 04:24, Brent Cook
mailto:bust...@gmail.com>> wrote:
You're correct, include/compat is
You're correct, include/compat is intended to be private. We will need to
make some tweaks here.
On Mon, Jun 4, 2018 at 5:36 PM, Cameron Palmer wrote:
> Question about the PUBLIC status of the ../include/compat headers in
> CMakeLists.txt.
>
> I wrote the target_include_directories calls to
Question about the PUBLIC status of the ../include/compat headers in
CMakeLists.txt.
I wrote the target_include_directories calls to include ../include/compat in
each of the targets and marked them PUBLIC, but I’m wondering if that will
cause conflicts with system headers like time.h and if
On Thu, May 24, 2018 at 10:10:58AM +, Cameron Palmer wrote:
> It is beneficial for projects that depend on LibreSSL libraries and are built
> with CMake to use target_link_libraries and automatically receive the PUBLIC
> or INTERFACE headers without needing to specify include_directories.
It is beneficial for projects that depend on LibreSSL libraries and are built
with CMake to use target_link_libraries and automatically receive the PUBLIC or
INTERFACE headers without needing to specify include_directories. This patch
changes the project to use target_include_directories and
