Re: Compare pointer value with NULL in openssl(1) pkcs12

2022-04-23 Thread Theo Buehler
> > > @@ -1095,7 +1095,7 @@ hex_prin(BIO *out, unsigned char *buf, i > > > static int > > > set_pbe(BIO *err, int *ppbe, const char *str) > > > { > > > - if (!str) > > > + if (str == NULL) > > > return 0; > > > if (!strcmp(str, "NONE")) { > > > > if (strcmp(str, "NONE") != 0) {

Re: Compare pointer value with NULL in openssl(1) pkcs12

2022-04-23 Thread Kinichiro Inoguchi
On Sat, Apr 23, 2022 at 08:31:50AM +0200, Theo Buehler wrote: > On Sat, Apr 23, 2022 at 01:45:12PM +0900, Kinichiro Inoguchi wrote: > > > I would like to do some clean up for openssl(1) pkcs12. > > This diff changes pointer value checking to explicit comparison with NULL, > > and no functional

Re: Compare pointer value with NULL in openssl(1) pkcs12

2022-04-23 Thread Theo Buehler
On Sat, Apr 23, 2022 at 01:45:12PM +0900, Kinichiro Inoguchi wrote: > I would like to do some clean up for openssl(1) pkcs12. > This diff changes pointer value checking to explicit comparison with NULL, > and no functional changes here. > This works fine for me on my local pc. > > ok? ok. Two

Compare pointer value with NULL in openssl(1) pkcs12

2022-04-22 Thread Kinichiro Inoguchi
I would like to do some clean up for openssl(1) pkcs12. This diff changes pointer value checking to explicit comparison with NULL, and no functional changes here. This works fine for me on my local pc. ok? Index: pkcs12.c === RCS