Re: Don't be verbose in in6_update_ifa()

2015-08-17 Thread Martin Pieuchot
On 11/08/15(Tue) 16:25, Alexander Bluhm wrote: On Mon, Aug 10, 2015 at 10:43:46PM +0200, Martin Pieuchot wrote: In general these messages do not help. Here we have two cases of messages, either logged at LOG_INFO or LOG_ERR. Yes, multiple logs for the same error are bad. But there is a

Re: Don't be verbose in in6_update_ifa()

2015-08-17 Thread Alexander Bluhm
On Mon, Aug 17, 2015 at 01:06:32PM +0200, Martin Pieuchot wrote: On 11/08/15(Tue) 16:25, Alexander Bluhm wrote: On Mon, Aug 10, 2015 at 10:43:46PM +0200, Martin Pieuchot wrote: In general these messages do not help. Here we have two cases of messages, either logged at LOG_INFO or

Re: Don't be verbose in in6_update_ifa()

2015-08-11 Thread Alexander Bluhm
On Mon, Aug 10, 2015 at 10:43:46PM +0200, Martin Pieuchot wrote: In general these messages do not help. Here we have two cases of messages, either logged at LOG_INFO or LOG_ERR. Yes, multiple logs for the same error are bad. But there is a path where we ignore the return code of

Don't be verbose in in6_update_ifa()

2015-08-10 Thread Martin Pieuchot
In general these messages do not help. Here we have two cases of messages, either logged at LOG_INFO or LOG_ERR. In the first case a proper error code is returned via ioctl(2), so the userland application knows it has done something incorrect. The second case correspond to a ENOMEM error, which