Re: Enable EVFILT_EXCEPT
On Fri, Aug 21, 2020 at 09:32:13AM +0200, Martin Pieuchot wrote: > The kqueue-based poll(2) backend is still a WIP due to regressions in > the kqueue layer. In the meantime should we expose EVFILT_EXCEPT to > userland? The diff below should be enough to allow userland apps to > use the new code paths. The EVFILT_EXCEPT macro is not guarded by #ifdef _KERNEL or similar. It is already visible to userspace, and some pieces of software may have tried to use it but have failed so far. OK visa@ > Index: sys/event.h > === > RCS file: /cvs/src/sys/sys/event.h,v > retrieving revision 1.44 > diff -u -p -r1.44 event.h > --- sys/event.h 22 Jun 2020 13:14:32 - 1.44 > +++ sys/event.h 21 Aug 2020 07:09:31 - > @@ -41,7 +41,7 @@ > #define EVFILT_DEVICE(-8)/* devices */ > #define EVFILT_EXCEPT(-9)/* exceptional conditions */ > > -#define EVFILT_SYSCOUNT 8 > +#define EVFILT_SYSCOUNT 9 > > #define EV_SET(kevp, a, b, c, d, e, f) do { \ > struct kevent *__kevp = (kevp); \ >
Re: Enable EVFILT_EXCEPT
ok mvs@ > On 21 Aug 2020, at 10:32, Martin Pieuchot wrote: > > The kqueue-based poll(2) backend is still a WIP due to regressions in > the kqueue layer. In the meantime should we expose EVFILT_EXCEPT to > userland? The diff below should be enough to allow userland apps to > use the new code paths. > > ok? > > Index: sys/event.h > === > RCS file: /cvs/src/sys/sys/event.h,v > retrieving revision 1.44 > diff -u -p -r1.44 event.h > --- sys/event.h 22 Jun 2020 13:14:32 - 1.44 > +++ sys/event.h 21 Aug 2020 07:09:31 - > @@ -41,7 +41,7 @@ > #define EVFILT_DEVICE (-8)/* devices */ > #define EVFILT_EXCEPT (-9)/* exceptional conditions */ > > -#define EVFILT_SYSCOUNT 8 > +#define EVFILT_SYSCOUNT 9 > > #define EV_SET(kevp, a, b, c, d, e, f) do { \ > struct kevent *__kevp = (kevp); \ >
Enable EVFILT_EXCEPT
The kqueue-based poll(2) backend is still a WIP due to regressions in the kqueue layer. In the meantime should we expose EVFILT_EXCEPT to userland? The diff below should be enough to allow userland apps to use the new code paths. ok? Index: sys/event.h === RCS file: /cvs/src/sys/sys/event.h,v retrieving revision 1.44 diff -u -p -r1.44 event.h --- sys/event.h 22 Jun 2020 13:14:32 - 1.44 +++ sys/event.h 21 Aug 2020 07:09:31 - @@ -41,7 +41,7 @@ #define EVFILT_DEVICE (-8)/* devices */ #define EVFILT_EXCEPT (-9)/* exceptional conditions */ -#define EVFILT_SYSCOUNT8 +#define EVFILT_SYSCOUNT9 #define EV_SET(kevp, a, b, c, d, e, f) do {\ struct kevent *__kevp = (kevp); \