Re: Fix -Wincompatible-pointer-types-discards-qualifiers

2021-01-08 Thread Theo Buehler
On Thu, Jan 07, 2021 at 11:30:43PM +, Adam Barth wrote: > Thanks so much! This is my first patch for OpenBSD, and I don't quite have > the workflow debugged yet. Committed, thank you! Probably easiest and safest way is to use git format-patch and to send the patch file as an attachment. This

Re: Fix -Wincompatible-pointer-types-discards-qualifiers

2021-01-07 Thread Adam Barth
Thanks so much! This is my first patch for OpenBSD, and I don't quite have the workflow debugged yet. Adam On Thu, Jan 7, 2021 at 11:29 PM Theo Buehler wrote: > On Thu, Jan 07, 2021 at 11:16:16PM +, Adam Barth wrote: > > Previously, this code was passing string constants to functions that

Fix -Wincompatible-pointer-types-discards-qualifiers

2021-01-07 Thread Adam Barth
Previously, this code was passing string constants to functions that did not declare their parameters as const. After this patch, the functions now declare that they do not modify these arguments, making it safe to pass string constants. diff --git lib/libc/gen/fts.c lib/libc/gen/fts.c index d13d0

Re: Fix -Wincompatible-pointer-types-discards-qualifiers

2021-01-07 Thread Todd C . Miller
On Fri, 08 Jan 2021 00:29:32 +0100, Theo Buehler wrote: > Thanks. Unfortunately the patch was mangled by your MUA (line wrapping > and expanded tabs). > > Below is a version that applies. OK millert@ as well. - todd

Re: Fix -Wincompatible-pointer-types-discards-qualifiers

2021-01-07 Thread Theo Buehler
On Thu, Jan 07, 2021 at 11:16:16PM +, Adam Barth wrote: > Previously, this code was passing string constants to functions that did > not declare their parameters as const. After this patch, the functions now > declare that they do not modify these arguments, making it safe to pass > string cons