Re: Fix description in OPENBSD-PF-MIB

2022-10-19 Thread Denis Fondras
Le Wed, Oct 19, 2022 at 08:36:46AM +0200, Martijn van Duren a écrit :
> As pointed out by Alec on misc@, there's a discrepancy between the
> name and description of several objects inside the pfIfTable.
> 
> Looks like a simple copy-paste error.
> 
> OK?
> 

OK denis@

> martijn@
> 
> Index: OPENBSD-PF-MIB.txt
> ===
> RCS file: /cvs/src/share/snmp/OPENBSD-PF-MIB.txt,v
> retrieving revision 1.7
> diff -u -p -r1.7 OPENBSD-PF-MIB.txt
> --- OPENBSD-PF-MIB.txt23 Mar 2021 19:37:51 -  1.7
> +++ OPENBSD-PF-MIB.txt19 Oct 2022 06:36:22 -
> @@ -36,7 +36,7 @@ IMPORTS
>   FROM SNMPv2-CONF;
>  
>  pfMIBObjects MODULE-IDENTITY
> -LAST-UPDATED "202103231933Z"
> +LAST-UPDATED "202210190830Z"
>  ORGANIZATION "OpenBSD"
>  CONTACT-INFO "
>Author: Joel Knight
> @@ -46,6 +46,8 @@ pfMIBObjects MODULE-IDENTITY
>  DESCRIPTION "The MIB module for gathering information from
>   OpenBSD's packet filter.
>  "
> +REVISION "202210190830Z"
> +DESCRIPTION "Fix description of several objects from bytes to the 
> obviously intended packets"
>  REVISION "202103231933Z"
>  DESCRIPTION "Use DisplayString/SnmpAdminString not OCTET STRING where 
> appropriate"
>  REVISION "201506091728Z"
> @@ -794,7 +796,7 @@ pfIfOut4PassPkts OBJECT-TYPE
>   MAX-ACCESS  read-only
>   STATUS  current
>   DESCRIPTION
> - "The number of IPv4 bytes passed out."
> + "The number of IPv4 packets passed out."
>   ::= { pfIfEntry 10 }
>  
>  pfIfOut4PassBytes OBJECT-TYPE
> @@ -810,7 +812,7 @@ pfIfOut4BlockPkts OBJECT-TYPE
>   MAX-ACCESS  read-only
>   STATUS  current
>   DESCRIPTION
> - "The number of outgoing IPv4 bytes blocked."
> + "The number of outgoing IPv4 packets blocked."
>   ::= { pfIfEntry 12 }
>  
>  pfIfOut4BlockBytes OBJECT-TYPE
> @@ -858,7 +860,7 @@ pfIfOut6PassPkts OBJECT-TYPE
>   MAX-ACCESS  read-only
>   STATUS  current
>   DESCRIPTION
> - "The number of IPv6 bytes passed out."
> + "The number of IPv6 packets passed out."
>   ::= { pfIfEntry 18 }
>  
>  pfIfOut6PassBytes OBJECT-TYPE
> @@ -874,7 +876,7 @@ pfIfOut6BlockPkts OBJECT-TYPE
>   MAX-ACCESS  read-only
>   STATUS  current
>   DESCRIPTION
> - "The number of outgoing IPv6 bytes blocked."
> + "The number of outgoing IPv6 packets blocked."
>   ::= { pfIfEntry 20 }
>  
>  pfIfOut6BlockBytes OBJECT-TYPE
> 



Fix description in OPENBSD-PF-MIB

2022-10-19 Thread Martijn van Duren
As pointed out by Alec on misc@, there's a discrepancy between the
name and description of several objects inside the pfIfTable.

Looks like a simple copy-paste error.

OK?

martijn@

Index: OPENBSD-PF-MIB.txt
===
RCS file: /cvs/src/share/snmp/OPENBSD-PF-MIB.txt,v
retrieving revision 1.7
diff -u -p -r1.7 OPENBSD-PF-MIB.txt
--- OPENBSD-PF-MIB.txt  23 Mar 2021 19:37:51 -  1.7
+++ OPENBSD-PF-MIB.txt  19 Oct 2022 06:36:22 -
@@ -36,7 +36,7 @@ IMPORTS
FROM SNMPv2-CONF;
 
 pfMIBObjects MODULE-IDENTITY
-LAST-UPDATED "202103231933Z"
+LAST-UPDATED "202210190830Z"
 ORGANIZATION "OpenBSD"
 CONTACT-INFO "
   Author: Joel Knight
@@ -46,6 +46,8 @@ pfMIBObjects MODULE-IDENTITY
 DESCRIPTION "The MIB module for gathering information from
OpenBSD's packet filter.
 "
+REVISION "202210190830Z"
+DESCRIPTION "Fix description of several objects from bytes to the 
obviously intended packets"
 REVISION "202103231933Z"
 DESCRIPTION "Use DisplayString/SnmpAdminString not OCTET STRING where 
appropriate"
 REVISION "201506091728Z"
@@ -794,7 +796,7 @@ pfIfOut4PassPkts OBJECT-TYPE
MAX-ACCESS  read-only
STATUS  current
DESCRIPTION
-   "The number of IPv4 bytes passed out."
+   "The number of IPv4 packets passed out."
::= { pfIfEntry 10 }
 
 pfIfOut4PassBytes OBJECT-TYPE
@@ -810,7 +812,7 @@ pfIfOut4BlockPkts OBJECT-TYPE
MAX-ACCESS  read-only
STATUS  current
DESCRIPTION
-   "The number of outgoing IPv4 bytes blocked."
+   "The number of outgoing IPv4 packets blocked."
::= { pfIfEntry 12 }
 
 pfIfOut4BlockBytes OBJECT-TYPE
@@ -858,7 +860,7 @@ pfIfOut6PassPkts OBJECT-TYPE
MAX-ACCESS  read-only
STATUS  current
DESCRIPTION
-   "The number of IPv6 bytes passed out."
+   "The number of IPv6 packets passed out."
::= { pfIfEntry 18 }
 
 pfIfOut6PassBytes OBJECT-TYPE
@@ -874,7 +876,7 @@ pfIfOut6BlockPkts OBJECT-TYPE
MAX-ACCESS  read-only
STATUS  current
DESCRIPTION
-   "The number of outgoing IPv6 bytes blocked."
+   "The number of outgoing IPv6 packets blocked."
::= { pfIfEntry 20 }
 
 pfIfOut6BlockBytes OBJECT-TYPE